* [patch] clean up unused kiocb variables
@ 2006-09-21 18:53 Chen, Kenneth W
2006-09-21 19:33 ` Zach Brown
0 siblings, 1 reply; 4+ messages in thread
From: Chen, Kenneth W @ 2006-09-21 18:53 UTC (permalink / raw)
To: 'Andrew Morton', 'Suparna Bhattacharya'; +Cc: linux-kernel
Any reason why we keep these two variables around for kiocb structure?
They are not used anywhere.
Patch to tidy up kiocb structure.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
--- ./include/linux/aio.h.orig 2006-09-21 10:03:36.000000000 -0700
+++ ./include/linux/aio.h 2006-09-21 10:03:56.000000000 -0700
@@ -110,8 +110,6 @@
char __user *ki_buf; /* remaining iocb->aio_buf */
size_t ki_left; /* remaining bytes */
long ki_retried; /* just for testing */
- long ki_kicked; /* just for testing */
- long ki_queued; /* just for testing */
struct list_head ki_list; /* the aio core uses this
* for cancellation */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] clean up unused kiocb variables
2006-09-21 18:53 [patch] clean up unused kiocb variables Chen, Kenneth W
@ 2006-09-21 19:33 ` Zach Brown
2006-09-21 20:26 ` Chen, Kenneth W
0 siblings, 1 reply; 4+ messages in thread
From: Zach Brown @ 2006-09-21 19:33 UTC (permalink / raw)
To: Chen, Kenneth W
Cc: 'Andrew Morton', 'Suparna Bhattacharya',
linux-kernel, linux-aio
Chen, Kenneth W wrote:
> Any reason why we keep these two variables around for kiocb structure?
If there is a good one I've forgotten it.
> They are not used anywhere.
Indeed.
The ki_retried users all seem pretty questionable, too. How about
removing all that stuff?
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Signed-off-by: Zach Brown <zach.brown@oracle.com>
- z
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [patch] clean up unused kiocb variables
2006-09-21 19:33 ` Zach Brown
@ 2006-09-21 20:26 ` Chen, Kenneth W
2006-09-21 20:30 ` Zach Brown
0 siblings, 1 reply; 4+ messages in thread
From: Chen, Kenneth W @ 2006-09-21 20:26 UTC (permalink / raw)
To: 'Zach Brown'
Cc: 'Andrew Morton', 'Suparna Bhattacharya',
linux-kernel, linux-aio
Zach Brown wrote on Thursday, September 21, 2006 12:34 PM
> Chen, Kenneth W wrote:
> > Any reason why we keep these two variables around for kiocb structure?
>
> If there is a good one I've forgotten it.
>
> > They are not used anywhere.
>
> Indeed.
Let's remove them. We can always add them back if there is a need.
> The ki_retried users all seem pretty questionable, too. How about
> removing all that stuff?
Suparna wanted them around for debug purpose at one point. I don't know
whether that is still the case right now. At least I can wrap it around
with #if DEBUG.
- Ken
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] clean up unused kiocb variables
2006-09-21 20:26 ` Chen, Kenneth W
@ 2006-09-21 20:30 ` Zach Brown
0 siblings, 0 replies; 4+ messages in thread
From: Zach Brown @ 2006-09-21 20:30 UTC (permalink / raw)
To: Chen, Kenneth W
Cc: 'Andrew Morton', 'Suparna Bhattacharya',
linux-kernel, linux-aio
> Let's remove them. We can always add them back if there is a need.
Agreed, especially in this age of dynamic probing.
> Suparna wanted them around for debug purpose at one point. I don't know
> whether that is still the case right now. At least I can wrap it around
> with #if DEBUG.
I guess that's better than nothing. Given the near total lack of
-EIOCBRETRY users I'm just not convinced that they're worth it.
- z
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-09-21 20:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 18:53 [patch] clean up unused kiocb variables Chen, Kenneth W
2006-09-21 19:33 ` Zach Brown
2006-09-21 20:26 ` Chen, Kenneth W
2006-09-21 20:30 ` Zach Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox