From: Tilman Schmidt <tilman@imap.cc>
To: linux-kernel@vger.kernel.org
Cc: john stultz <johnstul@us.ibm.com>
Subject: Re: [2.6.18-rc7] printk output delay in syslog wrt dmesg still unfixed
Date: Fri, 22 Sep 2006 01:28:24 +0200 [thread overview]
Message-ID: <45132018.8070501@imap.cc> (raw)
In-Reply-To: <1158691933.18546.3.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On 19.09.2006 20:52, john stultz wrote:
> You might try git-bisect to find the offending patch.
This turned out to be easier than I expected.
The patch which introduces the problem is:
[a0f1ccfd8d37457a6d8a9e01acebeefcdfcc306e] lockdep: do not recurse in printk
Reverting that patch makes the problem disappear in 2.6.18, too.
In fact, it suffices to revert just the last chunk:
@@ -809,8 +815,15 @@ void release_console_sem(void)
console_may_schedule = 0;
up(&console_sem);
spin_unlock_irqrestore(&logbuf_lock, flags);
- if (wake_klogd && !oops_in_progress && waitqueue_active(&log_wait))
- wake_up_interruptible(&log_wait);
+ if (wake_klogd && !oops_in_progress && waitqueue_active(&log_wait)) {
+ /*
+ * If we printk from within the lock dependency code,
+ * from within the scheduler code, then do not lock
+ * up due to self-recursion:
+ */
+ if (!lockdep_internal())
+ wake_up_interruptible(&log_wait);
+ }
}
EXPORT_SYMBOL(release_console_sem);
Hope that helps.
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeoeffnet mindestens haltbar bis: (siehe Rueckseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]
next prev parent reply other threads:[~2006-09-21 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-16 12:45 [2.6.18-rc7] printk output delay in syslog wrt dmesg still unfixed Tilman Schmidt
2006-09-19 18:52 ` john stultz
2006-09-20 10:01 ` Tilman Schmidt
2006-09-21 23:28 ` Tilman Schmidt [this message]
2006-09-21 23:35 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45132018.8070501@imap.cc \
--to=tilman@imap.cc \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox