From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Martin Bligh <mbligh@google.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
prasanna@in.ibm.com, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@elte.hu>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jes Sorensen <jes@sgi.com>, Tom Zanussi <zanussi@us.ibm.com>,
Richard J Moore <richardj_moore@uk.ibm.com>,
Michel Dagenais <michel.dagenais@polymtl.ca>,
Christoph Hellwig <hch@infradead.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
William Cohen <wcohen@redhat.com>,
ltt-dev@shafik.org, systemtap@sources.redhat.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Linux Kernel Markers 0.7 for 2.6.17 (with type checking!)
Date: Thu, 21 Sep 2006 17:43:13 -0700 [thread overview]
Message-ID: <451331A1.3020601@goop.org> (raw)
In-Reply-To: <20060921232024.GA16155@Krystal>
Mathieu Desnoyers wrote:
> +#ifdef CONFIG_MARK_SYMBOL
> +#define MARK_SYM(name) \
> + do { \
> + __label__ here; \
> + here: asm volatile \
> + (MARK_KPROBE_PREFIX#name " = %0" : : "m" (*&&here)); \
> + } while(0)
> +#else
> +#define MARK_SYM(name)
> +#endif
BTW, this won't work if you put the MARK_SYM in a loop which gcc
unrolls; you'll only get the mark in the last unrolled iteration
(because the symbol assignments will override each other).
Do make this work properly, you really need to put the mark entries into
a separate section, so that if gcc duplicates the code, you get
duplicated markers too.
J
next prev parent reply other threads:[~2006-09-22 0:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 23:20 [PATCH] Linux Kernel Markers 0.7 for 2.6.17 (with type checking!) Mathieu Desnoyers
2006-09-22 0:43 ` Jeremy Fitzhardinge [this message]
2006-09-22 2:01 ` Mathieu Desnoyers
2006-09-22 2:06 ` Jeremy Fitzhardinge
2006-09-22 2:14 ` Mathieu Desnoyers
2006-09-22 3:59 ` Jeremy Fitzhardinge
2006-09-22 15:27 ` Mathieu Desnoyers
2006-09-22 2:38 ` Mathieu Desnoyers
2006-09-22 4:00 ` Jeremy Fitzhardinge
2006-10-07 2:47 ` Proof of concept: Logdev with "almost-non" intrusive markers Steven Rostedt
2006-10-10 13:40 ` Mathieu Desnoyers
2006-10-11 3:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451331A1.3020601@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=jes@sgi.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=michel.dagenais@polymtl.ca \
--cc=mingo@elte.hu \
--cc=prasanna@in.ibm.com \
--cc=richardj_moore@uk.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
--cc=wcohen@redhat.com \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox