From: Jeff Garzik <jeff@garzik.org>
To: Judith Lebzelter <judith@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dale@farnsworth.org
Subject: Re: Arrr! Linux 2.6.18
Date: Fri, 22 Sep 2006 18:08:25 -0400 [thread overview]
Message-ID: <45145ED9.1080801@garzik.org> (raw)
In-Reply-To: <20060922215120.GD23169@shell0.pdx.osdl.net>
Judith Lebzelter wrote:
>> Dale Farnsworth:
>> mv643xx_eth: Unmap DMA buffers in receive path
>>
>
> In OSDL's automated cross-compile for powerpc64, kernel 2.6.18 had this
> unexpected error:
>
> drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_receive_queue':
> drivers/net/mv643xx_eth.c:388: error: 'RX_SKB_SIZE' undeclared (first use in this function)
>
> Here is a patch that stops the error.
>
> Judith Lebzelter
> OSDL
>
> --- drivers/net/mv643xx_eth.c.old 2006-09-22 11:22:47.951049416 -0700
> +++ drivers/net/mv643xx_eth.c 2006-09-22 11:23:17.787625304 -0700
> @@ -385,7 +385,7 @@
> struct pkt_info pkt_info;
>
> while (budget-- > 0 && eth_port_receive(mp, &pkt_info) == ETH_OK) {
> - dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE,
> + dma_unmap_single(NULL, pkt_info.buf_ptr, ETH_RX_SKB_SIZE,
> DMA_FROM_DEVICE);
Man, talk about timing. I just sent this to Andrew & Linus just a few
seconds ago :)
Jeff
next prev parent reply other threads:[~2006-09-22 22:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 4:33 Arrr! Linux 2.6.18 Linus Torvalds
2006-09-20 4:59 ` Michal Piotrowski
2006-09-20 7:25 ` [patch] do_no_pfn() Jes Sorensen
2006-09-20 15:46 ` Randy.Dunlap
2006-09-20 16:47 ` Jes Sorensen
2006-09-22 19:49 ` Andrew Morton
2006-09-25 9:31 ` Jes Sorensen
2006-09-22 21:51 ` Arrr! Linux 2.6.18 Judith Lebzelter
2006-09-22 22:08 ` Jeff Garzik [this message]
2006-09-22 22:57 ` Dale Farnsworth
2006-09-22 22:58 ` Jeff Garzik
2006-09-29 8:36 ` Mark Lord
2006-09-29 14:49 ` Linus Torvalds
2006-09-29 8:40 ` Mark Lord
2006-09-29 8:44 ` Andrew Morton
2006-09-29 17:52 ` Mark Lord
2006-09-29 19:42 ` Rafael J. Wysocki
2006-09-29 19:58 ` Mark Lord
-- strict thread matches above, loose matches on Subject: below --
2006-09-30 15:47 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45145ED9.1080801@garzik.org \
--to=jeff@garzik.org \
--cc=dale@farnsworth.org \
--cc=judith@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox