From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Results of my work on memorystick subsystem
Date: Mon, 18 Oct 2010 00:05:51 -0700 (PDT) [thread overview]
Message-ID: <451805.21484.qm@web37607.mail.mud.yahoo.com> (raw)
In-Reply-To: <1287356101.25869.1.camel@maxim-laptop>
--- On Sun, 17/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> >
> > Here is a result of lot of work I did improving the
> memorystick
> > subsystem and its drivers.
> Comments?
> Flames?
> Suggestions?
>
My opinion is, that in the current form your patches are completely
unworkable.
I suggest a following approach, consisting of 3 clearly separated steps:
Step 1 - a set of functional patches to jmicron driver.
Step 2 - a set of functional patches to mspro driver.
Step 3 - common code elimination (the whole thing is not that large, it
can tolerate some code duplication).
When we done with this, we can discuss whatever cosmetic changes you want
to do (moving stuff around and , possibly, renaming, which I don't see as
necessary at all).
next prev parent reply other threads:[~2010-10-18 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 23:12 [PATCH 0/6] Results of my work on memorystick subsystem Maxim Levitsky
2010-10-16 23:12 ` [PATCH 1/6] memstick: core: add series of common helpers Maxim Levitsky
2010-10-16 23:12 ` [PATCH 2/6] memstick: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-10-16 23:12 ` [PATCH 3/6] memstick: jmb38x: Driver rework Maxim Levitsky
2010-10-16 23:12 ` [PATCH 4/6] memstick: add support for legacy memorysticks Maxim Levitsky
2010-10-16 23:12 ` [PATCH 5/6] memstick: mspro_block: refactoring Maxim Levitsky
2010-10-16 23:12 ` [PATCH 6/6] memstick: stop passing useless pointer to card->current_mrq + refactoring Maxim Levitsky
2010-10-17 22:55 ` [PATCH 0/6] Results of my work on memorystick subsystem Maxim Levitsky
2010-10-18 7:05 ` Alex Dubov [this message]
2010-10-18 14:06 ` Maxim Levitsky
2010-10-19 9:40 ` Alex Dubov
2010-10-19 10:47 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451805.21484.qm@web37607.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox