* [PATCH] restore __iomem annotations in e1000
@ 2006-09-23 0:32 Al Viro
2006-09-26 0:08 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Al Viro @ 2006-09-23 0:32 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/net/e1000/e1000_hw.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h
index 375b955..a7e3a82 100644
--- a/drivers/net/e1000/e1000_hw.h
+++ b/drivers/net/e1000/e1000_hw.h
@@ -1365,8 +1365,8 @@ struct e1000_hw_stats {
/* Structure containing variables used by the shared code (e1000_hw.c) */
struct e1000_hw {
- uint8_t *hw_addr;
- uint8_t *flash_address;
+ uint8_t __iomem *hw_addr;
+ uint8_t __iomem *flash_address;
e1000_mac_type mac_type;
e1000_phy_type phy_type;
uint32_t phy_init_script;
--
1.4.2.GIT
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] restore __iomem annotations in e1000
2006-09-23 0:32 [PATCH] restore __iomem annotations in e1000 Al Viro
@ 2006-09-26 0:08 ` Jeff Garzik
2006-09-26 5:02 ` Auke Kok
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2006-09-26 0:08 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] restore __iomem annotations in e1000
2006-09-26 0:08 ` Jeff Garzik
@ 2006-09-26 5:02 ` Auke Kok
2006-09-26 5:32 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Auke Kok @ 2006-09-26 5:02 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Al Viro, linux-kernel
Jeff Garzik wrote:
> applied
>
Thanks,
I have no idea why and when these annotations were lost, but we have them in
much older versions of the code. I'll try to track it down and make sure that
it doesn't disappear again.
Cheers,
Auke
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] restore __iomem annotations in e1000
2006-09-26 5:02 ` Auke Kok
@ 2006-09-26 5:32 ` Jeff Garzik
2006-09-26 17:37 ` Auke Kok
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2006-09-26 5:32 UTC (permalink / raw)
To: Auke Kok; +Cc: Al Viro, linux-kernel
Auke Kok wrote:
> Jeff Garzik wrote:
>> applied
>>
>
> Thanks,
>
> I have no idea why and when these annotations were lost, but we have
> them in much older versions of the code. I'll try to track it down and
> make sure that it doesn't disappear again.
Just run an sparse check as described in
Documentation/sparse.txt...
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] restore __iomem annotations in e1000
2006-09-26 5:32 ` Jeff Garzik
@ 2006-09-26 17:37 ` Auke Kok
0 siblings, 0 replies; 5+ messages in thread
From: Auke Kok @ 2006-09-26 17:37 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Al Viro, linux-kernel
Jeff Garzik wrote:
> Auke Kok wrote:
>> Jeff Garzik wrote:
>>> applied
>>>
>>
>> Thanks,
>>
>> I have no idea why and when these annotations were lost, but we have
>> them in much older versions of the code. I'll try to track it down and
>> make sure that it doesn't disappear again.
>
> Just run an sparse check as described in
> Documentation/sparse.txt...
gotcha, I'll try to do this on a regular basis.
Thanks,
Auke
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-09-26 17:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-23 0:32 [PATCH] restore __iomem annotations in e1000 Al Viro
2006-09-26 0:08 ` Jeff Garzik
2006-09-26 5:02 ` Auke Kok
2006-09-26 5:32 ` Jeff Garzik
2006-09-26 17:37 ` Auke Kok
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox