Re: [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property

David Heidelberg
2023-07-10T15:36:29Z

On 10/07/2023 16:35, Mark Kettenis wrote:
>> From: Heiko Stuebner <heiko@sntech.de>
>> Date: Mon, 10 Jul 2023 16:16:16 +0200
>>
>> On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote:
>>> The 'regulator-init-microvolt' property is not currently supported by
>>> any driver, it was simply carried on from downstream kernels.
>>>
>>> The problem is also indicated by the following dtbs_check warning:
>>>
>>> rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
>>>
>>> [...]
>> Applied, thanks!
>>
>> [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
>> commit: 4d08b19629495b29601991d09d07865694c25199
> This property *is used* by the drivers in U-Boot. Dropping this from
> the Linux DTBs will likely result in broken boards the next time the
> U-Boot DTBs are synched again from Linux. At least that is what
> happened before...
Well, if u-boot uses these properties, u-boot folks should document them
in bindings ;-)
I found some u-boot mentions reviewing this patch, but only the DTS
files copied from Linux poped-up.
>
> I think the right solution is to add this property to the DT binding
> instead.

Sure, it should be sent together with the revert.
DT binding property description could also note that the bootloader(s)
use the value.

David

--
David Heidelberg
Consultant Software Engineer