Re: [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property

Heiko Stuebner
2023-07-10T15:40:34Z

Am Montag, 10. Juli 2023, 16:35:36 CEST schrieb Mark Kettenis:
> > From: Heiko Stuebner <heiko@sntech.de>
> > Date: Mon, 10 Jul 2023 16:16:16 +0200
> >
> > On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote:
> > > The 'regulator-init-microvolt' property is not currently supported by
> > > any driver, it was simply carried on from downstream kernels.
> > >
> > > The problem is also indicated by the following dtbs_check warning:
> > >
> > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
> > commit: 4d08b19629495b29601991d09d07865694c25199
>
> This property *is used* by the drivers in U-Boot. Dropping this from
> the Linux DTBs will likely result in broken boards the next time the
> U-Boot DTBs are synched again from Linux. At least that is what
> happened before...
>
> I think the right solution is to add this property to the DT binding
> instead.

I do have this vague memory of this coming up in the past, though don't
remember what the resolution was then? Though it definitly doesn't look
like the property was added to the binding in the meantime.

Also I think that setting up initial regulator state would be (and
seemingly is) for firmware to handle, so that property should instead
be in the -uboot.dtsi.

That DT isn't a configuration-space also is a decade long mantra.

Heiko