From: Chuck Lever <chuck.lever@oracle.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Possible dereference in fs/nfsd/nfs4callback.c
Date: Tue, 26 Sep 2006 08:58:56 -0400 [thread overview]
Message-ID: <45192410.6070801@oracle.com> (raw)
In-Reply-To: <1159266659.5413.3.camel@alice>
Eric Sesterhenn wrote:
> hi,
>
> the following commit introduced a possible NULL pointer dereference
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ae5c79476f36512d1100e162606bb5691f2cce5a
>
> we set cb->cb_client to NULL and pass it to rpc_shutdown_client() which dereferences it.
What was I thinking/smoking? ;-)
> The easy fix below.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-git5/fs/nfsd/nfs4callback.c.orig 2006-09-26 12:24:23.000000000 +0200
> +++ linux-2.6.18-git5/fs/nfsd/nfs4callback.c 2006-09-26 12:24:40.000000000 +0200
> @@ -450,7 +450,8 @@ out_rpciod:
> rpciod_down();
> cb->cb_client = NULL;
> out_clnt:
> - rpc_shutdown_client(cb->cb_client);
> + if (cb->cb_client)
> + rpc_shutdown_client(cb->cb_client);
> out_err:
> dprintk("NFSD: warning: no callback path to client %.*s\n",
> (int)clp->cl_name.len, clp->cl_name.data);
Actually I see another problem here.
rpc_create() doesn't return NULL, it returns an ERR_PTR. So the return
code check in the code just before this is also bogus.
I'll send a complete fix through Trond.
next prev parent reply other threads:[~2006-09-26 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 10:30 [Patch] Possible dereference in fs/nfsd/nfs4callback.c Eric Sesterhenn
2006-09-26 12:58 ` Chuck Lever [this message]
2006-09-26 13:17 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45192410.6070801@oracle.com \
--to=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox