From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Martin Bligh <mbligh@google.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
prasanna@in.ibm.com, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@elte.hu>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jes Sorensen <jes@sgi.com>, Tom Zanussi <zanussi@us.ibm.com>,
Richard J Moore <richardj_moore@uk.ibm.com>,
Michel Dagenais <michel.dagenais@polymtl.ca>,
Christoph Hellwig <hch@infradead.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
William Cohen <wcohen@redhat.com>,
ltt-dev@shafik.org, systemtap@sources.redhat.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Karim Yaghmour <karim@opersys.com>, Pavel Machek <pavel@suse.cz>,
Joe Perches <joe@perches.com>,
"Randy.Dunlap" <rdunlap@xenotime.net>,
"Jose R. Santos" <jrs@us.ibm.com>
Subject: Re: [PATCH] Linux Kernel Markers 0.14 for 2.6.17
Date: Tue, 26 Sep 2006 15:11:22 -0700 [thread overview]
Message-ID: <4519A58A.7070302@goop.org> (raw)
In-Reply-To: <20060926220604.GA30396@Krystal>
Mathieu Desnoyers wrote:
> Hi,
>
> Constructing on Jeremy Fitzhardinge's comments about gcc optimizations, I
> rewrote (once more) the markers mechanism so that the optimized mode does not
> jump between two different inline asm. Instead, the optimized version uses a
> load immediate (in assembly) that will be used by a test to decide of a branch
> (in C).
>
I should have spelled out my point a bit more. If you've got a flag
you're just testing, couldn't you just do:
if (__mark_enabled_##name)
(*__mark_func)(...);
and do without the asms or the section?
The section will still be useful for simply labelling the mark sites,
but if you want to call something there, you don't need it.
J
next prev parent reply other threads:[~2006-09-26 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 22:06 [PATCH] Linux Kernel Markers 0.14 for 2.6.17 Mathieu Desnoyers
2006-09-26 22:11 ` Jeremy Fitzhardinge [this message]
2006-09-26 22:27 ` Mathieu Desnoyers
2006-09-26 23:08 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4519A58A.7070302@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=jes@sgi.com \
--cc=joe@perches.com \
--cc=jrs@us.ibm.com \
--cc=karim@opersys.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=michel.dagenais@polymtl.ca \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=prasanna@in.ibm.com \
--cc=rdunlap@xenotime.net \
--cc=richardj_moore@uk.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
--cc=wcohen@redhat.com \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox