From: john cooper <john.cooper@third-harmonic.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>,
linux-kernel@vger.kernel.org,
john cooper <john.cooper@third-harmonic.com>
Subject: 2.6.18-rt4
Date: Wed, 27 Sep 2006 09:10:26 -0400 [thread overview]
Message-ID: <451A7842.4090201@third-harmonic.com> (raw)
In-Reply-To: <20060922115636.GA12212@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Ingo Molnar wrote:
> * Lennert Buytenhek <buytenh@wantstofly.org> wrote:
>
>> On Thu, Sep 21, 2006 at 10:19:21PM -0400, john cooper wrote:
>>
>>>> ok, i've uploaded -rt3:
>>> Attached is a patch which fixes a build problem
>>> for ARM pxa270, and general ARM boot issue when
>>> LATENCY_TRACE is configured.
>> This patch (queued for Linus) lifts that 4MB limitation:
>>
>> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=3809/2
>>
>> (I ran into the limit when enabling lockdep on ARM.)
>
> ok, i've added this no-4M-limit patch to -rt. John, does that solve your
> problem?
A few of us hit a snag in Lennert's original patch. He has a
fix which addresses this, attached.
-john
--
john.cooper@third-harmonic.com
[-- Attachment #2: fix-allow-large-kernels.diff --]
[-- Type: text/x-patch, Size: 985 bytes --]
The 'sub r3, r3, r5' check to determine the compressed kernel size in
arch/arm/boot/compressed/head.S doesn't work properly, since at that
point, r3 will have been overwritten by cache_on().
What we can do is to use sp instead, which does not get clobbered in
the meanwhile. Using sp will give us a slightly higher compressed
kernel image size guess than when using r3, but that's safe.
Bug reported by John Cooper and David Anders.
Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
Index: linux-2.6.18/arch/arm/boot/compressed/head.S
===================================================================
--- linux-2.6.18.orig/arch/arm/boot/compressed/head.S
+++ linux-2.6.18/arch/arm/boot/compressed/head.S
@@ -240,7 +240,7 @@ not_relocated: mov r0, #0
*/
cmp r4, r2
bhs wont_overwrite
- sub r3, r3, r5 @ compressed kernel size
+ sub r3, sp, r5 @ > compressed kernel image
add r0, r4, r3, lsl #2 @ allow for 4x expansion
cmp r0, r5
bls wont_overwrite
next prev parent reply other threads:[~2006-09-27 13:13 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 14:19 2.6.18-rt1 Ingo Molnar
2006-09-20 16:50 ` 2.6.18-rt1 Gene Heskett
2006-09-20 16:58 ` 2.6.18-rt1 Ingo Molnar
2006-09-20 17:33 ` 2.6.18-rt1 Gene Heskett
2006-09-20 18:34 ` 2.6.18-rt1 Gene Heskett
2006-09-20 17:00 ` 2.6.18-rt1 Daniel Walker
2006-09-20 17:38 ` 2.6.18-rt1 Paul E. McKenney
2006-09-20 17:41 ` 2.6.18-rt1 Daniel Walker
2006-09-20 18:23 ` 2.6.18-rt1 Gene Heskett
2006-09-20 18:25 ` 2.6.18-rt1 Paul E. McKenney
2006-09-20 18:34 ` 2.6.18-rt1 Daniel Walker
2006-09-20 20:06 ` 2.6.18-rt1 Paul E. McKenney
2006-09-20 21:38 ` 2.6.18-rt1 Gene Heskett
2006-09-20 20:17 ` 2.6.18-rt1 Gene Heskett
2006-09-20 18:36 ` 2.6.18-rt1 Gene Heskett
2006-09-20 18:47 ` 2.6.18-rt1 Thomas Gleixner
2006-09-20 19:20 ` 2.6.18-rt1 Thomas Gleixner
2006-09-20 19:46 ` 2.6.18-rt1 Ingo Molnar
2006-09-20 20:19 ` 2.6.18-rt1 Daniel Walker
2006-09-20 20:14 ` 2.6.18-rt1 Ingo Molnar
2006-09-20 20:31 ` 2.6.18-rt1 Daniel Walker
2006-09-21 19:02 ` 2.6.18-rt1 Ingo Molnar
2006-09-21 19:18 ` 2.6.18-rt1 Daniel Walker
2006-09-22 14:42 ` 2.6.18-rt1 Daniel Walker
2006-09-27 8:36 ` 2.6.18-rt1 Ingo Molnar
2006-09-21 8:04 ` 2.6.18-rt1 Deepak Saxena
2006-09-21 8:04 ` 2.6.18-rt1 Ingo Molnar
2006-09-21 8:24 ` 2.6.18-rt1 Deepak Saxena
2006-09-22 2:19 ` 2.6.18-rt1 john cooper
2006-09-22 6:36 ` 2.6.18-rt1 Lennert Buytenhek
2006-09-22 11:56 ` 2.6.18-rt1 Ingo Molnar
2006-09-27 13:10 ` john cooper [this message]
2006-09-27 13:09 ` 2.6.18-rt4 Ingo Molnar
2006-09-20 18:56 ` 2.6.18-rt1 K.R. Foley
2006-09-20 19:49 ` 2.6.18-rt1 Ingo Molnar
2006-09-20 20:33 ` 2.6.18-rt1 K.R. Foley
2006-09-20 20:41 ` 2.6.18-rt1 Thomas Gleixner
2006-09-20 20:50 ` 2.6.18-rt1 K.R. Foley
2006-09-21 19:16 ` 2.6.18-rt1 john stultz
2006-09-22 2:18 ` 2.6.18-rt1 K.R. Foley
2006-09-22 11:58 ` 2.6.18-rt1 Ingo Molnar
2006-09-28 0:42 ` 2.6.18-rt1 john stultz
2006-09-28 22:48 ` 2.6.18-rt1 john stultz
2006-09-29 2:09 ` 2.6.18-rt1 K.R. Foley
2006-09-29 12:24 ` 2.6.18-rt1 Ingo Molnar
2006-09-29 12:40 ` 2.6.18-rt1 Ingo Molnar
2006-09-20 19:58 ` 2.6.18-rt1 Thomas Gleixner
2006-09-20 20:34 ` 2.6.18-rt1 K.R. Foley
2006-09-20 19:38 ` 2.6.18-rt1 Mark Knecht
2006-09-20 20:27 ` 2.6.18-rt1 Mark Knecht
2006-09-22 14:14 ` 2.6.18-rt1 Lee Revell
2006-09-20 20:54 ` 2.6.18-rt1 Michal Piotrowski
2006-09-20 22:07 ` 2.6.18-rt1 Michal Piotrowski
2006-09-20 22:26 ` 2.6.18-rt1 Michal Piotrowski
2006-09-21 6:56 ` [PATCH] move put_task_struct() reaping into a thread [Re: 2.6.18-rt1] Bill Huey
2006-09-21 6:54 ` Ingo Molnar
2006-09-21 7:18 ` Bill Huey
2006-09-21 7:16 ` Ingo Molnar
2006-09-21 7:32 ` Bill Huey
2006-09-21 7:29 ` Ingo Molnar
2006-09-21 7:48 ` Bill Huey
2006-09-21 7:56 ` Ingo Molnar
2006-09-21 8:13 ` Bill Huey
2006-09-21 12:23 ` Esben Nielsen
2006-09-21 12:56 ` Ingo Molnar
2006-09-21 7:27 ` Bill Huey
2006-09-21 7:22 ` Ingo Molnar
2006-09-21 7:35 ` Bill Huey
2006-09-21 7:31 ` Ingo Molnar
2006-09-21 7:52 ` Bill Huey
2006-09-27 2:55 ` Eric W. Biederman
2006-09-27 5:08 ` Bill Huey
2006-09-27 6:02 ` Eric W. Biederman
2006-09-27 6:34 ` Bill Huey
2006-09-27 7:29 ` Eric W. Biederman
2006-09-27 9:01 ` Ingo Molnar
2006-09-27 13:59 ` Eric W. Biederman
2006-09-27 14:06 ` Ingo Molnar
2006-09-27 16:18 ` Paul E. McKenney
2006-09-27 9:08 ` Ingo Molnar
2006-09-27 9:09 ` Bill Huey
2006-09-27 9:05 ` Ingo Molnar
2006-09-27 20:28 ` Esben Nielsen
2006-09-27 8:57 ` Ingo Molnar
2006-09-27 9:14 ` Bill Huey
2006-09-27 9:15 ` Ingo Molnar
2006-09-25 9:53 ` 2.6.18-rt1 Florian Schmidt
2006-09-26 7:57 ` 2.6.18-rt1 Florian Schmidt
2006-09-25 16:12 ` 2.6.18-rt1 Mike Kravetz
2006-09-27 8:34 ` 2.6.18-rt1 Ingo Molnar
2006-09-30 18:06 ` 2.6.18-rt1 Lee Revell
2006-09-30 18:18 ` 2.6.18-rt1 Dipankar Sarma
2006-09-30 18:25 ` 2.6.18-rt1 Lee Revell
2006-10-13 21:18 ` 2.6.18-rt1 Karsten Wiese
2006-10-13 21:20 ` 2.6.18-rt1 Lee Revell
2006-10-13 21:24 ` 2.6.18-rt1 Dipankar Sarma
2006-10-13 22:12 ` 2.6.18-rt1 Lee Revell
2006-10-13 22:16 ` 2.6.18-rt1 Dipankar Sarma
2006-10-17 14:46 ` 2.6.18-rt1 Lee Revell
2006-10-18 8:34 ` 2.6.18-rt1 Ingo Molnar
2006-10-18 7:12 ` 2.6.18-rt1 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451A7842.4090201@third-harmonic.com \
--to=john.cooper@third-harmonic.com \
--cc=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox