From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-scsi@vger.kernel.org, Greg KH <greg@kroah.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Illustration of warning explosion silliness
Date: Thu, 28 Sep 2006 00:42:24 -0400 [thread overview]
Message-ID: <451B52B0.1090801@garzik.org> (raw)
In-Reply-To: <20060927213628.ef12b1ed.akpm@osdl.org>
Andrew Morton wrote:
>> You're ignoring the API issue at hand. Let me say it again for the
>> cheap seats: "search" You search a list, and stick a pointer somewhere
>> when found. No hardware touched. No allocations. Real world. There
>> is an example of usage in the kernel today.
>
> If it's called in that fashion then the caller should still check the
> device_for_each_child() return value to find out if it actually got a
> match.
Or in the case of scsi_sysfs.c, it simply <does something>.
Oh well, whatever. This thing introduces endless build noise we won't
kill for years, making it much harder to spot much more serious stuff.
Jeff
next prev parent reply other threads:[~2006-09-28 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 0:58 [PATCH] Illustration of warning explosion silliness Jeff Garzik
2006-09-28 1:35 ` Andrew Morton
2006-09-28 1:48 ` Jeff Garzik
2006-09-28 3:34 ` Andrew Morton
2006-09-28 4:19 ` Jeff Garzik
2006-09-28 4:36 ` Andrew Morton
2006-09-28 4:42 ` Jeff Garzik [this message]
2006-09-28 4:47 ` Andrew Morton
2006-09-28 4:44 ` Andrew Morton
2006-09-28 4:54 ` Jeff Garzik
2006-09-28 5:04 ` Andrew Morton
2006-09-28 23:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451B52B0.1090801@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox