Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

Mike Frysinger
2006-09-23T11:15:19Z

On 9/23/06, Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 23 September 2006 08:50, Mike Frysinger wrote:
> > On 9/22/06, Arnd Bergmann <arnd@arndb.de> wrote:
> > > > + * File: include/asm-blackfin/mach-bf533/anomaly.h
> > >
> > > You seem to have lots of these machine specfic header files in include/asm.
> > > Please move them to the respective machine implementation directory
> > > if they are only used from there
> >
> > these are sub-arch specific, not machine (aka board)
>
> Now to my point: If all the files that use the platform specific
> headers are in the same source directory, then these headers should
> also be in that platform directory. To compare it with powerpc,
> where we have discussed a long time about the ideal file layout,
> that would mean you get:

then that would not be just anomaly.h, that would be the entire mach
header subdirs:
include/asm-blackfin/mach-bf533/
include/asm-blackfin/mach-bf535/
include/asm-blackfin/mach-bf537/
include/asm-blackfin/mach-bf561/

relocated to the dirs:
arch/blackfin/mach-bf533/
arch/blackfin/mach-bf535/
arch/blackfin/mach-bf537/
arch/blackfin/mach-bf561/

> > > What's the point, are you getting paid by lines of code? Just use
> > > the registers directly!
> >
> > in our last submission we were doing exactly that ... and we were told
> > to switch to a function style method of reading/writing memory mapped
> > registers
>
> It's hard to imagine that what you have here was intended by the comment
> then. Do you have an archive link about that discussion?

no as i was not around for said discussion. but it should be in the
threads covering the submission of blackfin for 2.6.13 ...
-mike