Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

Arnd Bergmann
2006-09-28T12:35:35Z

On Thursday 28 September 2006 13:39, Bernd Schmidt wrote:
>
> > Shouldn't you just use a constant expression here? A global variable
> > for it sounds rather strange, especially since the local_irq_disable()
> > calls are sometimes nested, not to mention the problems you'd hit on
> > SMP?
>
> It's not a constant - there are some {un,}mask_irq functions that may
> change it.  We don't have SMP, obviously it would have to be per-CPU if
> we did.
>
Ok, got it now. I did not realize that you use the same register
for global irq enable and for specific interrupts that can be masked.