Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

Bernd Schmidt
2006-09-28T11:39:47Z

Arnd Bergmann wrote:
>> We want to restore the proper
>> mask of enabled interrupts with the STI. That mask is in the global
>> irq_flags variable (which probably ought to have a different name that
>> doesn't invite clashes).
>
> Shouldn't you just use a constant expression here? A global variable
> for it sounds rather strange, especially since the local_irq_disable()
> calls are sometimes nested, not to mention the problems you'd hit on
> SMP?

It's not a constant - there are some {un,}mask_irq functions that may
change it. We don't have SMP, obviously it would have to be per-CPU if
we did.

Bernd