* [PATCH] Dereference after free in snd_hwdep_release()
@ 2006-09-28 23:45 Florin Malita
2006-09-29 10:54 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Florin Malita @ 2006-09-28 23:45 UTC (permalink / raw)
To: perex; +Cc: linux-kernel, tiwai
snd_card_file_remove() may free hw->card so we can't dereference
hw->card->module after that.
Coverity ID 1420.
Signed-off-by: Florin Malita <fmalita@gmail.com>
---
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 9aa9d94..46b4768 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod
{
int err = -ENXIO;
struct snd_hwdep *hw = file->private_data;
+ struct module *mod = hw->card->module;
mutex_lock(&hw->open_mutex);
if (hw->ops.release) {
err = hw->ops.release(hw, file);
@@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod
hw->used--;
snd_card_file_remove(hw->card, file);
mutex_unlock(&hw->open_mutex);
- module_put(hw->card->module);
+ module_put(mod);
return err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Dereference after free in snd_hwdep_release()
2006-09-28 23:45 [PATCH] Dereference after free in snd_hwdep_release() Florin Malita
@ 2006-09-29 10:54 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2006-09-29 10:54 UTC (permalink / raw)
To: Florin Malita; +Cc: perex, linux-kernel
At Thu, 28 Sep 2006 19:45:50 -0400,
Florin Malita wrote:
>
> snd_card_file_remove() may free hw->card so we can't dereference
> hw->card->module after that.
>
> Coverity ID 1420.
>
> Signed-off-by: Florin Malita <fmalita@gmail.com>
Thanks! Applied to ALSA tree now.
Takashi
> ---
>
> diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
> index 9aa9d94..46b4768 100644
> --- a/sound/core/hwdep.c
> +++ b/sound/core/hwdep.c
> @@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod
> {
> int err = -ENXIO;
> struct snd_hwdep *hw = file->private_data;
> + struct module *mod = hw->card->module;
> mutex_lock(&hw->open_mutex);
> if (hw->ops.release) {
> err = hw->ops.release(hw, file);
> @@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod
> hw->used--;
> snd_card_file_remove(hw->card, file);
> mutex_unlock(&hw->open_mutex);
> - module_put(hw->card->module);
> + module_put(mod);
> return err;
> }
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-29 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 23:45 [PATCH] Dereference after free in snd_hwdep_release() Florin Malita
2006-09-29 10:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox