Re: Arrr! Linux 2.6.18

Dale Farnsworth
2006-09-22T22:57:18Z

On Fri, Sep 22, 2006 at 06:08:25PM -0400, Jeff Garzik wrote:
> Judith Lebzelter wrote:
> >>Dale Farnsworth:
> >> mv643xx_eth: Unmap DMA buffers in receive path
> >
> >In OSDL's automated cross-compile for powerpc64, kernel 2.6.18 had this
> >unexpected error:
> >
> >drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_receive_queue':
> >drivers/net/mv643xx_eth.c:388: error: 'RX_SKB_SIZE' undeclared (first use
> >in this function)
> >
> >Here is a patch that stops the error.
> >
> >Judith Lebzelter
> >OSDL
> >
> >--- drivers/net/mv643xx_eth.c.old 2006-09-22 11:22:47.951049416 -0700
> >+++ drivers/net/mv643xx_eth.c 2006-09-22 11:23:17.787625304 -0700
> >@@ -385,7 +385,7 @@
> > struct pkt_info pkt_info;
> >
> > while (budget-- > 0 && eth_port_receive(mp, &pkt_info) == ETH_OK) {
> >- dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE,
> >+ dma_unmap_single(NULL, pkt_info.buf_ptr, ETH_RX_SKB_SIZE,
> > DMA_FROM_DEVICE);
>
> Man, talk about timing. I just sent this to Andrew & Linus just a few
> seconds ago :)
>
> Jeff

And I sent the same patch to you and netdev 2 days ago. :)

Did you get the accompanying patch that removes this driver
from the powerpc64 build? Or shall I resend it?

-Dale