Re: Arrr! Linux 2.6.18

Linus Torvalds
2006-09-29T14:49:14Z

On Fri, 29 Sep 2006, Mark Lord wrote:
>
> My Latitude-X1 notebook loses video on resume-from-ram
> with -final. Worked fine with all versions from 2.6.16
> through 2.6.18-rc6. So something at the last moment broke it.

Well, try -rc7. -rc6 wasn't actually the last rc.

> I'm travelling with it all this month, with only occasional
> access here. But any suggestions of *specific* patches to
> try reverting would be welcome. git-bisect is a non-starter.

git bisect tends to often be faster than the alternatives, but yeah, since
there's something like 200+ patches in between it's still around 8 reboots

That said, a quick look doesn't show anything really suspicuous.

(Hint for everybody: you can do something like

gitk v2.6.18-rc6..v2.6.18 drivers/

to see all patches that touch just drivers)

I don't see anything really suspicious. The "hvc_console suspend fix"
you already noted should not even be compiled on a regular laptop, afaik.

One of the nice things with git bisect is that if you have git on that
machine at all, even if you just test one or two kernels (rather than the
eight you need to pinpoint it exactly), you'll still help pinpointing a
_lot_ (ie if you test two kernels, we should have the list of commits
narrowed down from 200+ to just 53 or so).

Linus