From: Jeff Garzik <jeff@garzik.org>
To: Linux Kernel <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>
Subject: x86 BUG bug
Date: Sun, 01 Oct 2006 07:42:15 -0400 [thread overview]
Message-ID: <451FA997.9050000@garzik.org> (raw)
I have a couple ATA drivers that spit out "foo might be used
uninitialized" warnings. Rather than the usual gcc nonsense, it turns
out that the code follows this pattern:
type_t foo;
if (condition 1)
foo = x;
else if (condition 2)
foo = y;
else
BUG();
It doesn't warn on other platforms, so I dug into the BUG() code on x86,
and discovered that it is missing the 'noreturn' attribute found in
other BUG() definitions.
Being rusty on the gcc asm syntax -- does an inline asm statement permit
'noreturn'? -- I figured it would be best just to report this, rather
than create a patch myself.
Jeff
next reply other threads:[~2006-10-01 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 11:42 Jeff Garzik [this message]
2006-10-01 11:56 ` x86 BUG bug Andi Kleen
2006-10-01 17:31 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451FA997.9050000@garzik.org \
--to=jeff@garzik.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox