From: Markus Lidel <Markus.Lidel@shadowconnect.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jeff Garzik <jeff@garzik.org>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] I2O: mark i2o_config broken on 64-bit
Date: Sun, 01 Oct 2006 18:45:37 +0200 [thread overview]
Message-ID: <451FF0B1.9040706@shadowconnect.com> (raw)
In-Reply-To: <adalko0xbgt.fsf@cisco.com>
Hello,
Roland Dreier wrote:
> > - //TODO 64bit fix
> > + //FIXME: broken on 64-bit
> > sg[i].addr_bus = (u32) p->phys;
> This looks worse than just broken on 64 bit. I didn't even attempt to
> understand what's going on here, but would this even work on 32 bit
> systems that have physical addresses above 4 gigs (eg i386 with PAE)?
It's a kind of user-space driver :-D This part of the driver just send
the data generated in the user-space program 1:1 to the controller. It
works on 64-bit, but i doubt it works with 64-bit DMA addresses. This
part of the code was copied from "drivers/scsi/dpt_i2o.c". I already
tried to replace it with an IMHO nicer sysfs solution, but because this
also required an "workaround" it was dropped again.
Best regards,
Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)
Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany
Phone: +49 82 82/99 51-0
Fax: +49 82 82/99 51-11
E-Mail: Markus.Lidel@shadowconnect.com
URL: http://www.shadowconnect.com
prev parent reply other threads:[~2006-10-01 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 15:56 [PATCH] I2O: mark i2o_config broken on 64-bit Jeff Garzik
2006-10-01 16:11 ` Roland Dreier
2006-10-01 16:45 ` Markus Lidel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451FF0B1.9040706@shadowconnect.com \
--to=markus.lidel@shadowconnect.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox