* x86 BUG bug
@ 2006-10-01 11:42 Jeff Garzik
2006-10-01 11:56 ` Andi Kleen
2006-10-01 17:31 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Garzik @ 2006-10-01 11:42 UTC (permalink / raw)
To: Linux Kernel, Andi Kleen; +Cc: Andrew Morton
I have a couple ATA drivers that spit out "foo might be used
uninitialized" warnings. Rather than the usual gcc nonsense, it turns
out that the code follows this pattern:
type_t foo;
if (condition 1)
foo = x;
else if (condition 2)
foo = y;
else
BUG();
It doesn't warn on other platforms, so I dug into the BUG() code on x86,
and discovered that it is missing the 'noreturn' attribute found in
other BUG() definitions.
Being rusty on the gcc asm syntax -- does an inline asm statement permit
'noreturn'? -- I figured it would be best just to report this, rather
than create a patch myself.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: x86 BUG bug
2006-10-01 11:42 x86 BUG bug Jeff Garzik
@ 2006-10-01 11:56 ` Andi Kleen
2006-10-01 17:31 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2006-10-01 11:56 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux Kernel, Andrew Morton
>
> Being rusty on the gcc asm syntax -- does an inline asm statement permit
> 'noreturn'? -- I figured it would be best just to report this, rather
> than create a patch myself.
It doesn't AFAIK. It might be possible with an inline function
though with a wrapper macro for __FUNCTION__
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: x86 BUG bug
2006-10-01 11:42 x86 BUG bug Jeff Garzik
2006-10-01 11:56 ` Andi Kleen
@ 2006-10-01 17:31 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2006-10-01 17:31 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux Kernel, Andi Kleen, Andrew Morton
Jeff Garzik wrote:
> Being rusty on the gcc asm syntax -- does an inline asm statement
> permit 'noreturn'? -- I figured it would be best just to report this,
> rather than create a patch myself.
I'm reworking BUG at the moment, and I noticed this as well. I'll try
to fix it.
J
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-01 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-01 11:42 x86 BUG bug Jeff Garzik
2006-10-01 11:56 ` Andi Kleen
2006-10-01 17:31 ` Jeremy Fitzhardinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox