From: James Smart <James.Smart@Emulex.Com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Dereference in drivers/scsi/lpfc/lpfc_ct.c
Date: Mon, 02 Oct 2006 11:37:48 -0400 [thread overview]
Message-ID: <4521324C.8060601@emulex.com> (raw)
In-Reply-To: <1159734706.11887.6.camel@alice>
ACK - good fix.
-- james s
Eric Sesterhenn wrote:
> hi,
>
> if we fail to allocate mp->virt during the first while
> loop iteration, mlist is still uninitialized, therefore
> we should check if before dereferencing.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-git16/drivers/scsi/lpfc/lpfc_ct.c.orig 2006-10-01 22:28:37.000000000 +0200
> +++ linux-2.6.18-git16/drivers/scsi/lpfc/lpfc_ct.c 2006-10-01 22:29:10.000000000 +0200
> @@ -188,7 +188,8 @@ lpfc_alloc_ct_rsp(struct lpfc_hba * phba
>
> if (!mp->virt) {
> kfree(mp);
> - lpfc_free_ct_rsp(phba, mlist);
> + if (mlist)
> + lpfc_free_ct_rsp(phba, mlist);
> return NULL;
> }
>
>
>
>
prev parent reply other threads:[~2006-10-02 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 20:31 [Patch] Dereference in drivers/scsi/lpfc/lpfc_ct.c Eric Sesterhenn
2006-10-02 15:37 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4521324C.8060601@emulex.com \
--to=james.smart@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox