From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757839AbcDAAV1 (ORCPT ); Thu, 31 Mar 2016 20:21:27 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54056 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757614AbcDAAVZ convert rfc822-to-8bit (ORCPT ); Thu, 31 Mar 2016 20:21:25 -0400 From: Heiko Stuebner To: Caesar Wang Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] pinctrl: rockchip: add support the get_direction Date: Fri, 01 Apr 2016 02:21:07 +0200 Message-ID: <4521590.yHkfr458Oq@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1458028545-1202-1-git-send-email-wxt@rock-chips.com> References: <1458028545-1202-1-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 15. März 2016, 15:55:45 schrieb Caesar Wang: > This patch adds the get_direction to support the gpio > interface. > > The gpio direction is not used on rockchip platform when use the gpio > debugfs. > > Tested on kylin board. (RK3036 SoCs) > The repro steps: > $/sys/class/gpio/ > echo 53 > export > $/sys/class/gpio/gpio53# cat direction > in > In general, the gpio53 should be out value, but the direction is the > default value 'in', since the get_direction didn't supported in rockchip > pinctrl. > > So, we should add this patch to support it. > > Reported-by: Jeffy Chen > Signed-off-by: Caesar Wang Reviewed-by: Heiko Stuebner