From: Jeremy Fitzhardinge <jeremy@goop.org>
To: michael@ellerman.id.au
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>,
Hugh Dickens <hugh@veritas.com>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 4/5] Generic BUG for powerpc
Date: Tue, 03 Oct 2006 21:30:52 -0700 [thread overview]
Message-ID: <452338FC.6000802@goop.org> (raw)
In-Reply-To: <1159923244.31312.21.camel@localhost.localdomain>
Michael Ellerman wrote:
> I posted a patch a few weeks back to use __builtin_trap(), which gives
> GCC the hint that it's not going to return.
>
Ah, interesting. I'd been looking for it, and, yep, completely
undocumented. It even generates the right instruction on x86.
Unfortunately, your asm sequence isn't correct, since there's no
guarantee that the asm and the builtin_trap will be adjacent (though its
hard to see what might be interposed in this case, since it would be
dead code). If only gcc labels-as-values worked properly...
> (http://patchwork.ozlabs.org/linuxppc/patch?id=7047)
>
> Unfortunately this generated some negative feedback from some of our
> crackhead ... er wonderful colleagues who want to be able to step over
> BUGs in some circumstances.
> (http://ozlabs.org/pipermail/linuxppc-dev/2006-September/026161.html)
>
> I think they conceeded that it could be configurable, but I wasn't sure
> it was worth the trouble.
>
Hm, not really. Well, it can be an arch-by-arch decision.
J
prev parent reply other threads:[~2006-10-04 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061003201618.974094245@goop.org>
[not found] ` <20061003201812.313852083@goop.org>
2006-10-04 0:54 ` [PATCH 4/5] Generic BUG for powerpc Michael Ellerman
2006-10-04 4:30 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452338FC.6000802@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox