From: Jan Dittmer <jdi@l4x.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, dtor@insightbb.com, akpm@osdl.org
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, fifth try
Date: Wed, 04 Oct 2006 08:10:10 +0200 [thread overview]
Message-ID: <45235042.4090201@l4x.org> (raw)
In-Reply-To: <20061004024927.GA27716@ecstasy.ring2.lan>
Lennart Poettering wrote:
> This is the fifth version of this driver. Changes to the previous
> version are mostly cosmetics: on request of Andrew Morton I replaced
> indentation with spaces by tabs (by passing it through "unexpand").
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -384,6 +384,8 @@ extern int ec_transaction(u8 command,
> wdata_len, rdata, rdata_len);
> }
>
> +EXPORT_SYMBOL(ec_transaction);
> +
> static int acpi_ec_query(struct acpi_ec *ec, u8 *data)
> {
> int result;
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 7fc692a..d25b0db 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -28,5 +28,24 @@ config IBM_ASM
>
> If unsure, say N.
>
> +config MSI_LAPTOP
> + tristate "MSI Laptop Extras"
> + depends on X86
> + depends on ACPI_EC
> + depends on BACKLIGHT_CLASS_DEVICE
> + ---help---
> + This is a driver for laptops built by MSI (MICRO-STAR
> + INTERNATIONAL):
> +
> + MSI MegaBook S270 (MS-1013)
> + Cytron/TCM/Medion/Tchibo MD96100/SAM2000
> +
> + It adds support for Bluetooth, WLAN and LCD brightness control.
> +
> + More information about this driver is available at
> + <http://0pointer.de/lennart/tchibo.html>.
> +
> + If you have an MSI S270 laptop, say Y or M here.
> +
> endmenu
This part is still spaces only. The help text should be indented
by tab + 2 spaces.
Jan
next prev parent reply other threads:[~2006-10-04 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 2:49 [PATCH] misc,acpi,backlight: MSI S270 Laptop support, fifth try Lennart Poettering
2006-10-04 4:22 ` Len Brown
2006-10-04 6:10 ` Jan Dittmer [this message]
2006-10-06 5:23 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45235042.4090201@l4x.org \
--to=jdi@l4x.org \
--cc=akpm@osdl.org \
--cc=dtor@insightbb.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox