* drivers/base/sys.c bug found
@ 2006-10-04 11:38 Jeff Garzik
2006-10-14 5:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2006-10-04 11:38 UTC (permalink / raw)
To: Greg KH, Andrew Morton, Shaohua Li; +Cc: Linux Kernel
sysdev_driver::add is defined to return an error (as it should), but
that error code is never checked.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/base/sys.c bug found
2006-10-04 11:38 drivers/base/sys.c bug found Jeff Garzik
@ 2006-10-14 5:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2006-10-14 5:11 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Shaohua Li, Linux Kernel
On Wed, Oct 04, 2006 at 07:38:07AM -0400, Jeff Garzik wrote:
> sysdev_driver::add is defined to return an error (as it should), but
> that error code is never checked.
Ick, good catch.
I hate those sysdev devices...
Hm, in sysdev_driver_register() we don't want to return any error there,
as it doesn't make sense to.
Shaohua, sysdev devices should not stop the notificiation if a single
add() function returns an error, right? All of the individual drivers
want to be notified of the device.
Bleah...did I mention I don't like these things...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-14 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-04 11:38 drivers/base/sys.c bug found Jeff Garzik
2006-10-14 5:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox