From: Jeff Garzik <jeff@garzik.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/partitions/check: add sysfs error handling
Date: Wed, 04 Oct 2006 09:10:00 -0400 [thread overview]
Message-ID: <4523B2A8.6030509@garzik.org> (raw)
In-Reply-To: <20061004122631.GJ29920@ftp.linux.org.uk>
Al Viro wrote:
> On Wed, Oct 04, 2006 at 08:19:00AM -0400, Jeff Garzik wrote:
>> Handle errors thrown in disk_sysfs_symlinks(), and propagate back
>> to caller.
>>
>> The callers and associated functions don't do a real good job
>> of handling kobject errors anyway (add_partition, register_disk,
>> rescan_partitions), so this should do until something better comes
>> along.
>
> I'm not sure that failure to create these symlinks should be fatal,
> to be honest...
Fair enough, though FWIW the failure is almost always -EFAULT or
-ENOMEM, i.e. -ESYSTEMINTROUBLE...
Jeff
prev parent reply other threads:[~2006-10-04 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 12:19 [PATCH] fs/partitions/check: add sysfs error handling Jeff Garzik
2006-10-04 12:26 ` Al Viro
2006-10-04 13:10 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4523B2A8.6030509@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox