Re: [PATCH 4/12] i386: define __pa_symbol()

Franck Bui-Huu
2006-10-06T13:09:57Z

Vivek Goyal wrote:

> +/* __pa_symbol should be used for C visible symbols.
> + This seems to be the official gcc blessed way to do such arithmetic. */
> +#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)x,0))

#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x),0))
^^^
... should be better. You should not rely on RELOC_HIDE implementation.

Franck