Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage

H. Peter Anvin
2006-10-05T15:44:50Z

Eric W. Biederman wrote:
> In the lazy programmer school of fixes.
>
> I haven't really tested this in any configuration.
> But reading video.S it does use variable in the bootsector.
> It does seem to initialize the variables before use.
> But obviously something is missed.
>
> By zeroing the uninteresting parts of the bootsector just after we
> have determined we are loaded ok. We should ensure we are
> always in a known state the entire time.
>
> Andrew if I am right about the cause of your video not working
> when you set an enhanced video mode this should fix your boot
> problem.
>

I just noticed we're using string instructions in setup.S, without
forcing DF = 0 anywhere. There should be a "cld" near the top.

-hpa