public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* 2.6.18-mm3
@ 2006-10-03  7:11 Andrew Morton
  2006-10-03 14:33 ` 2.6.18-mm3 Michal Piotrowski
                   ` (4 more replies)
  0 siblings, 5 replies; 21+ messages in thread
From: Andrew Morton @ 2006-10-03  7:11 UTC (permalink / raw)
  To: linux-kernel


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/

- Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
  git-gccbug.patch

- Francois Romieu is doing some qlogic driver maintenance - added his
  git-qla3xxx.patch to the -mm lineup.

- Some wireless-related crashes are hopefully fixed.  But if there are still
  wireless problems, be sure that you have the latest userspace tools.

- The recent spate of IRQ-allocation-related crashes on x86_64 is hopefully
  fixed.

- As far as we know, the MSI handling in -mm is now rock-solid.




Boilerplate:

- See the `hot-fixes' directory for any important updates to this patchset.

- To fetch an -mm tree using git, use (for example)

  git fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git v2.6.16-rc2-mm1

- -mm kernel commit activity can be reviewed by subscribing to the
  mm-commits mailing list.

        echo "subscribe mm-commits" | mail majordomo@vger.kernel.org

- If you hit a bug in -mm and it is not obvious which patch caused it, it is
  most valuable if you can perform a bisection search to identify which patch
  introduced the bug.  Instructions for this process are at

        http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt

  But beware that this process takes some time (around ten rebuilds and
  reboots), so consider reporting the bug first and if we cannot immediately
  identify the faulty patch, then perform the bisection search.

- When reporting bugs, please try to Cc: the relevant maintainer and mailing
  list on any email.

- When reporting bugs in this kernel via email, please also rewrite the
  email Subject: in some manner to reflect the nature of the bug.  Some
  developers filter by Subject: when looking for messages to read.

- Semi-daily snapshots of the -mm lineup are uploaded to
  ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ and are announced on
  the mm-commits list.





Changes since 2.6.18-mm2:


 origin.patch
 git-acpi.patch
 git-arm.patch
 git-cifs.patch
 git-dvb.patch
 git-geode.patch
 git-gfs2.patch
 git-ia64.patch
 git-ieee1394.patch
 git-input.patch
 git-kbuild.patch
 git-libata-all.patch
 git-netdev-all.patch
 git-ocfs2.patch
 git-parisc.patch
 git-pcmcia.patch
 git-powerpc.patch
 git-serial.patch
 git-pciseg.patch
 git-s390.patch
 git-scsi-misc.patch
 git-scsi-target.patch
 git-qla3xxx.patch
 git-watchdog.patch
 git-gccbug.patch

 git trees

-__percpu_alloc_mask-has-to-be-__always_inline-in-up-case.patch
-sys_getcpu-prototype-annotated.patch
-remove-generic__raw_read_trylock.patch
-jbd-memory-leak-in-journal_init_dev.patch
-driver-core-fixes-sysfs_create_link-retval-check-in.patch
-driver-core-fixes-bus_add_attrs-retval-check.patch
-driver-core-fixes-bus_add_device-cleanup-on-error.patch
-driver-core-fixes-device_add-cleanup-on-error.patch
-driver-core-fixes-device_create_file-retval-check-in.patch
-driver-core-fixes-sysfs_create_group-retval-in-topologyc.patch
-sysfs-remove-duplicated-dput-in-sysfs_update_file.patch
-sysfs-update-obsolete-comment-in-sysfs_update_file.patch
-allow-rc5-codes-64-127-in-ir-kbd-i2cc.patch
-v4l-support-for-saa7134-based-avertv-hybrid-a16ar.patch
-drivers-media-use-null-instead-of-0-for-ptrs.patch
-gregkh-i2c-hwmon-w83627ehf-add-pwm-support.patch
-gregkh-i2c-hwmon-w83627ehf-documentation.patch
-gregkh-i2c-hwmon-atxp1-signed-unsigned-char-bug.patch
-gregkh-i2c-hwmon-hdaps-handle-errors-from-input-register-device.patch
-gregkh-i2c-hwmon-smsc47m1-fix-dev-message.patch
-gregkh-i2c-hwmon-it87-it8716f-support.patch
-gregkh-i2c-hwmon-it87-disabled-fans.patch
-gregkh-i2c-hwmon-it87-div-to-reg-overflow.patch
-gregkh-i2c-hwmon-it87-in8-no-limits.patch
-gregkh-i2c-hwmon-it87-set-fan-div.patch
-gregkh-i2c-hwmon-it87-it8718f-support.patch
-gregkh-i2c-hwmon-it87-sane-limit-defaults.patch
-gregkh-i2c-hwmon-it87-copyright-update.patch
-gregkh-i2c-hwmon-k8temp-new-driver.patch
-gregkh-i2c-hwmon-k8temp-autoload.patch
-gregkh-i2c-hwmon-abituguru-suspend-resume.patch
-inode_diet-replace-inodeugeneric_ip-with-inodei_private-gfs2.patch
-inode-diet-eliminate-i_blksize-and-use-a-per-superblock-default-gfs2.patch
-possible-dereference-in.patch
-drivers-input-misc-added-acer-travelmate-2424nwxci-support-to-the-wistron-button-interface.patch
-mtd-printk-format-warning.patch
-ppc-fix-typo-in-cpm2h.patch
-tickle-nmi-watchdog-on-serial-output.patch
-config_pm=n-slim-drivers-serial-8250_pcic.patch
-magic-sysrq-sak-does-nothing-on-serial-consoles.patch
-via-irq-quirk-behaviour-change.patch
-pcie-check-and-return-bus_register-errors-fix.patch
-pci-add-ich7-8-acpi-gpio-io-resource-quirks.patch
-pci-quirks-update.patch
-remove-unnecessary-check-in.patch
-pci-turn-pci_fixup_video-into-generic-for-embedded.patch
-overrun-in-drivers-scsi-scsic.patch
-fix-gregkh-usb-usbcore-add-autosuspend-autoresume-infrastructure-2.patch
-gregkh-usb-usbcore-add-autosuspend-autoresume-infrastructure-2.patch
-microtek-usb-scanner-scsi_cmnd-conversion.patch
-usb-serial-possible-irq-lock-inversion-ppp-vs.patch
-usb-allow-both-root-hub-interrupts-and-polling.patch
-ohci-remove-existing-autosuspend-code.patch
-ohci-add-auto-stop-support.patch
-ohci-add-auto-stop-support-hack-hack.patch
-pegasus-driver-failing-for-admtek-8515-network-device.patch
-x86_64-mm-copy-user-inatomic.patch
-x86_64-mm-allow-disabling-dac.patch
-x86_64-mm-iommu-setup-style.patch
-x86_64-mm-document-iommu-panic.patch
-x86_64-mm-unify-ioapic-checking.patch
-x86_64-mm-nmi-sysctl-cleanup.patch
-x86_64-mm-i386-setup-array-size.patch
-x86_64-mm-setup-array-size.patch
-x86_64-mm-i386-mmconfig-flush.patch
-x86_64-mm-re-positioning-the-bss-segment.patch
-x86_64-mm-vsyscall-blob-header.patch
-x86_64-mm-sem-early-clobber.patch
-hot-add-mem-x86_64-fixup-externs.patch
-hot-add-mem-x86_64-kconfig-changes.patch
-hot-add-mem-x86_64-enable-sparsemem-in-sratc.patch
-hot-add-mem-x86_64-memory_add_physaddr_to_nid-enable.patch
-hot-add-mem-x86_64-memory_add_physaddr_to_nid-node-fixup.patch
-hot-add-mem-x86_64-use-config_memory_hotplug_sparse.patch
-hot-add-mem-x86_64-use-config_memory_hotplug_reserve.patch
-arch-i386-pci-mmconfigc-tlb-flush-fix-tweaks.patch
-xfs-add-lock-annotations-to-xfs_trans_update_ail-and-xfs_trans_delete_ail.patch
-convert-s390-page-handling-macros-to-functions.patch
-convert-s390-page-handling-macros-to-functions-fix.patch
-mm-fix-a-race-condition-under-smc-cow.patch
-convert-i386-summit-subarch-to-use-srat-info-for-apicid_to_node-calls.patch
-convert-i386-summit-subarch-to-use-srat-info-for-apicid_to_node-calls-tidy.patch
-uml-assign-random-macs-to-interfaces-if-necessary.patch
-uml-mechanical-tidying-after-random-macs-change.patch
-uml-locking-documentation.patch
-uml-close-file-descriptor-leaks.patch
-uml-stack-consumption-reduction.patch
-uml-remove-pte_mkexec.patch
-kernel-params-must_check-fixes.patch
-blockdevc-check-errors.patch
-blockdevc-check-errors-fix.patch
-block-handle-subsystem_register-init-errors.patch
-fs-namespace-handle-init-registration-errors.patch
-make-prot_write-imply-prot_read.patch
-debug-variants-of-linked-list-macros.patch
-list_del-debug.patch
-make-touch_nmi_watchdog-imply-touch_softlockup_watchdog-on.patch
-make-touch_nmi_watchdog-imply-touch_softlockup_watchdog-on-fix.patch
-remove-unnecessary-barrier-in-rtc_get_rtc_time.patch
-drivers-char-scx200_gpioc-make-code-static.patch
-drivers-char-pc8736x_gpioc-remove-unused-static-functions.patch
-let-warn_on-warn_on_once-return-the-condition.patch
-let-warn_on-warn_on_once-return-the-condition-fix.patch
-let-warn_on-warn_on_once-return-the-condition-fix-2.patch
-scx200_gpio-export-cleanups.patch
-make-net48xx-led-use-scx200_gpio_ops.patch
-libfs-remove-page-up-to-date-check-from-simple_readpage.patch
-kernel-doc-for-relay-interface.patch
-kernel-doc-move-filesystems-together.patch
-kthread-convert-loopc-to-kthread.patch
-include-documentation-for-functions-in-drivers-base-classc.patch
-fix-parameter-names-in-drivers-base-classc.patch
-spinlock_debug-dont-recompute-jiffies_per_loop.patch
-omap-add-smc91x-support-for-ti-omap2420-h4-board.patch
-omap-add-watchdog-driver-support.patch
-omap-add-watchdog-driver-support-tweaks.patch
-omap-add-keypad-driver-4.patch
-omap-update-omap1-2-boards-to-give-keymapsize-and-other.patch
-use-gcc-o1-in-fs-reiserfs-only-for-ancient-gcc-versions.patch
-irq-fixed-coding-style.patch
-irq-removed-a-extra-line.patch
-efi-add-lock-annotations-for-efi_call_phys_prelog-and-efi_call_phys_epilog.patch
-mbcache-add-lock-annotation-for-__mb_cache_entry_release_unlock.patch
-afs-add-lock-annotations-to-afs_proc_cell_servers_startstop.patch
-fuse-add-lock-annotations-to-request_end-and-fuse_read_interrupt.patch
-hugetlbfs-add-lock-annotation-to-hugetlbfs_forget_inode.patch
-lockdep-dont-pull-in-includes-when-lockdep-disabled.patch
-fs-add-lock-annotation-to-grab_super.patch
-rcu-add-lock-annotations-to-rcu_bh_torture_read_lockunlock.patch
-kthread-drivers-base-firmware_classc.patch
-require-mmap-handler-for-aout-executables.patch
-module_subsys-initialize-earlier.patch
-fuse-use-dentry-in-statfs.patch
-vfs-define-new-lookup-flag-for-chdir.patch
-timer-add-lock-annotation-to-lock_timer_base.patch
-dmi-decode-and-save-oem-string-information.patch
-remove-unused-tty_struct-variable.patch
-ignore-partition-table-on-disks-with-aix-label.patch
-task_struct-ifdef-missedem-v-ipc.patch
-ifdef-blktrace-debugging-fields.patch
-mount-udf-udf_part_flag_read_only-partitions-with-ms_rdonly.patch
-fix-intel-rng-detection.patch
-rtmutex-clean-up-and-remove-some-extra-spinlocks.patch
-rtmutex-clean-up-and-remove-some-extra-spinlocks-more.patch
-oom_adj-oom_score-documentation.patch
-fix-kerneldoc-comments-in-kernel-timerc.patch
-fix-kerneldoc-comments-in-kernel-timerc-fix.patch
-there-is-no-devfs-there-has-never-been-a-devfs-we-have.patch
-move-valid_dma_direction-from-x86_64-to-generic-code.patch
-move-valid_dma_direction-from-x86_64-to-generic-code-fix.patch
-use-valid_dma_direction-in-include-asm-i386-dma-mappingh.patch
-lsm-remove-bsd-secure-level-security-module.patch
-tty_ioc-keep-davej-sane.patch
-single-bit-flip-detector.patch
-single-bit-flip-detector-tidy.patch
-ucb1x00-ts-handle-errors-from-input_register_device.patch
-console-utf-8-mode-fixes.patch
-reiserfs_fsync-should-only-use-barriers-when-they-are-enabled.patch
-fix-reiserfs-latencies-caused-by-data=ordered.patch
-ifdef-quota_read-quota_write.patch
-unwind-fix-unused-variable-warning-when.patch
-reiserfs-ifdef-xattr_sem.patch
-reiserfs-ifdef-acl-stuff-from-inode.patch
-fsh-ifdef-security-fields.patch
-oprofile-ppro-need-to-enable-disable-all-the-counters.patch
-add-o-flush-for-fat.patch
-tty-locking-on-resize.patch
-kthread-convert-arch-i386-kernel-apmc.patch
-fix-unserialized-task-files-changing.patch
-fix-unserialized-task-files-changing-fix.patch
-fix-conflict-with-the-is_init-identifier-on-parisc.patch
-pidspace-is_init.patch
-chardev-checking-of-overlapping-ranges.patch
-ahci-ati-sb600-sata-support-for-various-modes.patch
-atiixp-ati-sb600-ide-support-for-various-modes.patch
-lockdep-print-kernel-version.patch
-memory-ordering-in-__kfifo-primitives.patch
-small-update-to-credits.patch
-fix-wrong-error-code-on-interrupted-close-syscalls.patch
-fix-wrong-error-code-on-interrupted-close-syscalls-fix.patch
-remove-another-configh.patch
-make-ledsh-include-relevant-headers.patch
-config_pm=n-slim-drivers-parport-parport_serialc.patch
-config_pm=n-slim-sound-oss-tridentc.patch
-config_pm=n-slim-sound-oss-cs46xxc.patch
-remove-old-drivers-char-s3c2410_rtcc.patch
-sound-mips-au1x00-use-array_size-macro.patch
-sound-sparc-dbri-use-array_size-macro.patch
-check-return-value-of-cpu_callback.patch
-fix-serial-amba-pl011c-console-kconfig.patch
-elf_core_dump-dont-take-tasklist_lock.patch
-elf_fdpic_core_dump-dont-take-tasklist_lock.patch
-fix-memory-leak-in-vc_resize-vc_allocate.patch
-dquot-add-proper-locking-when-using-current-signal-tty.patch
-update-documentation-kernel-parameterstxt.patch
-posix-timers-fix-clock_nanosleep-doesnt-return-the-remaining-time-in-compatibility-mode-2.patch
-posix-timers-fix-the-flags-handling-in-posix_cpu_nsleep-2.patch
-i-o-error-attempting-to-read-last-partial-block-of-a-file-in-an-iso9660-file-system.patch
-has_stopped_jobs-cleanup.patch
-__dequeue_signal-cleanup.patch
-simplify-update_times-avoid-jiffies-jiffies_64-aliasing-problem-2.patch
-kexec-warning-fix.patch
-tty-trivial-kzalloc-opportunity.patch
-tty-lock-ticogwinsz.patch
-tty-stop-the-tty-vanishing-under-procfs-access.patch
-exit-fix-crash-case.patch
-tty-make-termios_sem-a-mutex.patch
-tty-make-termios_sem-a-mutex-fix.patch
-cdev-documentation-was-drop-second-arg-of-unregister_chrdev.patch
-use-decimal-for-ptrace_attach-and-ptrace_detach.patch
-return-better-error-codes-if-drivers-char-rawc-module-init-fails.patch
-fix-____call_usermodehelper-errors-being-silently-ignored.patch
-kill-extraneous-printk-in-kernel_restart.patch
-do_sched_setscheduler-dont-take-tasklist_lock.patch
-introduce-is_rt_policy-helper.patch
-sched_setscheduler-fix-policy-checks.patch
-reparent_to_init-use-has_rt_policy.patch
-copy_process-cosmetic-ioprio-tweak.patch
-autofs4-autofs4_follow_link-false-negative-fix.patch
-autofs4-pending-flag-not-cleared-on-mount-fail.patch
-futex_find_get_task-dont-take-tasklist_lock.patch
-sys_get_robust_list-dont-take-tasklist_lock.patch
-docbook-fix-segfault-in-docprocc.patch
-solaris-emulation-incorrect-tty-locking.patch
-solaris-emulation-incorrect-tty-locking-fix.patch
-solaris-emulation-incorrect-tty-locking-fix-2.patch
-tty-fix-bits-and-note-more-bits-to-fix.patch
-windfarm_smu_satc-simplify-around-i2c_add_driver.patch
-make-spinlock-rwlock-annotations-more-accurate-by-using.patch
-replace-_spin_trylock-with-spin_trylock-in-the-irq.patch
-generic-boolean.patch
-fs-ntfs-conversion-to-generic-boolean.patch
-fs-jfs-conversion-to-generic-boolean.patch
-block_devc-mutex_lock_nested-fix.patch
-fix-mem_write-return-value.patch
-doc-fix-kernel-parameters-quiet.patch
-pass-a-lock-expression-to-__cond_lock-like-__acquire-and.patch
-cramfs-rewrite-init_cramfs_fs.patch
-freevxfs-fix-leak-on-error-path.patch
-cramfs-make-cramfs_uncompress_exit-return-void.patch
-9p-fix-leak-on-error-path.patch
-ban-register_filesystemnull.patch
-lockdep-core-add-enable-disable_irq_irqsave-irqrestore-apis.patch
-set-exit_dead-state-in-do_exit-not-in-schedule.patch
-kill-pf_dead-flag.patch
-introduce-task_dead-state.patch
-select_bad_process-kill-a-bogus-pf_dead-task_dead-check.patch
-select_bad_process-cleanup-releasing-check.patch
-oom_kill_task-cleanup-mm-checks.patch
-oom-dont-kill-current-when-another-oom-in-progress.patch
-fix-typo-in-rtc-kconfig.patch
-cpuset-top_cpuset-tracks-hotplug-changes-to-node_online_map.patch
-cpuset-top_cpuset-tracks-hotplug-changes-to-node_online_map-fix.patch
-cpuset-top_cpuset-tracks-hotplug-changes-to-node_online_map-fix-2.patch
-cpuset-hotunplug-cpus-and-mems-in-all-cpusets.patch
-remove-sound-oss-copying.patch
-fs-partitions-conversion-to-generic-boolean.patch
-loop-forward-port-resource-leak-checks-from-solar.patch
-maximum-latency-tracking-infrastructure.patch
-maximum-latency-tracking-infrastructure-tidy.patch
-maximum-latency-tracking-alsa-support.patch
-add-to-maintainers-file.patch
-lib-rwsemc-un-inline-rwsem_down_failed_common.patch
-add-section-on-function-return-values-to-codingstyle.patch
-fs-nameic-replace-multiple-current-fs-by-shortcut-variable.patch
-fs-nameic-replace-multiple-current-fs-by-shortcut-variable-tidy.patch
-superh-maintainership-change.patch
-mem-driver-fix-conditional-on-isa-i-o-support.patch
-remove-static-variable-mm-page-writebackctotal_pages.patch
-call-mm-page-writebackcset_ratelimit-when-new-pages.patch
-call-mm-page-writebackcset_ratelimit-when-new-pages-tidy.patch
-valid_swaphandles-fix.patch
-mention-documenation-abi-requirements-in-documentation-submitchecklist.patch
-rate-limiting-for-the-ldisc-open-failure-messages.patch
-lib-ts_fsmc-constify-structs.patch
-submittingpatches-cleanups.patch
-network-block-device-is-mostly-known-as-nbd.patch
-superh-list-is-moderated.patch
-sys-modules-patch-allow-full-length-section-names.patch
-uninitialized-variable-in-drivers-net-wan-syncpppc.patch
-enforce-rlimit_nofile-in-poll.patch
-generic-infrastructure-for-acls.patch
-generic-infrastructure-for-acls-update.patch
-access-control-lists-for-tmpfs.patch
-access-control-lists-for-tmpfs-cleanup.patch
-stop_machinec-copyright.patch
-build-sound-sound_firmwarec-only-for-oss.patch
-build-sound-sound_firmwarec-only-for-oss-doc.patch
-rtc-more-xstp-vdet-support-for-rtc-rs5c348-driver.patch
-generic_serial-remove-private-decoding-of-baud-rate-bits.patch
-istallion-remove-private-baud-rate-decoding-which-is.patch
-specialix-remove-private-speed-decoding.patch
-fix-locking-for-tty-drivers-when-doing-urgent-characters.patch
-audit-accounting-tty-locking.patch
-documentation-submittingdrivers-minor-update.patch
-clean-up-expand_fdtable-and-expand_files-take-2.patch
-expand_fdtable-remove-pointless-unlocklock.patch
-kcore-elf-note-namesz-field-fix.patch
-lockdep-core-improve-the-lock-chain-hash.patch
-linux-kernel-dump-test-module.patch
-linux-kernel-dump-test-module-fixes.patch
-submittingpatches-add-a-note-about-format=flowed-when-sending-patches.patch
-kmemdup-introduce.patch
-kmemdup-some-users.patch
-cpuset-fix-obscure-attach_task-vs-exiting-race.patch
-create-fs-utimesc.patch
-cciss-support-for-2tb-logical-volumes.patch
-serial-fix-up-offenders-peering-at-baud-bits-directly.patch
-codingstyle-cleanup-for-kernel-sysc.patch
-allow-proc-configgz-to-be-built-as-a-module.patch
-pci-via82cxxx_audio-use-pci_get_device.patch
-pci-cs46xx-oss-switch-to-pci_get_device.patch
-pci-piix-use-refcounted-interface-when-searching-for-a-450nx.patch
-pci-serverworks-switch-to-pci-refcounted-interfaces.patch
-pci-sis5513-switch-to-pci-refcounting.patch
-pci-via-switch-to-pci_get_device-refcounted-pci-api.patch
-mbcs-use-seek_set-cur.patch
-eicon-isdn-removed-unused-definitions-for-os_seek_.patch
-vfs-use-seek_set-cur.patch
-proper-flags-type-of-spin_lock_irqsave.patch
-submit-checklist-mention-headers_check.patch
-doc-lockdep-design-explain-display-of-state-bits.patch
-leds-turn-led-off-when-changing-triggers.patch
-directed-yield-cpu_relax-variants-for-spinlocks-and-rw-locks.patch
-directed-yield-direct-yield-of-spinlocks-for-powerpc.patch
-directed-yield-direct-yield-of-spinlocks-for-s390.patch
-synclink_gt-add-bisync-and-monosync-modes.patch
-synclink_gt-increase-max-devices.patch
-cciss-remove-unneeded-spaces-in-output-for-attached-volumes-resend.patch
-remove-superfluous-call-to-call-to-cdev_del.patch
-howto-mention-bughunting.patch
-isicom-correct-firmware-loading.patch
-remove-sysrq_key-and-related-defines-from-ppc-sh-h8300.patch
-mmc-mainly-add-or-later-clause-to-licence-statement.patch
-prevent-multiple-inclusion-of-linux-sysrqh.patch
-move-ncpfs-32bit-compat-ioctl-to-ncpfs.patch
-ipmi-per-channel-command-registration.patch
-update-legacy-io-handling-for-pmac.patch
-ip2-use-newer-pci_get-functions.patch
-i2o-switch-to-pci_get-api.patch
-cardbus-switch-to-ref-counting-hotplug-safe-api.patch
-sysrq-disable-lockdep-on-reboot.patch
-trident-fix-pci_dev-reference-counting-and-buglet.patch
-off-by-one-in-drivers-char-mwave-mwaveddc.patch
-hdaps-support-lenovo-thinkpad-t60.patch
-typo-fixes-for-rt-mutex-designtxt.patch
-remove-bug_onunlikely-in-include-linux-aioh.patch
-pass-sparse-the-lock-expression-given-to-lock-annotations.patch
-ntp-move-all-the-ntp-related-code-to-ntpc.patch
-ntp-move-all-the-ntp-related-code-to-ntpc-fix.patch
-ntp-add-ntp_update_frequency.patch
-ntp-add-ntp_update_frequency-fix.patch
-ntp-add-time_adj-to-tick-length.patch
-ntp-add-time_freq-to-tick-length.patch
-ntp-prescale-time_offset.patch
-ntp-add-time_adjust-to-tick-length.patch
-ntp-remove-time_tolerance.patch
-ntp-convert-time_freq-to-nsec-value.patch
-ntp-convert-to-the-ntp4-reference-model.patch
-ntp-cleanup-defines-and-comments.patch
-kernel-time-ntpc-possible-cleanups.patch
-kill-wall_jiffies.patch
-reiserfs-fix-is_reusable-bitmap-check-to-not-traverse-the-bitmap-info-array.patch
-reiserfs-clean-up-bitmap-block-buffer-head-references.patch
-reiserfs-reorganize-bitmap-loading-functions.patch
-reiserfs-on-demand-bitmap-loading.patch
-reiserfs-use-generic_file_open-for-open-checks.patch
-reiserfs-eliminate-minimum-window-size-for-bitmap-searching.patch
-vectorize-aio_read-aio_write-fileop-methods.patch
-vectorize-aio_read-aio_write-fileop-methods-xfs-fix.patch
-vectorize-aio_read-aio_write-fileop-methods-hypfs-fix.patch
-remove-readv-writev-methods-and-use-aio_read-aio_write.patch
-streamline-generic_file_-interfaces-and-filemap.patch
-streamline-generic_file_-interfaces-and-filemap-gfs-fix.patch
-add-vector-aio-support.patch
-add-vector-aio-support-fix.patch
-clean-up-unused-kiocb-variables.patch
-add-genetlink-utilities-for-payload-length-calculation.patch
-fix-taskstats-size-calculation-use-the-new-genetlink-utility-functions.patch
-fix-getdelaysc-cpumask-length-and-error-reporting.patch
-csa-basic-accounting-over-taskstats.patch
-csa-basic-accounting-over-taskstats-fix.patch
-csa-extended-system-accounting-over-taskstats.patch
-csa-convert-config-tag-for-extended-accounting-routines.patch
-csa-accounting-taskstats-update.patch
-csa-accounting-taskstats-update-update-comments-in-linux-taskstatsh.patch
-r-o-bind-mount-prepare-for-write-access-checks-collapse-if.patch
-r-o-bind-mount-prepwork-move-open_nameis-vfs_create.patch
-r-o-bind-mount-unlink-monitor-i_nlink.patch
-r-o-bind-mount-prepwork-inc_nlink-helper.patch
-r-o-bind-mount-clean-up-ocfs2-nlink-handling-2.patch
-r-o-bind-mount-monitor-zeroing-of-i_nlink.patch
-stack-overflow-safe-kdump-safe_smp_processor_id.patch
-stack-overflow-safe-kdump-safe_smp_processor_id_voyager.patch
-stack-overflow-safe-kdump-crash_use_safe_smp_processor_id.patch
-stack-overflow-safe-kdump-crash_use_safe_smp_processor_id-fix.patch
-stack-overflow-safe-kdump-safe_smp_send_nmi_allbutself.patch
-generic-ioremap_page_range-implementation.patch
-generic-ioremap_page_range-implementation-fix.patch
-generic-ioremap_page_range-implementation-nommu-fix.patch
-generic-ioremap_page_range-flush_cache_vmap.patch
-generic-ioremap_page_range-alpha-conversion.patch
-generic-ioremap_page_range-avr32-conversion.patch
-generic-ioremap_page_range-cris-conversion.patch
-generic-ioremap_page_range-i386-conversion.patch
-generic-ioremap_page_range-i386-conversion-fix.patch
-generic-ioremap_page_range-m32r-conversion.patch
-generic-ioremap_page_range-mips-conversion-fix.patch
-generic-ioremap_page_range-x86_64-conversion.patch
-generic-ioremap_page_range-x86_64-conversion-fix.patch
-paravirt-remove-read-hazard-from-cow.patch
-paravirt-pte-clear-not-present.patch
-paravirt-lazy-mmu-mode-hooks.patch
-paravirt-combine-flush-accessed-dirty.patch
-paravirt-kpte-flush.patch
-paravirt-optimize-ptep-establish-for-pae.patch
-paravirt-remove-set-pte-atomic.patch
-paravirt-pae-compile-fix.patch
-paravirt-update-pte-hook.patch
-some-cleanup-in-the-pipe-code.patch
-some-cleanup-in-the-pipe-code-tidy.patch
-create-call_usermodehelper_pipe.patch
-support-piping-into-commands-in-proc-sys-kernel-core_pattern.patch
-support-piping-into-commands-in-proc-sys-kernel-core_pattern-fix.patch
-support-piping-into-commands-in-proc-sys-kernel-core_pattern-fix-2.patch
-proc-readdir-race-fix-take-3.patch
-proc-readdir-race-fix-take-3-race-fix.patch
-proc-reorder-the-functions-in-basec.patch
-proc-modify-proc_pident_lookup-to-be-completely-table-driven.patch
-proc-give-the-root-directory-a-task.patch
-pid-implement-access-helpers-for-a-tacks-various-process-groups.patch
-pid-add-do_each_pid_task.patch
-pid-implement-signal-functions-that-take-a-struct-pid.patch
-pid-export-the-symbols-needed-to-use-struct-pid.patch
-pid-implement-pid_nr.patch
-vt-rework-the-console-spawning-variables.patch
-vt-make-vt_pid-a-struct-pid-making-it-pid-wrap-around-safe.patch
-file-modify-struct-fown_struct-to-use-a-struct-pid.patch
-file-modify-struct-fown_struct-to-use-a-struct-pid-fix.patch
-remove-null-check-in-register_nls.patch
-fs-inodec-tweaks.patch
-const-struct-tty_operations.patch
-pids-coding-style-use-struct-pidmap.patch
-proc-readdir-race-fix-take-3-fix-1.patch
-simplify-pid-iterators.patch
-move-pidmap-to-pspaceh.patch
-move-pidmap-to-pspaceh-fix.patch
-define-struct-pspace.patch
-proc-readdir-race-fix-take-3-fix-2.patch
-update-mq_notify-to-use-a-struct-pid.patch
-file-add-locking-to-f_getown.patch
-usb-fixup-usb-so-it-uses-struct-pid.patch
-s390-update-fs3270-to-use-a-struct-pid.patch
-kprobes-make-kprobe-modules-more-portable.patch
-kprobes-make-kprobe-modules-more-portable-update.patch
-kprobes-handle-symbol-resolution-when-modulesymbol-is-specified.patch
-kprobes-handle-symbol-resolution-when-modulesymbol-is-specified-tidy.patch
-add-regs_return_value-helper.patch
-update-documentation-kprobestxt.patch
-update-documentation-kprobestxt-update.patch
-kprobe-whitespace-cleanup.patch
-disallow-kprobes-on-notifier_call_chain.patch
-kretprobe-spinlock-deadlock-patch.patch
-isdn4linux-gigaset-driver-fix-__must_check-warning.patch
-isdn-work-around-excessive-udelay.patch
-cpumask-add-highest_possible_node_id.patch
-cpumask-add-highest_possible_node_id-fix.patch
-cpumask-export-cpu_online_map-and-cpu_possible_map.patch
-cpumask-export-node_to_cpu_mask-consistently.patch
-knfsd-knfsd-add-some-missing-newlines-in-printks.patch
-knfsd-knfsd-remove-an-unused-variable-from-e_show.patch
-knfsd-knfsd-remove-an-unused-variable-from-auth_unix_lookup.patch
-knfsd-add-a-callback-for-when-last-rpc-thread-finishes.patch
-knfsd-add-a-callback-for-when-last-rpc-thread-finishes-tidy.patch
-knfsd-add-a-callback-for-when-last-rpc-thread-finishes-fix.patch
-knfsd-be-more-selective-in-which-sockets-lockd-listens-on.patch
-knfsd-remove-nfsd_versbits-as-intermediate-storage-for-desired-versions.patch
-knfsd-separate-out-some-parts-of-nfsd_svc-which-start-nfs-servers.patch
-knfsd-separate-out-some-parts-of-nfsd_svc-which-start-nfs-servers-tweaks.patch
-knfsd-define-new-nfsdfs-file-portlist-contains-list-of-ports.patch
-knfsd-define-new-nfsdfs-file-portlist-contains-list-of-ports-tidy.patch
-knfsd-define-new-nfsdfs-file-portlist-contains-list-of-ports-fix.patch
-knfsd-allow-sockets-to-be-passed-to-nfsd-via-portlist.patch
-knfsd-use-seq_start_token-instead-of-hardcoded-magic-void1.patch
-nfsd-add-lock-annotations-to-e_start-and-e_stop.patch
-knfsd-drop-serv-option-to-svc_recv-and-svc_process.patch
-knfsd-drop-serv-option-to-svc_recv-and-svc_process-nfs-callback-fix-nfs-callback-fix.patch
-knfsd-check-return-value-of-lockd_up-in-write_ports.patch
-knfsd-move-makesock-failed-warning-into-make_socks.patch
-knfsd-correctly-handle-error-condition-from-lockd_up.patch
-knfsd-move-tempsock-aging-to-a-timer.patch
-knfsd-move-tempsock-aging-to-a-timer-tidy.patch
-knfsd-convert-sk_inuse-to-atomic_t.patch
-knfsd-use-new-lock-for-svc_sock-deferred-list.patch
-knfsd-convert-sk_reserved-to-atomic_t.patch
-knfsd-test-and-set-sk_busy-atomically.patch
-knfsd-split-svc_serv-into-pools.patch
-knfsd-split-svc_serv-into-pools-fix.patch
-knfsd-add-svc_get.patch
-knfsd-add-svc_set_num_threads.patch
-knfsd-use-svc_set_num_threads-to-manage-threads-in-knfsd.patch
-knfsd-make-rpc-threads-pools-numa-aware.patch
-knfsd-make-rpc-threads-pools-numa-aware-fix.patch
-knfsd-allow-admin-to-set-nthreads-per-node.patch
-nfsd-lockdep-annotation.patch
-proc-sysctl-add-_proc_do_string-helper.patch
-make-kernel-sysctlc_proc_do_string-static.patch
-namespaces-add-nsproxy.patch
-namespaces-add-nsproxy-move-init_nsproxy-into-kernel-nsproxyc.patch
-namespaces-incorporate-fs-namespace-into-nsproxy.patch
-namespaces-incorporate-fs-namespace-into-nsproxy-whitespace.patch
-namespaces-exit_task_namespaces-invalidates-nsproxy.patch
-namespaces-utsname-introduce-temporary-helpers.patch
-namespaces-utsname-switch-to-using-uts-namespaces.patch
-namespaces-utsname-switch-to-using-uts-namespaces-klibc-bit.patch
-namespaces-utsname-use-init_utsname-when-appropriate-klibc-bit.patch
-namespaces-utsname-switch-to-using-uts-namespaces-klibc-bit-2.patch
-namespaces-utsname-switch-to-using-uts-namespaces-klibc-bit-sparc.patch
-namespaces-utsname-use-init_utsname-when-appropriate.patch
-namespaces-utsname-implement-utsname-namespaces.patch
-namespaces-utsname-sysctl-hack.patch
-namespaces-utsname-remove-system_utsname.patch
-namespaces-utsname-implement-clone_newuts-flag.patch
-namespaces-utsname-implement-clone_newuts-flag-fix.patch
-uts-copy-nsproxy-only-when-needed.patch
-ipc-namespace-core.patch
-ipc-namespace-utils.patch
-ipc-namespace-msg.patch
-ipc-namespace-sem.patch
-ipc-namespace-shm.patch
-ipc-namespace-sysctls.patch
-ipc-namespace-fix.patch
-ipc-replace-kmalloc-and-memset-in-get_undo_list-with-kzalloc.patch
-introduce-kernel_execve.patch
-rename-the-provided-execve-functions-to-kernel_execve.patch
-rename-the-provided-execve-functions-to-kernel_execve-fixes.patch
-rename-the-provided-execve-functions-to-kernel_execve-headers-fix.patch
-provide-kernel_execve-on-all-architectures.patch
-provide-kernel_execve-on-all-architectures-fix.patch
-provide-kernel_execve-on-all-architectures-mips-fix.patch
-provide-kernel_execve-on-all-architectures-fix-2.patch
-provide-kernel_execve-on-all-architectures-fix-3.patch
-provide-kernel_execve-on-all-architectures-fix-4.patch
-provide-kernel_execve-on-all-architectures-m68knommu-fix.patch
-remove-the-use-of-_syscallx-macros-in-uml.patch
-sh64-remove-the-use-of-kernel-syscalls.patch
-remove-remaining-errno-and-__kernel_syscalls__-references.patch
-avr32-implement-kernel_execve.patch
-proc-make-the-generation-of-the-self-symlink-table-driven.patch
-proc-factor-out-an-instantiate-method-from-every-lookup-method.patch
-proc-remove-the-hard-coded-inode-numbers.patch
-proc-merge-proc_tid_attr-and-proc_tgid_attr.patch
-proc-use-pid_task-instead-of-open-coding-it.patch
-proc-convert-task_sig-to-use-lock_task_sighand.patch
-proc-convert-do_task_stat-to-use-lock_task_sighand.patch
-proc-drop-tasklist-lock-in-task_state.patch
-proc-properly-compute-tgid_offset.patch
-proc-remove-trailing-blank-entry-from-pid_entry-arrays.patch
-proc-remove-the-useless-smp-safe-comments-from-proc.patch
-proc-comment-what-proc_fill_cache-does.patch
-introduce-get_task_pid-to-fix-unsafe-get_pid.patch
-replace-cad_pid-by-a-struct-pid.patch
-replace-cad_pid-by-a-struct-pid-fixes.patch

 Merged into mainline or a subsystem tree.

+pidh-cleanup.patch
+vfs-make-filldir_t-and-struct-kstat-deal-in-64-bit-inode-numbers.patch
+revert-insert-ioapics-and-local-apic-into-resource-map.patch

 2.6.19-rc1 queue.

+fix-up-a-multitude-of-acpi-compiler-warnings-on-x86_64.patch
+acpi-cast-removal.patch

 ACPI fixes

+acpi-add-backlight-support-to-the-sony_acpi.patch

 Make sony_apci.patch use the backlight layer.

+dereference-after-free-in-snd_hwdep_release.patch

 Sound driver fix.

-git-block-fixup.patch

 Unneeded.

-git-block-hack.patch

 Merged (accidentally)

+gregkh-driver-driver-core-plug-device-probe-memory-leak.patch
+gregkh-driver-fix-dev_printk-is-now-gpl-only.patch
+gregkh-driver-howto-bug-report-addition.patch
+gregkh-driver-sysfs-remove-duplicated-dput-in-sysfs_update_file.patch
+gregkh-driver-sysfs-update-obsolete-comment-in-sysfs_update_file.patch
+gregkh-driver-driver-core-fixes-sysfs_create_link-retval-check-in-class.c.patch
+gregkh-driver-driver-core-fixes-bus_add_attrs-retval-check.patch
+gregkh-driver-driver-core-fixes-bus_add_device-cleanup-on-error.patch
+gregkh-driver-driver-core-fixes-device_add-cleanup-on-error.patch
+gregkh-driver-driver-core-fixes-device_create_file-retval-check-in-dmapool.c.patch
+gregkh-driver-driver-core-fixes-sysfs_create_group-retval-in-topology.c.patch
+gregkh-driver-driver-core-don-t-leak-old_class_name-in-drivers-base-core.c-device_rename.patch

 driver tree updates

+hdaps-remove-duplicate-whitelist-entry-and-add-thinkpad.patch

 hdaps device support.

+revert-input-make-input_openclose_device-more-robust.patch

 Revert buggy patch from git-input.patch.

-git-intelfb-fixup.patch

 Unneeded.

+remove-unnecessary-check-in-drivers-video-intelfb-intelfbhwc.patch

 intelfb cleanup

+docs-small-kbuild-cleanup.patch

 kbuild documentation fix.

+ata_piix-clean-up-port-flags.patch
+libata-unexport-ata_dev_revalidate.patch
+libata-convert-post_reset-to-flags-in-ata_dev_read_id.patch
+libata-implement-presence-detection-via-polling-identify.patch
+ata_piix-apply-device-detection-via-polling-identify.patch
+ata_piix-strip-now-unneded-map-related-stuff.patch
+libata-return-sense-data-in-hdio_drive_cmd-ioctl.patch
+libata-return-sense-data-in-hdio_drive_cmd-ioctl-tidy.patch

 sata updates

-git-mtd-fixup.patch

 Unneeded.

+powerpc-cell-spidernet-burst-alignment-patch.patch
+powerpc-cell-spidernet-low-watermark-patch.patch
+powerpc-cell-spidernet-stop-error-printing-patch.patch
+powerpc-cell-spidernet-ethtool-i-version-number-info.patch
+powerpc-cell-spidernet-ethtool-i-version-number.patch
+powerpc-cell-spidernet-refine-locking.patch
+8139too-force-media-setting-fix.patch
+sundance-remove-txstartthresh-and-rxearlythresh.patch
+sundance-fix-tx-pause-bug-reset_tx-intr_handler.patch
+sundance-change-phy-address-search-from-phy=1-to-phy=0.patch
+sundance-correct-initial-and-close-hardware-step.patch
+sundance-solve-host-error-problem-in-low-performance-embedded.patch
+hp100-fix-conditional-compilation-mess.patch

 netdev updates.  (The sprdernet patches are old and I meant to drop them)

+bonding-lockdep-annotation.patch
+ipv6-dccp-fix-memory-leak-in-dccp_v6_do_rcv.patch
+zatm-always-clear-pcr-in-alloc_shaper.patch
+atm-ambassador-fix-return-code-bug.patch
+tipc-fix-printk-warning.patch

 net updates.

+nfs-add-return-code-checks-for-page-invalidation.patch

 NFS debugging check.

-revert-genirq-core-fix-handle_level_irq.patch
-git-parisc-fixup.patch

 Unneeded

+git-powerpc-wrapper-dont-require-execute-permissions.patch

 Fix git-powerpc.patch scripting.

+powerpc-xmon-fix.patch

 xmon fix.

+r8169-driver-corega-support-patch.patch

 net driver device support.

+serial-trivial-code-flow-simplification.patch

 serial driver cleanup.

+gregkh-pci-shpchp-fix-shpchp_wait_cmd-in-poll.patch
+gregkh-pci-pciehp-fix-improper-info-messages.patch
+gregkh-pci-pciehp-add-missing-locking.patch
+gregkh-pci-pciehp-remove-unnecessary-check-in-pciehp_ctrl.c.patch
+gregkh-pci-pci-via-irq-quirk-behaviour-change.patch
+gregkh-pci-pci-pcie-check-and-return-bus_register-errors-fix.patch
+gregkh-pci-pci-add-ich7-8-acpi-gpio-io-resource-quirks.patch
+gregkh-pci-pci-turn-pci_fixup_video-into-generic-for-embedded-vga.patch
+gregkh-pci-altix-add-initial-acpi-io-support.patch
+gregkh-pci-altix-sn-acpi-hotplug-support.patch
+gregkh-pci-altix-rom-shadowing.patch

 PCI tree updates.

+revert-gregkh-pci-altix-rom-shadowing.patch
+revert-gregkh-pci-altix-sn-acpi-hotplug-support.patch
+revert-gregkh-pci-altix-add-initial-acpi-io-support.patch

 Revert some build-breakers from the PCI tree.

+pci-optionally-sort-device-lists-breadth-first.patch
+pci-optionally-sort-device-lists-breadth-first-tweaks.patch
+pci-optionally-sort-device-lists-breadth-first-force-on.patch

 Fiddle with PCI device discovery ordering.

+revert-pci-assign-ioapic-resource-at-hotplug.patch

 Revert bad PCI patch which went into mainline.

-git-block-vs-git-sas.patch

 Unneeded.

-aic7xxx-deinline-large-functions-save-80k-of-text.patch
-aic7xxx-s-__inline-inline.patch
-aic7xxx-fix-byte-i-o-order-in-ahd_inw.patch
-drivers-scsi-aic7xxx-possible-cleanups-2.patch

 Dropped due to randomness in scsi land.

+ioremap-balanced-with-iounmap-drivers-scsi-zalonc.patch
+ioremap-balanced-with-iounmap-drivers-scsi-sun3_scsic.patch
+ioremap-balanced-with-iounmap-drivers-scsi-sun3_scsi_vmec.patch
+ioremap-balanced-with-iounmap-drivers-scsi-seagatec.patch
+ioremap-balanced-with-iounmap-drivers-scsi-qlogicptic.patch
+ioremap-balanced-with-iounmap-drivers-scsi-nsp32c.patch
+ioremap-balanced-with-iounmap-drivers-scsi-ncr53c8xxc.patch
+ioremap-balanced-with-iounmap-drivers-scsi-fdomainc.patch
+ioremap-balanced-with-iounmap-drivers-scsi-amiga7xxc.patch
+ioremap-balanced-with-iounmap-drivers-scsi-3w-9xxxc.patch
+scsi-convert-ninja-driver-to-struct-scsi_cmnd.patch
+scsi-convertion-to-struct-scsi_cmnd-in-ips-driver.patch
+fc4-conversion-to-struct-scsi_cmnd-in-fc4.patch
+dereference-in-drivers-scsi-lpfc-lpfc_ctc.patch
+scsi-scsi_cmnd-convertion-in-arm-subtree.patch

 scsi driver fixlets.

+gregkh-usb-usb-storage-unusual_devs.h-entry-for-sony-ericsson-p990i.patch
+gregkh-usb-usb-wacom-driver-updates.patch
+gregkh-usb-usb-bug_on-conversion-for-wacom.c.patch
+gregkh-usb-usb-remove-private-debug-macros-from-kaweth.patch

 USB tree updates.

+usb-serial-mos7840-fix-cast.patch
+sound-usb-usbaudio-handle-return-value-of-usb_register.patch

 USB fixes.

+git-watchdog-fixup.patch

 Fix rejects in git-watchdog.patch

+atmel-wireless-output-signal-strength-information.patch
+orinoco-fix.patch
+possible-dereference-in-drivers-net-wireless-zd1201c.patch
+more-we-21-potential-overflows.patch

 Various wireless fixes.

+x86_64-mm-calgary-init.patch
+x86_64-mm-calgary-off-by-one.patch
+x86_64-mm-calgary-jon-contact.patch
+x86_64-mm-calgary-hex-bus.patch
+x86_64-mm-pci-bios-fix.patch
+x86_64-mm-kernel-stack-termination.patch

 x86 tree updates.

+fix-x86_64-mm-kernel-stack-termination.patch
+insert-local-and-io-apics-into-resource-map.patch
+x86_64-dump_trace-atomicity-fix.patch
+spinlock-debug-all-cpu-backtrace.patch
+spinlock-debug-all-cpu-backtrace-fix.patch
+spinlock-debug-all-cpu-backtrace-fix-2.patch
+spinlock-debug-all-cpu-backtrace-fix-3.patch

 x86 things.

-mm-thrash-detect-process-thrashing-against-itself.patch

 Dropped.

+mm-fix-in-kerneldoc.patch

 kerneldoc fix.

+get-rid-of-zone_table-fix-2.patch
+get-rid-of-zone_table-fix-4.patch
+get-rid-of-zone_table-fix-3.patch

 Fix get-rid-of-zone_table.patch some more.

-optional-zone_dma-for-i386.patch
-optional-zone_dma-for-x86_64.patch

 Dropped.

+set-config_zone_dma-for-arches-with-generic_isa_dma.patch

 Fix the ZONE_DMA-removal patches some more.

+slab-clean-up-leak-tracking-ifdefs-a-little-bit.patch
+kmemdup-introduce-vs-slab-clean-up-leak-tracking-ifdefs-a-little-bit.patch
+slab-reduce-numa-text-size.patch
+slab-reduce-numa-text-size-tidy.patch

 slab updates.

+swap-token-try-to-grab-swap-token-before-the-vm-selects-pages-for-eviction.patch
+swap-token-new-scheme-to-preempt-token.patch
+swap-token-new-scheme-to-preempt-token-tidy.patch

 Play with the swap-token code.

+tiacx-fix-attribute-packed-warnings-fix.patch

 Fix acx1xx-wireless-driver.patch

+frv-permit-large-kmalloc-allocations.patch

 FRV update.

+swsusp-debugging-doc.patch
+swsusp-add-ioctl-for-swap-files-support.patch
+swsusp-add-ioctl-for-swap-files-support-fix.patch
+swsusp-update-userland-interface-documentation.patch

 swsusp udpates: it allegedly supports swapfiles now.

+create-kallsyms_lookup_size_offset.patch
+low-performance-of-lib-sortc.patch
+generic-bug-handling.patch
+use-generic-bug-for-i386.patch
+use-generic-bug-for-x86-64.patch
+use-generic-bug-for-powerpc.patch
+use-generic-bug-for-powerpc-fix-2.patch
+bug-test-1.patch
+adds-carta_random32-library-routine.patch
+char-kill-unneeded-memsets.patch
+char-serial167-remove-useless-tty-check.patch
+kernel-doc-for-kernel-dmac.patch
+kernel-doc-for-kernel-resourcec.patch
+fs-eventpoll-error-handling-micro-cleanup.patch
+ipmi-fix-uninitd-data-bug.patch
+drivers-char-ip2-kill-unused-code-label.patch
+schedule-ftape-removal.patch
+isdn-warning-fixes.patch
+restore-parport_pc-probing-on-powermac.patch
+add-pekka-to-credits.patch
+ipmi-allow-user-to-override-the-kernel-ipmi-daemon-enable.patch
+ipmi-allow-user-to-override-the-kernel-ipmi-daemon-enable-tidy.patch
+ia64-note-requirement-for-8250_pnp-now-that-8250_acpi-is-gone.patch
+maintainers-removes-duplicated-entry.patch
+pktcdvd-replace-pktcdvd-strings-with-macro-driver_name.patch
+pktcdvd-rename-a-variable-for-better-readability.patch
+remove-unnecessary-check-in-fs-reiserfs-inodec.patch
+add-unifdef-to-gitignore.patch
+fix-spurious-error-on-tags-target-when-missing-defconfig.patch

 Misc.

+pata_hpt366-fix-typo.patch

 PATA fix.

+fs-cache-cachefiles-a-cache-that-backs-onto-a-mounted-filesystem-fscache-fix-gfp_t-sparse-annotations.patch

 cachefiles sparse annotations.

+fscache-kconfig-tidying.patch

 Kconfig cleanup.

+char-mxser_new-use-__devinit-macros.patch
+char-mxser_new-pci_request_region-for-pci-regions.patch
+char-mxser_new-check-request_region-retvals.patch
+char-mxser_new-kill-unneeded-memsets.patch

 More updates for the new mxser driver.

+knfsd-add-nfs-export-support-to-tmpfs.patch
+knfsd-lockd-fix-refount-on-nsm.patch
+knfsd-fix-auto-sizing-of-nfsd-request-reply-buffers.patch
+knfsd-close-a-race-opportunity-in-d_splice_alias.patch
+knfsd-nfsd-store-export-path-in-export.patch
+knfsd-nfsd4-fslocations-data-structures.patch
+knfsd-nfsd4-fslocations-data-structures-nfsd4-fix-fs-locations-bounds-checking.patch
+knfsd-nfsd4-fslocations-data-structures-nfsd4-fslocs-fix-compile-in-non-config_nfsd_v4-case.patch
+knfsd-nfsd4-xdr-encoding-for-fs_locations.patch
+knfsd-nfsd4-actually-use-all-the-pieces-to-implement-referrals.patch

 knfsd updates

-sched-remove-unnecessary-sched-group-allocations-fix.patch

 Folded into sched-remove-unnecessary-sched-group-allocations.patch

-lower-migration-thread-stop-machine-prio.patch

 Nacked.

+ecryptfs-enable-plaintext-passthrough.patch

 ecryptfs update.

+ide-more-pci_find-cleanup.patch
+ide-cs-compactflash-driver-rm-irq-warning.patch

 IDE updates.

+md-fix-duplicity-of-levels-in-mdtxt.patch
+md-remove-max_md_devs-which-is-an-arbitrary-limit.patch
+md-remove-experimental-classification-from-raid5-reshape.patch
+md-use-ffz-instead-of-find_first_set-to-convert-multiplier-to-shift.patch
+md-allow-set_bitmap_file-to-work-on-64bit-kernel-with-32bit-userspace.patch
+md-add-error-reporting-to-superblock-write-failure.patch

 RAID updates.

+genirq-clean-up-irq-flow-type-naming.patch

 genirq cleanup.

+kevent-core-files.patch
+kevent-core-files-fix.patch
+kevent-core-files-s390-hack.patch
+kevent-poll-select-notifications.patch
+kevent-socket-notifications.patch
+kevent-socket-notifications-fix-2.patch
+kevent-socket-notifications-fix-4.patch
+kevent-timer-notifications.patch

 Evgeniy's kevent feature.

+fdtable-make-fdarray-and-fdsets-equal-in-size-slim.patch

 SLIM driver update.

+squash-ipc-warnings.patch
+squash-transmeta-warnings.patch
+squash-tcp-warnings.patch
+squash-udf-warnings.patch

 Shut up a few warnings.



All 871 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/patch-list



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3
  2006-10-03  7:11 2.6.18-mm3 Andrew Morton
@ 2006-10-03 14:33 ` Michal Piotrowski
  2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 21+ messages in thread
From: Michal Piotrowski @ 2006-10-03 14:33 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

On 03/10/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/
>

For me it's just another stable (boring :) -mm

# cat tmp/Tests\ results
GOOD aiostress Completed Successfully
GOOD bonnie Completed Successfully
GOOD dbench Completed Successfully
GOOD fs_mark Completed Successfully
GOOD fsx Completed Successfully
GOOD interbench Completed Successfully
GOOD isic Completed Successfully
GOOD reaim Completed Successfully
GOOD scrashme Completed Successfully
GOOD sleeptest Completed Successfully
GOOD stress Completed Successfully
GOOD tbench Completed Successfully
GOOD tiobench Completed Successfully

BTW. There might be something wrong with kernel log buffer
(CONFIG_LOG_BUF_SHIFT=20)

dmesg | wc -l
256

cat mm-syslog | wc -l
935

dmesg & syslog http://www.stardust.webpages.pl/files/mm/2.6.18-mm3/

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/)

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3
  2006-10-03  7:11 2.6.18-mm3 Andrew Morton
  2006-10-03 14:33 ` 2.6.18-mm3 Michal Piotrowski
@ 2006-10-03 17:37 ` Badari Pulavarty
  2006-10-03 18:01   ` 2.6.18-mm3 Andrew Morton
  2006-10-03 18:05   ` 2.6.18-mm3 Badari Pulavarty
  2006-10-04 13:44 ` [-mm PATCH] fixed PCMCIA au1000_generic.c Yoichi Yuasa
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 21+ messages in thread
From: Badari Pulavarty @ 2006-10-03 17:37 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml

On Tue, 2006-10-03 at 00:11 -0700, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/
> 
> - Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
>   git-gccbug.patch
> 
> - Francois Romieu is doing some qlogic driver maintenance - added his
>   git-qla3xxx.patch to the -mm lineup.
> 
> - Some wireless-related crashes are hopefully fixed.  But if there are still
>   wireless problems, be sure that you have the latest userspace tools.
> 
> - The recent spate of IRQ-allocation-related crashes on x86_64 is hopefully
>   fixed.
> 
> - As far as we know, the MSI handling in -mm is now rock-solid.


Not having any luck with it :(

Thanks,
Badari

Kernel command line: root=/dev/hda2 vga=0x314  selinux=0   console=tty0
console=ttyS0,38400 resume=/dev/hda1 resume=/dev/hda1  splash=silent
showopts
Initializing CPU#0
PID hash table entries: 4096 (order: 12, 32768 bytes)
Console: colour dummy device 80x25
Dentry cache hash table entries: 1048576 (order: 11, 8388608 bytes)
Inode-cache hash table entries: 524288 (order: 10, 4194304 bytes)
Checking aperture...
CPU 0: aperture @ 0 size 32 MB
No AGP bridge found
Your BIOS doesn't leave a aperture memory hole
Please enable the IOMMU option in the BIOS setup
This costs you 64 MB of RAM
Mapping aperture over 65536 KB of RAM @ 4000000
Memory: 7147724k/7864320k available (2924k kernel code, 191856k
reserved, 1697k data, 360k init)
------------[ cut here ]------------
kernel BUG in init_list at mm/slab.c:1334!
invalid opcode: 0000 [1] SMP
last sysfs file:
CPU 0
Modules linked in:
Pid: 0, comm: swapper Not tainted 2.6.18-mm3 #1
RIP: 0010:[<ffffffff8027bd5b>]  [<ffffffff8027bd5b>] init_list
+0x2b/0x120
RSP: 0018:ffffffff806d9f18  EFLAGS: 00010212
RAX: 000000000000003f RBX: 0000000000000001 RCX: 0000000000000000
RDX: 0000000000000001 RSI: ffffffff8072b0a8 RDI: ffff81017a800040
RBP: ffffffff806d9f48 R08: 0000000000000001 R09: 0000000000000003
R10: 0000000000000000 R11: ffffffff8072cac8 R12: 0000000000000001
R13: ffff81017a800040 R14: ffffffff8072b0a8 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffffffff80684000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000000000 CR3: 0000000000201000 CR4: 00000000000006a0
Process swapper (pid: 0, threadinfo ffffffff806d8000, task
ffffffff805f7bc0)
Stack:  ffffffff806d9f48 0000000100000286 0000000000000001
ffffffff8072b0a8
 0000000000000040 0000000000000000 ffffffff806d9f98 ffffffff806fdc69
 0000000000000168 0000000000000240 0000000100000001 0000000000090000
Call Trace:
 [<ffffffff806fdc69>] kmem_cache_init+0x3b9/0x490
 [<ffffffff806e36ef>] start_kernel+0x18f/0x220
 [<ffffffff806e3176>] _sinittext+0x176/0x180


Code: 0f 0b 66 66 90 48 8b 3d b1 ae 38 00 be d0 00 00 00 e8 0f ff
RIP  [<ffffffff8027bd5b>] init_list+0x2b/0x120
 RSP <ffffffff806d9f18>
 <0>Kernel panic - not syncing: Attempted to kill the idle task!




^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3
  2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
@ 2006-10-03 18:01   ` Andrew Morton
  2006-10-03 18:16     ` 2.6.18-mm3 Badari Pulavarty
  2006-10-03 18:05   ` 2.6.18-mm3 Badari Pulavarty
  1 sibling, 1 reply; 21+ messages in thread
From: Andrew Morton @ 2006-10-03 18:01 UTC (permalink / raw)
  To: Badari Pulavarty; +Cc: lkml, linux-mm

On Tue, 03 Oct 2006 10:37:31 -0700
Badari Pulavarty <pbadari@us.ibm.com> wrote:

> On Tue, 2006-10-03 at 00:11 -0700, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/
> > 
> > - Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
> >   git-gccbug.patch
> > 
> > - Francois Romieu is doing some qlogic driver maintenance - added his
> >   git-qla3xxx.patch to the -mm lineup.
> > 
> > - Some wireless-related crashes are hopefully fixed.  But if there are still
> >   wireless problems, be sure that you have the latest userspace tools.
> > 
> > - The recent spate of IRQ-allocation-related crashes on x86_64 is hopefully
> >   fixed.
> > 
> > - As far as we know, the MSI handling in -mm is now rock-solid.
> 
> 
> Not having any luck with it :(
> 

You never do ;)

We'd make better progress if you could bisect these failures.

> 
> Kernel command line: root=/dev/hda2 vga=0x314  selinux=0   console=tty0
> console=ttyS0,38400 resume=/dev/hda1 resume=/dev/hda1  splash=silent
> showopts
> Initializing CPU#0
> PID hash table entries: 4096 (order: 12, 32768 bytes)
> Console: colour dummy device 80x25
> Dentry cache hash table entries: 1048576 (order: 11, 8388608 bytes)
> Inode-cache hash table entries: 524288 (order: 10, 4194304 bytes)
> Checking aperture...
> CPU 0: aperture @ 0 size 32 MB
> No AGP bridge found
> Your BIOS doesn't leave a aperture memory hole
> Please enable the IOMMU option in the BIOS setup
> This costs you 64 MB of RAM
> Mapping aperture over 65536 KB of RAM @ 4000000
> Memory: 7147724k/7864320k available (2924k kernel code, 191856k
> reserved, 1697k data, 360k init)
> ------------[ cut here ]------------
> kernel BUG in init_list at mm/slab.c:1334!
> invalid opcode: 0000 [1] SMP
> last sysfs file:
> CPU 0
> Modules linked in:
> Pid: 0, comm: swapper Not tainted 2.6.18-mm3 #1
> RIP: 0010:[<ffffffff8027bd5b>]  [<ffffffff8027bd5b>] init_list
> +0x2b/0x120
> RSP: 0018:ffffffff806d9f18  EFLAGS: 00010212
> RAX: 000000000000003f RBX: 0000000000000001 RCX: 0000000000000000
> RDX: 0000000000000001 RSI: ffffffff8072b0a8 RDI: ffff81017a800040
> RBP: ffffffff806d9f48 R08: 0000000000000001 R09: 0000000000000003
> R10: 0000000000000000 R11: ffffffff8072cac8 R12: 0000000000000001
> R13: ffff81017a800040 R14: ffffffff8072b0a8 R15: 0000000000000000
> FS:  0000000000000000(0000) GS:ffffffff80684000(0000)
> knlGS:0000000000000000
> CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> CR2: 0000000000000000 CR3: 0000000000201000 CR4: 00000000000006a0
> Process swapper (pid: 0, threadinfo ffffffff806d8000, task
> ffffffff805f7bc0)
> Stack:  ffffffff806d9f48 0000000100000286 0000000000000001
> ffffffff8072b0a8
>  0000000000000040 0000000000000000 ffffffff806d9f98 ffffffff806fdc69
>  0000000000000168 0000000000000240 0000000100000001 0000000000090000
> Call Trace:
>  [<ffffffff806fdc69>] kmem_cache_init+0x3b9/0x490
>  [<ffffffff806e36ef>] start_kernel+0x18f/0x220
>  [<ffffffff806e3176>] _sinittext+0x176/0x180
> 
> 
> Code: 0f 0b 66 66 90 48 8b 3d b1 ae 38 00 be d0 00 00 00 e8 0f ff
> RIP  [<ffffffff8027bd5b>] init_list+0x2b/0x120
>  RSP <ffffffff806d9f18>
>  <0>Kernel panic - not syncing: Attempted to kill the idle task!

http://userweb.kernel.org/~akpm/badari2.bz2 is a rollup against 2.6.18
which omits the various zone changes.  Can you see if that also fails?

Thanks.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3
  2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
  2006-10-03 18:01   ` 2.6.18-mm3 Andrew Morton
@ 2006-10-03 18:05   ` Badari Pulavarty
  1 sibling, 0 replies; 21+ messages in thread
From: Badari Pulavarty @ 2006-10-03 18:05 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml, linux-mm

On Tue, 2006-10-03 at 10:37 -0700, Badari Pulavarty wrote:
> On Tue, 2006-10-03 at 00:11 -0700, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/
> > 
> > - Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
> >   git-gccbug.patch
> > 
> > - Francois Romieu is doing some qlogic driver maintenance - added his
> >   git-qla3xxx.patch to the -mm lineup.
> > 
> > - Some wireless-related crashes are hopefully fixed.  But if there are still
> >   wireless problems, be sure that you have the latest userspace tools.
> > 
> > - The recent spate of IRQ-allocation-related crashes on x86_64 is hopefully
> >   fixed.
> > 
> > - As far as we know, the MSI handling in -mm is now rock-solid.
> 
> 
> Not having any luck with it :(
> 
> Thanks,
> Badari
> 
> Kernel command line: root=/dev/hda2 vga=0x314  selinux=0   console=tty0
> console=ttyS0,38400 resume=/dev/hda1 resume=/dev/hda1  splash=silent
> showopts
> Initializing CPU#0
> PID hash table entries: 4096 (order: 12, 32768 bytes)
> Console: colour dummy device 80x25
> Dentry cache hash table entries: 1048576 (order: 11, 8388608 bytes)
> Inode-cache hash table entries: 524288 (order: 10, 4194304 bytes)
> Checking aperture...
> CPU 0: aperture @ 0 size 32 MB
> No AGP bridge found
> Your BIOS doesn't leave a aperture memory hole
> Please enable the IOMMU option in the BIOS setup
> This costs you 64 MB of RAM
> Mapping aperture over 65536 KB of RAM @ 4000000
> Memory: 7147724k/7864320k available (2924k kernel code, 191856k
> reserved, 1697k data, 360k init)
> ------------[ cut here ]------------
> kernel BUG in init_list at mm/slab.c:1334!
> invalid opcode: 0000 [1] SMP
> last sysfs file:
> CPU 0
> Modules linked in:
> Pid: 0, comm: swapper Not tainted 2.6.18-mm3 #1
> RIP: 0010:[<ffffffff8027bd5b>]  [<ffffffff8027bd5b>] init_list
> +0x2b/0x120
> RSP: 0018:ffffffff806d9f18  EFLAGS: 00010212
> RAX: 000000000000003f RBX: 0000000000000001 RCX: 0000000000000000
> RDX: 0000000000000001 RSI: ffffffff8072b0a8 RDI: ffff81017a800040
> RBP: ffffffff806d9f48 R08: 0000000000000001 R09: 0000000000000003
> R10: 0000000000000000 R11: ffffffff8072cac8 R12: 0000000000000001
> R13: ffff81017a800040 R14: ffffffff8072b0a8 R15: 0000000000000000
> FS:  0000000000000000(0000) GS:ffffffff80684000(0000)
> knlGS:0000000000000000
> CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> CR2: 0000000000000000 CR3: 0000000000201000 CR4: 00000000000006a0
> Process swapper (pid: 0, threadinfo ffffffff806d8000, task
> ffffffff805f7bc0)
> Stack:  ffffffff806d9f48 0000000100000286 0000000000000001
> ffffffff8072b0a8
>  0000000000000040 0000000000000000 ffffffff806d9f98 ffffffff806fdc69
>  0000000000000168 0000000000000240 0000000100000001 0000000000090000
> Call Trace:
>  [<ffffffff806fdc69>] kmem_cache_init+0x3b9/0x490
>  [<ffffffff806e36ef>] start_kernel+0x18f/0x220
>  [<ffffffff806e3176>] _sinittext+0x176/0x180

Here is the fix for this. With this -mm3 boots fine (no networking
problems so far).

Thanks,
Badari

Fix typo in kmem_cache_init().

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>

 mm/slab.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18-mm3/mm/slab.c
===================================================================
--- linux-2.6.18-mm3.orig/mm/slab.c	2006-10-03 11:31:31.000000000 -0700
+++ linux-2.6.18-mm3/mm/slab.c	2006-10-03 11:31:45.000000000 -0700
@@ -1513,7 +1513,7 @@ void __init kmem_cache_init(void)
 
 		for_each_online_node(nid) {
 			init_list(malloc_sizes[INDEX_AC].cs_cachep,
-				  &initkmem_list3[SIZE_AC + node], nid);
+				  &initkmem_list3[SIZE_AC + nid], nid);
 
 			if (INDEX_AC != INDEX_L3) {
 				init_list(malloc_sizes[INDEX_L3].cs_cachep,



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3
  2006-10-03 18:01   ` 2.6.18-mm3 Andrew Morton
@ 2006-10-03 18:16     ` Badari Pulavarty
  0 siblings, 0 replies; 21+ messages in thread
From: Badari Pulavarty @ 2006-10-03 18:16 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml, linux-mm

On Tue, 2006-10-03 at 11:01 -0700, Andrew Morton wrote:
...
> 
> http://userweb.kernel.org/~akpm/badari2.bz2 is a rollup against 2.6.18
> which omits the various zone changes.  Can you see if that also fails?

I can't compile this. I found the problem with -mm3 (I sent the patch
already). Networking is working fine now on -mm3. So I don't bother
trying this for now ?

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC      arch/x86_64/kernel/asm-offsets.s
In file included from arch/x86_64/kernel/asm-offsets.c:7:
include/linux/crypto.h:20:24: error: asm/atomic.h: No such file or
directory
In file included from include/linux/sched.h:4,
                 from include/linux/module.h:9,
                 from include/linux/crypto.h:21,
                 from arch/x86_64/kernel/asm-offsets.c:7:
include/linux/auxvec.h:4:24: error: asm/auxvec.h: No such file or
directory
In file included from include/linux/module.h:9,
                 from include/linux/crypto.h:21,
                 from arch/x86_64/kernel/asm-offsets.c:7:
include/linux/sched.h:44:36: error: asm/param.h: No such file or
directory


Thanks,
Badari


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [-mm PATCH] fixed PCMCIA au1000_generic.c
  2006-10-03  7:11 2.6.18-mm3 Andrew Morton
  2006-10-03 14:33 ` 2.6.18-mm3 Michal Piotrowski
  2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
@ 2006-10-04 13:44 ` Yoichi Yuasa
  2006-10-06  6:18   ` Om Narasimhan
  2006-10-04 15:14 ` 2.6.18-mm3 oops in xfrm_register_mode Steve Fox
  2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
  4 siblings, 1 reply; 21+ messages in thread
From: Yoichi Yuasa @ 2006-10-04 13:44 UTC (permalink / raw)
  To: Andrew Morton; +Cc: yoichi_yuasa, linux-kernel

Hi,

pcmcia-au1000_generic-fix.patch has a problem.
It needs more fix.
ops->shutdown(skt), skt is out of definition scope.

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X linux-2.6.18-mm3/Documentation/dontdiff linux-2.6.18-mm3-orig/drivers/pcmcia/au1000_generic.c linux-2.6.18-mm3/drivers/pcmcia/au1000_generic.c
--- linux-2.6.18-mm3-orig/drivers/pcmcia/au1000_generic.c	2006-10-04 11:24:33.017136250 +0900
+++ linux-2.6.18-mm3/drivers/pcmcia/au1000_generic.c	2006-10-04 22:32:21.806060500 +0900
@@ -351,6 +351,7 @@ struct skt_dev_info {
 int au1x00_pcmcia_socket_probe(struct device *dev, struct pcmcia_low_level *ops, int first, int nr)
 {
 	struct skt_dev_info *sinfo;
+	struct au1000_pcmcia_socket *skt;
 	int ret, i;
 
 	sinfo = kzalloc(sizeof(struct skt_dev_info), GFP_KERNEL);
@@ -365,7 +366,7 @@ int au1x00_pcmcia_socket_probe(struct de
 	 * Initialise the per-socket structure.
 	 */
 	for (i = 0; i < nr; i++) {
-		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
+		skt = PCMCIA_SOCKET(i);
 		memset(skt, 0, sizeof(*skt));
 
 		skt->socket.resource_ops = &pccard_static_ops;
@@ -442,7 +443,7 @@ out_err:
 	flush_scheduled_work();
 	ops->hw_shutdown(skt);
 	while (i-- > 0) {
-		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
+		skt = PCMCIA_SOCKET(i);
 		del_timer_sync(&skt->poll_timer);
 		pcmcia_unregister_socket(&skt->socket);
 		flush_scheduled_work();

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3 oops in xfrm_register_mode
  2006-10-03  7:11 2.6.18-mm3 Andrew Morton
                   ` (2 preceding siblings ...)
  2006-10-04 13:44 ` [-mm PATCH] fixed PCMCIA au1000_generic.c Yoichi Yuasa
@ 2006-10-04 15:14 ` Steve Fox
  2006-10-04 16:57   ` Andrew Morton
  2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
  4 siblings, 1 reply; 21+ messages in thread
From: Steve Fox @ 2006-10-04 15:14 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/

This is on the same x86_64 box which I reported the -mm2 boot problem. I 
have confirmed that CONFIG_DEBUG_INFO was on for the -mm2 oops as well 
as this one. I'll begin a bisection on this issue as well and post the 
results when finished.

Fusion MPT base driver 3.04.01
Copyright (c) 1999-2005 LSI Logic Corporation
Fusion MPT SPI Host driver 3.04.01
Fusion MPT FC Host driver 3.04.01
Fusion MPT misc device (ioctl) driver 3.04.01
mptctl: Registered with Fusion MPT base driver
mptctl: /dev/mptctl @ (major,minor=10,220)
PNP: PS/2 Controller [PNP0303:PS2K,PNP0f13:PS2M] at 0x60,0x64 irq 1,12
serio: i8042 KBD port at 0x60,0x64 irq 1
serio: i8042 AUX port at 0x60,0x64 irq 12
mice: PS/2 mouse device common for all mice
Unable to handle kernel NULL pointer dereference at 0000000000000807 RIP:
  [<ffffffff80471196>] xfrm_register_mode+0x36/0x60
PGD 0
Oops: 0000 [1] SMP
last sysfs file:
CPU 0
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.18-mm3 #2
RIP: 0010:[<ffffffff80471196>]  [<ffffffff80471196>] 
xfrm_register_mode+0x36/0x60
RSP: 0000:ffff810bffcbded0  EFLAGS: 00010286
RAX: 00000000000007ff RBX: ffffffff8056a1a0 RCX: 0000000000000000
RDX: ffffffffffffffff RSI: 0000000000000002 RDI: ffffffff8056ae10
RBP: 00000000ffffffef R08: 00000000ade70d2e R09: 0000000000000000
R10: ffff810bffcbdcb0 R11: 0000000000000154 R12: 0000000000000000
R13: ffff810bffcbdef0 R14: 0000000000000000 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffffffff805e8000(0000) knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000000807 CR3: 0000000000201000 CR4: 00000000000006e0
Process swapper (pid: 1, threadinfo ffff810bffcbc000, task ffff810bffcbb510)
Stack:  0000000000000000 ffffffff806363f0 0000000000000000 ffffffff80207182
  0000000000000000 0000000000000000 0000000000000000 0000000000000000
  0000000000000000 0000000000000000 0000000000000000 0000000000090000
Call Trace:
  [<ffffffff80207182>] init+0x162/0x330
  [<ffffffff8020a9d5>] child_rip+0xa/0x15
  [<ffffffff8033a932>] acpi_ds_init_one_object+0x0/0x82
  [<ffffffff80207020>] init+0x0/0x330
  [<ffffffff8020a9cb>] child_rip+0x0/0x15


Code: 48 83 78 08 00 75 06 48 89 58 08 31 ed 48 89 d7 e8 e5 fe ff
RIP  [<ffffffff80471196>] xfrm_register_mode+0x36/0x60
  RSP <ffff810bffcbded0>
CR2: 0000000000000807
  <0>Kernel panic - not syncing: Aiee, killing interrupt handler!


-- 

Steve Fox
IBM Linux Technology Center

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3 oops in xfrm_register_mode
  2006-10-04 15:14 ` 2.6.18-mm3 oops in xfrm_register_mode Steve Fox
@ 2006-10-04 16:57   ` Andrew Morton
  2006-10-04 21:02     ` Steve Fox
  0 siblings, 1 reply; 21+ messages in thread
From: Andrew Morton @ 2006-10-04 16:57 UTC (permalink / raw)
  To: Steve Fox; +Cc: linux-kernel, netdev

On Wed, 04 Oct 2006 10:14:55 -0500
Steve Fox <drfickle@us.ibm.com> wrote:

> Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm3/
> 
> This is on the same x86_64 box which I reported the -mm2 boot problem. I 
> have confirmed that CONFIG_DEBUG_INFO was on for the -mm2 oops as well 
> as this one. I'll begin a bisection on this issue as well and post the 
> results when finished.
> 
> Fusion MPT base driver 3.04.01
> Copyright (c) 1999-2005 LSI Logic Corporation
> Fusion MPT SPI Host driver 3.04.01
> Fusion MPT FC Host driver 3.04.01
> Fusion MPT misc device (ioctl) driver 3.04.01
> mptctl: Registered with Fusion MPT base driver
> mptctl: /dev/mptctl @ (major,minor=10,220)
> PNP: PS/2 Controller [PNP0303:PS2K,PNP0f13:PS2M] at 0x60,0x64 irq 1,12
> serio: i8042 KBD port at 0x60,0x64 irq 1
> serio: i8042 AUX port at 0x60,0x64 irq 12
> mice: PS/2 mouse device common for all mice
> Unable to handle kernel NULL pointer dereference at 0000000000000807 RIP:
>   [<ffffffff80471196>] xfrm_register_mode+0x36/0x60
> PGD 0
> Oops: 0000 [1] SMP
> last sysfs file:
> CPU 0
> Modules linked in:
> Pid: 1, comm: swapper Not tainted 2.6.18-mm3 #2
> RIP: 0010:[<ffffffff80471196>]  [<ffffffff80471196>] 
> xfrm_register_mode+0x36/0x60
> RSP: 0000:ffff810bffcbded0  EFLAGS: 00010286
> RAX: 00000000000007ff RBX: ffffffff8056a1a0 RCX: 0000000000000000
> RDX: ffffffffffffffff RSI: 0000000000000002 RDI: ffffffff8056ae10
> RBP: 00000000ffffffef R08: 00000000ade70d2e R09: 0000000000000000
> R10: ffff810bffcbdcb0 R11: 0000000000000154 R12: 0000000000000000
> R13: ffff810bffcbdef0 R14: 0000000000000000 R15: 0000000000000000
> FS:  0000000000000000(0000) GS:ffffffff805e8000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> CR2: 0000000000000807 CR3: 0000000000201000 CR4: 00000000000006e0
> Process swapper (pid: 1, threadinfo ffff810bffcbc000, task ffff810bffcbb510)
> Stack:  0000000000000000 ffffffff806363f0 0000000000000000 ffffffff80207182
>   0000000000000000 0000000000000000 0000000000000000 0000000000000000
>   0000000000000000 0000000000000000 0000000000000000 0000000000090000
> Call Trace:
>   [<ffffffff80207182>] init+0x162/0x330
>   [<ffffffff8020a9d5>] child_rip+0xa/0x15
>   [<ffffffff8033a932>] acpi_ds_init_one_object+0x0/0x82
>   [<ffffffff80207020>] init+0x0/0x330
>   [<ffffffff8020a9cb>] child_rip+0x0/0x15
> 
> 
> Code: 48 83 78 08 00 75 06 48 89 58 08 31 ed 48 89 d7 e8 e5 fe ff
> RIP  [<ffffffff80471196>] xfrm_register_mode+0x36/0x60
>   RSP <ffff810bffcbded0>
> CR2: 0000000000000807
>   <0>Kernel panic - not syncing: Aiee, killing interrupt handler!
> 

Thanks, Steve.

You might well find this bisection lands you on origin.patch.  ie: a
mainline bug.  I note that David merged a few more xfrm fixes this morning.

So to confirm that, first test just origin.patch and if that fails, test
git-of-the-moment.  If that doesn't fail, they fixed it.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3 oops in xfrm_register_mode
  2006-10-04 16:57   ` Andrew Morton
@ 2006-10-04 21:02     ` Steve Fox
  2006-10-05 15:06       ` Badari Pulavarty
  0 siblings, 1 reply; 21+ messages in thread
From: Steve Fox @ 2006-10-04 21:02 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, netdev

On Wed, 2006-10-04 at 09:57 -0700, Andrew Morton wrote:

> You might well find this bisection lands you on origin.patch.  ie: a
> mainline bug.  I note that David merged a few more xfrm fixes this morning.
> 
> So to confirm that, first test just origin.patch and if that fails, test
> git-of-the-moment.  If that doesn't fail, they fixed it.

origin.patch from --m3 failed. Unfortunately so did a fresh clone of
Linus's git tree.

-- 

Steve Fox
IBM Linux Technology Center

^ permalink raw reply	[flat|nested] 21+ messages in thread

* make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-03  7:11 2.6.18-mm3 Andrew Morton
                   ` (3 preceding siblings ...)
  2006-10-04 15:14 ` 2.6.18-mm3 oops in xfrm_register_mode Steve Fox
@ 2006-10-05  8:37 ` Ingo Molnar
  2006-10-05 10:05   ` Jeff Garzik
  2006-10-05 16:37   ` Adrian Bunk
  4 siblings, 2 replies; 21+ messages in thread
From: Ingo Molnar @ 2006-10-05  8:37 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-kernel, Andrew Morton


* Andrew Morton <akpm@osdl.org> wrote:

> - Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
>   git-gccbug.patch

Jeff: very nice! (I did this myself on a much smaller scale for the -rt 
patch, because it's just so lethal if some serious warning gets lost in 
the myriads of 'possible use of uninitialized' messages.)

A small suggestion: to give GCC folks a chance to actually fix this, 
could we actively annotate these places instead of working them around?
I.e., instead of:

        long cursor = 0;
        int error = 0;
-       void *new_mc;
+       void *new_mc = NULL;
        int cpu;
        cpumask_t old;

couldnt we do:

	void *new_mc __GCC_WARN_BUG;

and then do something like this in gcc.h:

 #ifdef CONFIG_ELIMINATE_BOGUS_GCC_WARNINGS
 # define __GCC_WARN_BUG = 0
 #else
 # define __GCC_WARN_BUG
 #endif

this both gives an in-source incentive for GCC folks to get rid of these 
bogus warnings (or remain shamed for eternity), and gives us the ability 
to control the presence of these workarounds (and the eventual ability 
to eliminate them in the future).

this would also mean we could merge your tree upstream without worrying 
about hiding gcc bugs.

	Ingo

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
@ 2006-10-05 10:05   ` Jeff Garzik
  2006-10-05 16:21     ` make-bogus-warnings-go-away tree Roland Dreier
  2006-10-05 20:52     ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Kyle Moffett
  2006-10-05 16:37   ` Adrian Bunk
  1 sibling, 2 replies; 21+ messages in thread
From: Jeff Garzik @ 2006-10-05 10:05 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel, Andrew Morton

Ingo Molnar wrote:
> A small suggestion: to give GCC folks a chance to actually fix this, 
> could we actively annotate these places instead of working them around?


There was a patch posted in the past, mentioned in the thread discussed 
my #gccbug branch, that permitted annotations with zero code size 
changes.  I think that sort of annotation approach would be preferred. 
It was something like

#define noinit_warning(x) \
	do { (void) (x) = (x); } while (0)

but given my memory, that's probably all wrong.

So, I agree that annotations are a good idea, but I'm not so sure that 
your proposed "= 0" approach is the best one.  Remember, we need to do 
this for multi-member structures, integers, and pointers, not just 
things easily assigned to zero.

	Jeff



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: 2.6.18-mm3 oops in xfrm_register_mode
  2006-10-04 21:02     ` Steve Fox
@ 2006-10-05 15:06       ` Badari Pulavarty
  0 siblings, 0 replies; 21+ messages in thread
From: Badari Pulavarty @ 2006-10-05 15:06 UTC (permalink / raw)
  To: Steve Fox; +Cc: Andrew Morton, lkml, netdev

On Wed, 2006-10-04 at 16:02 -0500, Steve Fox wrote:
> On Wed, 2006-10-04 at 09:57 -0700, Andrew Morton wrote:
> 
> > You might well find this bisection lands you on origin.patch.  ie: a
> > mainline bug.  I note that David merged a few more xfrm fixes this morning.
> > 
> > So to confirm that, first test just origin.patch and if that fails, test
> > git-of-the-moment.  If that doesn't fail, they fixed it.
> 
> origin.patch from --m3 failed. Unfortunately so did a fresh clone of
> Linus's git tree.
> 

I am not an expert in that area, but your stack trace made me curious.
Looking at the dis-assembly, line of code in question is:

	        if (likely(modemap[mode->encap] == NULL)) {

Register contents indicate that, its called as

	xfrm_register_mode(&xfrm4_tunnel_mode, AF_INET);
or
	xfrm_register_mode(&xfrm4_transport_mode, AF_INET);

(family is AF_INET).

The invalid deref is due to modemap = 0x7ff (RAX: 00000000000007ff)

Since its so easy to reproduce, can you add a printk before
this check to dump mode->encap and modemap, afinfo, family etc ?
Just curious ..


Thanks,
Badari


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree
  2006-10-05 10:05   ` Jeff Garzik
@ 2006-10-05 16:21     ` Roland Dreier
  2006-10-05 20:52     ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Kyle Moffett
  1 sibling, 0 replies; 21+ messages in thread
From: Roland Dreier @ 2006-10-05 16:21 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Ingo Molnar, linux-kernel, Andrew Morton

    Jeff> So, I agree that annotations are a good idea, but I'm not so
    Jeff> sure that your proposed "= 0" approach is the best one.
    Jeff> Remember, we need to do this for multi-member structures,
    Jeff> integers, and pointers, not just things easily assigned to
    Jeff> zero.

Not to mention the fact that "foo = 0" generates extra (probably
unnecessary) code to initialize foo, while "foo = foo" just shuts up
the gcc warning without affecting generated code.

I'm already somewhat unconfortable shutting up these gcc warnings at
all, since adding these annotations add one more thing that must be
maintained -- I feel it would be all-too-easy to change the logic of a
function in a way that introduces a bug, and then have the annotation
hide a "is used uninitialised" warning.

But I definitely feel we shouldn't make our object code even slightly
worse just to shut up the warnings.

 - R.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
  2006-10-05 10:05   ` Jeff Garzik
@ 2006-10-05 16:37   ` Adrian Bunk
  2006-10-05 16:44     ` Jeff Garzik
  1 sibling, 1 reply; 21+ messages in thread
From: Adrian Bunk @ 2006-10-05 16:37 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Jeff Garzik, linux-kernel, Andrew Morton

On Thu, Oct 05, 2006 at 10:37:54AM +0200, Ingo Molnar wrote:
> 
> * Andrew Morton <akpm@osdl.org> wrote:
> 
> > - Added Jeff's make-bogus-warnings-go-away tree to the -mm lineup, as
> >   git-gccbug.patch
> 
> Jeff: very nice! (I did this myself on a much smaller scale for the -rt 
> patch, because it's just so lethal if some serious warning gets lost in 
> the myriads of 'possible use of uninitialized' messages.)
> 
> A small suggestion: to give GCC folks a chance to actually fix this, 
> could we actively annotate these places instead of working them around?
> 
> I.e., instead of:
> 
>         long cursor = 0;
>         int error = 0;
> -       void *new_mc;
> +       void *new_mc = NULL;
>         int cpu;
>         cpumask_t old;
> 
> couldnt we do:
> 
> 	void *new_mc __GCC_WARN_BUG;
> 
> and then do something like this in gcc.h:
> 
>  #ifdef CONFIG_ELIMINATE_BOGUS_GCC_WARNINGS
>  # define __GCC_WARN_BUG = 0
>  #else
>  # define __GCC_WARN_BUG
>  #endif
> 
> this both gives an in-source incentive for GCC folks to get rid of these 
> bogus warnings (or remain shamed for eternity),

Not all of the false positives are gcc bugs.

There are cases where it's technically impossible for gcc to figure out 
that a variable is always initialized.

> and gives us the ability 
> to control the presence of these workarounds (and the eventual ability 
> to eliminate them in the future).
> 
> this would also mean we could merge your tree upstream without worrying 
> about hiding gcc bugs.

What we'd need would be some -Wno-may-be-used-uninitialized gcc option 
that turns off the "may be may be used uninitialized" warnings but not 
the "is used uninitialized" warnings.

This would:
- give us a way to silence these warnings
- allow people to see the warnings if they want to
- not increase the maintenance overhead

> 	Ingo

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-05 16:37   ` Adrian Bunk
@ 2006-10-05 16:44     ` Jeff Garzik
  2006-10-05 16:51       ` Adrian Bunk
  0 siblings, 1 reply; 21+ messages in thread
From: Jeff Garzik @ 2006-10-05 16:44 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Ingo Molnar, linux-kernel, Andrew Morton

Adrian Bunk wrote:
> What we'd need would be some -Wno-may-be-used-uninitialized gcc option 
> that turns off the "may be may be used uninitialized" warnings but not 
> the "is used uninitialized" warnings.
> 
> This would:
> - give us a way to silence these warnings
> - allow people to see the warnings if they want to
> - not increase the maintenance overhead


Some of those warnings do indicate real bugs.

	Jeff



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-05 16:44     ` Jeff Garzik
@ 2006-10-05 16:51       ` Adrian Bunk
  0 siblings, 0 replies; 21+ messages in thread
From: Adrian Bunk @ 2006-10-05 16:51 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Ingo Molnar, linux-kernel, Andrew Morton

On Thu, Oct 05, 2006 at 12:44:46PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >What we'd need would be some -Wno-may-be-used-uninitialized gcc option 
> >that turns off the "may be may be used uninitialized" warnings but not 
> >the "is used uninitialized" warnings.
> >
> >This would:
> >- give us a way to silence these warnings
> >- allow people to see the warnings if they want to
> >- not increase the maintenance overhead
> 
> Some of those warnings do indicate real bugs.

Some of the -Wmissing-prototypes warnings do also indicate real bugs.

But although I'm working on cleaning up the -Wmissing-prototypes 
warnings for a year or two, I doubt you'd be happy if we'd enable 
-Wmissing-prototypes now...

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
  2006-10-05 10:05   ` Jeff Garzik
  2006-10-05 16:21     ` make-bogus-warnings-go-away tree Roland Dreier
@ 2006-10-05 20:52     ` Kyle Moffett
  1 sibling, 0 replies; 21+ messages in thread
From: Kyle Moffett @ 2006-10-05 20:52 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Ingo Molnar, linux-kernel, Andrew Morton

On Oct 05, 2006, at 06:05:16, Jeff Garzik wrote:
> Ingo Molnar wrote:
>> A small suggestion: to give GCC folks a chance to actually fix  
>> this, could we actively annotate these places instead of working  
>> them around?
>
> There was a patch posted in the past, mentioned in the thread  
> discussed my #gccbug branch, that permitted annotations with zero  
> code size changes.  I think that sort of annotation approach would  
> be preferred. It was something like
>
> #define noinit_warning(x) \
> 	do { (void) (x) = (x); } while (0)
>
> but given my memory, that's probably all wrong.

The simplest way given the current GCC feature-set is:

   #ifdef HIDE_GCC_FALSE_POSITIVES
   # define correct_init(x) x = x
   #else
   # define correct_init(x) x
   #endif

Then:

   int correct_init(arg);
   struct some_struct correct_init(foo);

Alternatively if only some struct member has problems and the rest  
are OK:

   struct some_struct foo;
   correct_init(foo.bar);

Cheers,
Kyle Moffett


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [-mm PATCH] fixed PCMCIA au1000_generic.c
  2006-10-04 13:44 ` [-mm PATCH] fixed PCMCIA au1000_generic.c Yoichi Yuasa
@ 2006-10-06  6:18   ` Om Narasimhan
  2006-10-06  7:31     ` Yoichi Yuasa
  0 siblings, 1 reply; 21+ messages in thread
From: Om Narasimhan @ 2006-10-06  6:18 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: Andrew Morton, linux-kernel

On 10/4/06, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> Hi,
>
Sorry for the late reply.
> pcmcia-au1000_generic-fix.patch has a problem.
> It needs more fix.
> ops->shutdown(skt), skt is out of definition scope.

Is it so?
After applying the patch, the code would look like,
-----

		skt->status = au1x00_pcmcia_skt_state(skt);

		ret = pcmcia_register_socket(&skt->socket);
		if (ret)
			goto out_err;
<snip>

out_err:
	flush_scheduled_work();
	ops->hw_shutdown(skt);
	while (i-- > 0) {
		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
		del_timer_sync(&skt->poll_timer);
		pcmcia_unregister_socket(&skt->socket);
		flush_scheduled_work();
		ops->hw_shutdown(skt);
		i--;
	}
	kfree(sinfo);
-----
The  first call to ops->shutdown(skt) would free the skt (of the
function scope). The internal skt to the loop is a placeholder to call
shutdown().
Or did I miss any point?

Regards,
Om.
>
> Yoichi
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X linux-2.6.18-mm3/Documentation/dontdiff linux-2.6.18-mm3-orig/drivers/pcmcia/au1000_generic.c linux-2.6.18-mm3/drivers/pcmcia/au1000_generic.c
> --- linux-2.6.18-mm3-orig/drivers/pcmcia/au1000_generic.c       2006-10-04 11:24:33.017136250 +0900
> +++ linux-2.6.18-mm3/drivers/pcmcia/au1000_generic.c    2006-10-04 22:32:21.806060500 +0900
> @@ -351,6 +351,7 @@ struct skt_dev_info {
>  int au1x00_pcmcia_socket_probe(struct device *dev, struct pcmcia_low_level *ops, int first, int nr)
>  {
>         struct skt_dev_info *sinfo;
> +       struct au1000_pcmcia_socket *skt;
>         int ret, i;
>
>         sinfo = kzalloc(sizeof(struct skt_dev_info), GFP_KERNEL);
> @@ -365,7 +366,7 @@ int au1x00_pcmcia_socket_probe(struct de
>          * Initialise the per-socket structure.
>          */
>         for (i = 0; i < nr; i++) {
> -               struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
> +               skt = PCMCIA_SOCKET(i);
>                 memset(skt, 0, sizeof(*skt));
>
>                 skt->socket.resource_ops = &pccard_static_ops;
> @@ -442,7 +443,7 @@ out_err:
>         flush_scheduled_work();
>         ops->hw_shutdown(skt);
>         while (i-- > 0) {
> -               struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
> +               skt = PCMCIA_SOCKET(i);
>                 del_timer_sync(&skt->poll_timer);
>                 pcmcia_unregister_socket(&skt->socket);
>                 flush_scheduled_work();
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [-mm PATCH] fixed PCMCIA au1000_generic.c
  2006-10-06  6:18   ` Om Narasimhan
@ 2006-10-06  7:31     ` Yoichi Yuasa
  2006-10-07 22:31       ` Om Narasimhan
  0 siblings, 1 reply; 21+ messages in thread
From: Yoichi Yuasa @ 2006-10-06  7:31 UTC (permalink / raw)
  To: Om Narasimhan; +Cc: yoichi_yuasa, akpm, linux-kernel

On Thu, 5 Oct 2006 23:18:44 -0700
"Om Narasimhan" <om.turyx@gmail.com> wrote:

> On 10/4/06, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > Hi,
> >
> Sorry for the late reply.
> > pcmcia-au1000_generic-fix.patch has a problem.
> > It needs more fix.
> > ops->shutdown(skt), skt is out of definition scope.
> 
> Is it so?
> After applying the patch, the code would look like,
> -----
> 
> 		skt->status = au1x00_pcmcia_skt_state(skt);
> 
> 		ret = pcmcia_register_socket(&skt->socket);
> 		if (ret)
> 			goto out_err;
> <snip>
> 
> out_err:
> 	flush_scheduled_work();
> 	ops->hw_shutdown(skt);
> 	while (i-- > 0) {
> 		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
> 		del_timer_sync(&skt->poll_timer);
> 		pcmcia_unregister_socket(&skt->socket);
> 		flush_scheduled_work();
> 		ops->hw_shutdown(skt);
> 		i--;
> 	}
> 	kfree(sinfo);
> -----
> The  first call to ops->shutdown(skt) would free the skt (of the
> function scope). The internal skt to the loop is a placeholder to call
> shutdown().
> Or did I miss any point?


	for (i = 0; i < nr; i++) {
		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i); <-- 1st skt definition
<snip>
		ret = pcmcia_register_socket(&skt->socket);
		if (ret)
			goto out_err;

		WARN_ON(skt->socket.sock != i);

		add_timer(&skt->poll_timer);
	}
<snip>

out_err:
	flush_scheduled_work();
	ops->hw_shutdown(skt); <-- skt undeclared
	while (i-- > 0) {
		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i); <-- 2nd skt definition
		del_timer_sync(&skt->poll_timer);
		pcmcia_unregister_socket(&skt->socket);
		flush_scheduled_work();
		ops->hw_shutdown(skt);
	}

Yoichi

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [-mm PATCH] fixed PCMCIA au1000_generic.c
  2006-10-06  7:31     ` Yoichi Yuasa
@ 2006-10-07 22:31       ` Om Narasimhan
  0 siblings, 0 replies; 21+ messages in thread
From: Om Narasimhan @ 2006-10-07 22:31 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: akpm, linux-kernel

On 10/6/06, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> On Thu, 5 Oct 2006 23:18:44 -0700
> "Om Narasimhan" <om.turyx@gmail.com> wrote:
>
> > On 10/4/06, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > > Hi,
> > >
> > Sorry for the late reply.
> > > pcmcia-au1000_generic-fix.patch has a problem.
> > > It needs more fix.
>         for (i = 0; i < nr; i++) {
>                 struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i); <-- 1st skt definition
> <snip>
>                 ret = pcmcia_register_socket(&skt->socket);
>                 if (ret)
>                         goto out_err;
>
>                 WARN_ON(skt->socket.sock != i);
>
>                 add_timer(&skt->poll_timer);
>         }
> <snip>
>
> out_err:
>         flush_scheduled_work();
>         ops->hw_shutdown(skt); <-- skt undeclared
I am sorry. I did not find this.
Please find the corrected patch.
Applies cleanly to 2.6.18-rc6, rc7, 2.6.18, and 2.6.19-rc1
Regards,
Om.


 drivers/pcmcia/au1000_generic.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/pcmcia/au1000_generic.c b/drivers/pcmcia/au1000_generic.c
index d5dd0ce..5387de6 100644
--- a/drivers/pcmcia/au1000_generic.c
+++ b/drivers/pcmcia/au1000_generic.c
@@ -351,6 +351,7 @@ struct skt_dev_info {
 int au1x00_pcmcia_socket_probe(struct device *dev, struct
pcmcia_low_level *ops, int first, int nr)
 {
 	struct skt_dev_info *sinfo;
+	struct au1000_pcmcia_socket *skt;
 	int ret, i;

 	sinfo = kzalloc(sizeof(struct skt_dev_info), GFP_KERNEL);
@@ -365,7 +366,7 @@ int au1x00_pcmcia_socket_probe(struct de
 	 * Initialise the per-socket structure.
 	 */
 	for (i = 0; i < nr; i++) {
-		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
+		skt = PCMCIA_SOCKET(i);
 		memset(skt, 0, sizeof(*skt));

 		skt->socket.resource_ops = &pccard_static_ops;
@@ -438,17 +439,19 @@ #endif
 	dev_set_drvdata(dev, sinfo);
 	return 0;

-	do {
-		struct au1000_pcmcia_socket *skt = PCMCIA_SOCKET(i);
+
+out_err:
+	flush_scheduled_work();
+	ops->hw_shutdown(skt);
+	while (i-- > 0) {
+		skt = PCMCIA_SOCKET(i);

 		del_timer_sync(&skt->poll_timer);
 		pcmcia_unregister_socket(&skt->socket);
-out_err:
 		flush_scheduled_work();
 		ops->hw_shutdown(skt);

-		i--;
-	} while (i > 0);
+	}
 	kfree(sinfo);
 out:
 	return ret;

^ permalink raw reply related	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2006-10-07 22:31 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-03  7:11 2.6.18-mm3 Andrew Morton
2006-10-03 14:33 ` 2.6.18-mm3 Michal Piotrowski
2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:01   ` 2.6.18-mm3 Andrew Morton
2006-10-03 18:16     ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:05   ` 2.6.18-mm3 Badari Pulavarty
2006-10-04 13:44 ` [-mm PATCH] fixed PCMCIA au1000_generic.c Yoichi Yuasa
2006-10-06  6:18   ` Om Narasimhan
2006-10-06  7:31     ` Yoichi Yuasa
2006-10-07 22:31       ` Om Narasimhan
2006-10-04 15:14 ` 2.6.18-mm3 oops in xfrm_register_mode Steve Fox
2006-10-04 16:57   ` Andrew Morton
2006-10-04 21:02     ` Steve Fox
2006-10-05 15:06       ` Badari Pulavarty
2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
2006-10-05 10:05   ` Jeff Garzik
2006-10-05 16:21     ` make-bogus-warnings-go-away tree Roland Dreier
2006-10-05 20:52     ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Kyle Moffett
2006-10-05 16:37   ` Adrian Bunk
2006-10-05 16:44     ` Jeff Garzik
2006-10-05 16:51       ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox