* [PATCH] libata: Don't believe bogus claims in the older PIO mode register
@ 2006-09-29 17:26 Alan Cox
2006-10-05 10:55 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2006-09-29 17:26 UTC (permalink / raw)
To: jgarzik, linux-kernel
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c linux-2.6.18-mm2/drivers/ata/libata-core.c
--- linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c 2006-09-28 14:33:46.000000000 +0100
+++ linux-2.6.18-mm2/drivers/ata/libata-core.c 2006-09-29 17:33:53.000000000 +0100
@@ -870,7 +870,11 @@
* the PIO timing number for the maximum. Turn it into
* a mask.
*/
- pio_mask = (2 << (id[ATA_ID_OLD_PIO_MODES] & 0xFF)) - 1 ;
+ u8 mode = id[ATA_ID_OLD_PIO_MODES] & 0xFF;
+ if( mode < 5) /* Valid PIO range */
+ pio_mask = (2 << mode) - 1 ;
+ else
+ pio_mask = 1;
/* But wait.. there's more. Design your standards by
* committee and you too can get a free iordy field to
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: Don't believe bogus claims in the older PIO mode register
2006-09-29 17:26 [PATCH] libata: Don't believe bogus claims in the older PIO mode register Alan Cox
@ 2006-10-05 10:55 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-10-05 10:55 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel
Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c linux-2.6.18-mm2/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.18-mm2/drivers/ata/libata-core.c 2006-09-28 14:33:46.000000000 +0100
> +++ linux-2.6.18-mm2/drivers/ata/libata-core.c 2006-09-29 17:33:53.000000000 +0100
> @@ -870,7 +870,11 @@
> * the PIO timing number for the maximum. Turn it into
> * a mask.
> */
> - pio_mask = (2 << (id[ATA_ID_OLD_PIO_MODES] & 0xFF)) - 1 ;
> + u8 mode = id[ATA_ID_OLD_PIO_MODES] & 0xFF;
> + if( mode < 5) /* Valid PIO range */
> + pio_mask = (2 << mode) - 1 ;
> + else
> + pio_mask = 1;
applied to #upstream-fixes, after fixing up stuff like "if( "
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-05 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-29 17:26 [PATCH] libata: Don't believe bogus claims in the older PIO mode register Alan Cox
2006-10-05 10:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox