public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Helge Hafting <helge.hafting@aitel.hist.no>
To: Vadim Lobanov <vlobanov@speakeasy.net>
Cc: Andrew Morton <akpm@osdl.org>, Matthew Wilcox <matthew@wil.cx>,
	linux-kernel@vger.kernel.org
Subject: Re: Must check what?
Date: Thu, 05 Oct 2006 15:20:34 +0200	[thread overview]
Message-ID: <452506A2.2020103@aitel.hist.no> (raw)
In-Reply-To: <200610041358.36515.vlobanov@speakeasy.net>

Vadim Lobanov wrote:
> On Wednesday 04 October 2006 12:43, Andrew Morton wrote:
>   
>> I like assertions personally.  If we had something like:
>>
>> void foo(args)
>> {
>> 	locals;
>>
>> 	assert_irqs_enabled();
>> 	assert_spin_locked(some_lock);
>> 	assert_in_atomic();
>> 	assert_mutex_locked(some_mutex);
>>
>> then we get documentation which is (optionally) checked at runtime - best
>> of both worlds.  Better than doing it in kernel-doc.  Automatically
>> self-updating (otherwise kernels go BUG).
>>     
>
> Uhoh! How much is that going to hurt runtime? :) It actually seems to me like 
> this should be doable by static code analysis tools without terribly much 
> pain (in the relative sense of the term). Or am I wrong on this thought?
>   
Surely, any debugging that hurts will only really be there
if you enable CONFIG_DEBUG_something

The kind of stuff you ask people to turn on when they report
strange crashes.

Helge Hafting

  reply	other threads:[~2006-10-05 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-04 18:37 Must check what? Matthew Wilcox
2006-10-04 19:02 ` Andrew Morton
2006-10-04 19:25   ` Matthew Wilcox
2006-10-04 19:43     ` Andrew Morton
2006-10-04 20:58       ` Vadim Lobanov
2006-10-05 13:20         ` Helge Hafting [this message]
2006-10-05  3:47       ` Kyle Moffett
2006-10-04 19:50     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452506A2.2020103@aitel.hist.no \
    --to=helge.hafting@aitel.hist.no \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=vlobanov@speakeasy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox