From: Pierre Ossman <drzeus-list@drzeus.cx>
To: philipl@alumni.utexas.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18 2/2] mmc: Read mmc v4 EXT_CSD
Date: Thu, 05 Oct 2006 17:56:02 +0200 [thread overview]
Message-ID: <45252B12.9010206@drzeus.cx> (raw)
In-Reply-To: <45232302.1050007@overt.org>
Philip Langdale wrote:
> Pierre,
>
> I will reorganise these patches into a series that detects and sets up
> high-speed support. This is pretty simple. Wide-bus is harder because
> you have to run their weird test pattern and check all the power class
> stuff. Hopefully I'll have that done this week.
>
Goodie. Have these patches seen any wide spread testing?
> Pierre Ossman wrote:
>
>> philipl@overt.org wrote:
>>
>>> + list_for_each_entry(card, &host->cards, node) {
>>> + if (card->state & (MMC_STATE_DEAD|MMC_STATE_PRESENT))
>>> + continue;
>>>
>>>
>> Please use the macros.
>>
>
> I'm confused: mmc_read_scrs and mmc_read_csds use this exact same
> construction in 2.6.18 and Linus' current tree. Should I be checking
> another tree?
>
>
Nah, they're also wrong. Patches welcome ;)
Rgds
Pierre
next prev parent reply other threads:[~2006-10-05 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 23:21 [PATCH 2.6.18 2/2] mmc: Read mmc v4 EXT_CSD philipl
2006-10-03 17:50 ` Pierre Ossman
2006-10-04 2:57 ` Philip Langdale
2006-10-05 15:56 ` Pierre Ossman [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-06 8:53 Frantisek Dufka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45252B12.9010206@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@alumni.utexas.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox