Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

Jeff Garzik
2006-10-06T14:16:26Z

Dmitry Torokhov wrote:
> On 10/6/06, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> * Jeff Garzik <jeff@garzik.org> wrote:
>>
>> > >but pt_regs is alot less frequently used than irq - and where it's
>> > >used they arent "drivers" but mostly arch level code like hw-timer
>> > >handlers.
>> >
>> > Nonetheless the -vast majority- of drivers don't use the argument at
>> > all, and the minority that do use it are not modern drivers.
>>
>> i'm all for changing that too :)
>>
>
> What drivers use irq argument? I know i8042 does but only to detect
> whether interrupt routine was called because irq was raised or it was
> called manually and I can use dev_id for that...

Ancient ISA legacys, a few powermac drivers, and a lot of printk's.
Your gut instinct is correct -- outside of printk, it is largely used to
differentiate callers.

Jeff