Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

Andrew Morton
2006-10-05T19:47:00Z

On Thu, 05 Oct 2006 15:22:07 +0100
David Howells <dhowells@redhat.com> wrote:

> Andrew Morton <akpm@osdl.org> wrote:
>
> > These should just use __get_cpu_var().
>
> Done.
>
> > And could we please remove the irq_regs macro?
>
> Done.
>
> > I think the change is good. But I don't want to maintain this whopper
> > out-of-tree for two months! If we want to do this, we should just smash it
> > in and grit our teeth. But I am a bit concerned about the non-x86
> > architectures. I assume they'll continue to compile-and-work?
>
> Well, it seems that IA64 and MIPS don't build as of 2.6.19-rc1 without my
> having to do anything. i386, x86_64, powerpc and frv build for at least one
> configuration each. The other archs I haven't touched, so will definitely
> break.
>
> Can those arch maintainers give me patches?
>
>
> Anyway, I've made a GIT tree with just IRQ my patches in. It can be browsed
> at:
>
> http://git.infradead.org/?p=users/dhowells/irq-2.6.git;a=shortlog
>
> Or pulled from:
>
> git://git.infradead.org/~dhowells/irq-2.6.git
>
> David
>
> ---
> The following changes since commit d223a60106891bfe46febfacf46b20cd8509aaad:
> Linus Torvalds:
> Linux 2.6.19-rc1
>
> are found in the git repository at:
>
> git://git.infradead.org/~dhowells/irq-2.6.git
>

A quick survey of the wreckage:

- Dmitry's input git tree breaks a bit

- five of Greg's USB patches need fixing

- a few random -mm patches need touchups

- The hrtimer+dynticks i386 patch takes rather a hit and will need redoing.

So, not too bad at all. It's a bit rough on the poor old arch maintainers,
but it's pretty simple stuff.

I'd say let's do it...