Re: [PATCH] fix mesh compile errors after irq changes

Geert Uytterhoeven
2006-10-06T19:10:31Z

On Fri, 6 Oct 2006, Olaf Hering wrote:
> drivers/scsi/mesh.c:469: error: too many arguments to function 'mesh_interrupt'
> drivers/scsi/mesh.c:507: error: too many arguments to function 'mesh_interrupt'
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> ---
> drivers/scsi/mesh.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/scsi/mesh.c
> ===================================================================
> --- linux-2.6.orig/drivers/scsi/mesh.c
> +++ linux-2.6/drivers/scsi/mesh.c
> @@ -466,7 +466,7 @@ static void mesh_start_cmd(struct mesh_s
> dlog(ms, "intr b4 arb, intr/exc/err/fc=%.8x",
> MKWORD(mr->interrupt, mr->exception,
> mr->error, mr->fifo_count));
> - mesh_interrupt(0, (void *)ms, NULL);
> + mesh_interrupt(0, (void *)ms);
^^^^^^^^
> if (ms->phase != arbitrating)
> return;
> }
> @@ -504,7 +504,7 @@ static void mesh_start_cmd(struct mesh_s
> dlog(ms, "intr after disresel, intr/exc/err/fc=%.8x",
> MKWORD(mr->interrupt, mr->exception,
> mr->error, mr->fifo_count));
> - mesh_interrupt(0, (void *)ms, NULL);
> + mesh_interrupt(0, (void *)ms);
^^^^^^^^
These casts are superfluous, right?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds