From: Evgeniy Polyakov <zbr@ioremap.net>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1: fix timeout_us parameter description
Date: Wed, 10 Aug 2016 23:00:35 +0300 [thread overview]
Message-ID: <452831470859235@web16g.yandex.ru> (raw)
In-Reply-To: <ee76ece2-5852-4f22-9b99-1a6842bd6ee5@gmail.com>
Hi
10.08.2016, 06:22, "Wei Yongjun" <weiyj.lk@gmail.com>:
>> 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>:
>>> Fix 'timeout_us' parameter description.
>>> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
>>> module_param_named(timeout_us, w1_timeout_us, int, 0);
>>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>>> - " searches");
>>> +MODULE_PARM_DESC(timeout_us,
>>> + "time in microseconds between automatic slave searches");
>> I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
>
> Maybe the bad patch description confused you, this patch the typo in the
> first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.
Yup, you are right, please make it as one line since you are at it
next prev parent reply other threads:[~2016-08-10 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 13:52 [PATCH] w1: fix timeout_us parameter description Wei Yongjun
2016-08-09 22:54 ` Evgeniy Polyakov
2016-08-10 3:22 ` Wei Yongjun
2016-08-10 20:00 ` Evgeniy Polyakov [this message]
2016-08-11 0:03 ` [PATCH v2] w1: fix typo in " Wei Yongjun
2016-08-12 10:27 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452831470859235@web16g.yandex.ru \
--to=zbr@ioremap.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox