* iop32x: gpio breakage after "instantiate GPIO from platform device"
@ 2014-01-28 21:05 Arnd Bergmann
2014-01-29 12:41 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2014-01-28 21:05 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-arm-kernel, linux-kernel
Commit 7b85b867b9904 "ARM: plat-iop: instantiate GPIO from platform
device" nicely cleaned up the gpio register access for iop, but
forgot one board that directly pokes into the gpio registers
to do a system reset.
That board no longer compiles, and this patch just disables
the code in question to work around it so I can locally build
randconfig again, but it needs to be fixed properly.
diff --git a/arch/arm/mach-iop32x/em7210.c b/arch/arm/mach-iop32x/em7210.c
index 177cd07..f3cb8e1 100644
--- a/arch/arm/mach-iop32x/em7210.c
+++ b/arch/arm/mach-iop32x/em7210.c
@@ -178,8 +178,10 @@ static struct platform_device em7210_serial_device = {
void em7210_power_off(void)
{
+#if 0
*IOP3XX_GPOE &= 0xfe;
*IOP3XX_GPOD |= 0x01;
+#endif
}
static void __init em7210_init_machine(void)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: iop32x: gpio breakage after "instantiate GPIO from platform device"
2014-01-28 21:05 iop32x: gpio breakage after "instantiate GPIO from platform device" Arnd Bergmann
@ 2014-01-29 12:41 ` Linus Walleij
2014-01-29 12:45 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2014-01-29 12:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Tue, Jan 28, 2014 at 10:05 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Commit 7b85b867b9904 "ARM: plat-iop: instantiate GPIO from platform
> device" nicely cleaned up the gpio register access for iop, but
> forgot one board that directly pokes into the gpio registers
> to do a system reset.
>
> That board no longer compiles, and this patch just disables
> the code in question to work around it so I can locally build
> randconfig again, but it needs to be fixed properly.
OK I'm sending a proper fix instead.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: iop32x: gpio breakage after "instantiate GPIO from platform device"
2014-01-29 12:41 ` Linus Walleij
@ 2014-01-29 12:45 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-01-29 12:45 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Linus Walleij, linux-kernel@vger.kernel.org
On Wednesday 29 January 2014 13:41:59 Linus Walleij wrote:
> On Tue, Jan 28, 2014 at 10:05 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > Commit 7b85b867b9904 "ARM: plat-iop: instantiate GPIO from platform
> > device" nicely cleaned up the gpio register access for iop, but
> > forgot one board that directly pokes into the gpio registers
> > to do a system reset.
> >
> > That board no longer compiles, and this patch just disables
> > the code in question to work around it so I can locally build
> > randconfig again, but it needs to be fixed properly.
>
> OK I'm sending a proper fix instead.
Ok, thanks!
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-29 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 21:05 iop32x: gpio breakage after "instantiate GPIO from platform device" Arnd Bergmann
2014-01-29 12:41 ` Linus Walleij
2014-01-29 12:45 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox