Re: [PATCH 2.6.19-rc1] drivers/media/dvb/bt8xx/dvb-bt8xx.c: check kmalloc() return value.

Olaf Hering
2006-10-09T08:37:26Z

On Sun, Oct 08, Amit Choudhary wrote:

> Description: Check the return value of kmalloc() in function frontend_init(), in file drivers/media/dvb/bt8xx/dvb-bt8xx.c.
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>
> diff --git a/drivers/media/dvb/bt8xx/dvb-bt8xx.c b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
> index fb6c4cc..14e69a7 100644
> --- a/drivers/media/dvb/bt8xx/dvb-bt8xx.c
> +++ b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
> @@ -665,6 +665,10 @@ static void frontend_init(struct dvb_bt8
> case BTTV_BOARD_TWINHAN_DST:
> /* DST is not a frontend driver !!! */
> state = (struct dst_state *) kmalloc(sizeof (struct dst_state), GFP_KERNEL);
> + if (!state) {
> + printk("dvb_bt8xx: No memory\n");

KERN_FOO loglevel is missing.