* [PATCH] firewire: handle sysfs errors
@ 2006-10-10 6:48 Jeff Garzik
2006-10-10 8:38 ` Stefan Richter
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2006-10-10 6:48 UTC (permalink / raw)
To: bcollins, stefanr, Andrew Morton, LKML
Handle sysfs, driver core errors.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
drivers/ieee1394/nodemgr.c | 36 ++++++++++++++++++++++++++++--------
diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
index 8e7b83f..8628e3f 100644
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -414,9 +414,11 @@ static BUS_ATTR(destroy_node, S_IWUSR |
static ssize_t fw_set_rescan(struct bus_type *bus, const char *buf, size_t count)
{
+ int rc;
+
if (simple_strtoul(buf, NULL, 10) == 1)
- bus_rescan_devices(&ieee1394_bus_type);
- return count;
+ rc = bus_rescan_devices(&ieee1394_bus_type);
+ return rc < 0 ? rc : count;
}
static ssize_t fw_get_rescan(struct bus_type *bus, char *buf)
{
@@ -576,13 +578,23 @@ static struct driver_attribute *const fw
};
-static void nodemgr_create_drv_files(struct hpsb_protocol_driver *driver)
+static int nodemgr_create_drv_files(struct hpsb_protocol_driver *driver)
{
struct device_driver *drv = &driver->driver;
- int i;
+ int i, j, rc;
- for (i = 0; i < ARRAY_SIZE(fw_drv_attrs); i++)
- driver_create_file(drv, fw_drv_attrs[i]);
+ for (i = 0; i < ARRAY_SIZE(fw_drv_attrs); i++) {
+ rc = driver_create_file(drv, fw_drv_attrs[i]);
+ if (rc)
+ goto err_out;
+ }
+
+ return 0;
+
+err_out:
+ for (j = 0; j < i; j++)
+ driver_remove_file(drv, fw_drv_attrs[j]);
+ return rc;
}
@@ -1166,9 +1178,17 @@ int hpsb_register_protocol(struct hpsb_p
/* This will cause a probe for devices */
ret = driver_register(&driver->driver);
- if (!ret)
- nodemgr_create_drv_files(driver);
+ if (ret)
+ return ret;
+
+ ret = nodemgr_create_drv_files(driver);
+ if (ret)
+ goto err_out;
+
+ return 0;
+err_out:
+ driver_unregister(&driver->driver);
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] firewire: handle sysfs errors
2006-10-10 6:48 [PATCH] firewire: handle sysfs errors Jeff Garzik
@ 2006-10-10 8:38 ` Stefan Richter
2006-10-10 12:52 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Richter @ 2006-10-10 8:38 UTC (permalink / raw)
To: Jeff Garzik; +Cc: bcollins, Andrew Morton, LKML
Jeff Garzik wrote:
> Handle sysfs, driver core errors.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> ---
>
> drivers/ieee1394/nodemgr.c | 36 ++++++++++++++++++++++++++++--------
>
> diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
> index 8e7b83f..8628e3f 100644
> --- a/drivers/ieee1394/nodemgr.c
> +++ b/drivers/ieee1394/nodemgr.c
> @@ -414,9 +414,11 @@ static BUS_ATTR(destroy_node, S_IWUSR |
>
> static ssize_t fw_set_rescan(struct bus_type *bus, const char *buf, size_t count)
> {
> + int rc;
> +
> if (simple_strtoul(buf, NULL, 10) == 1)
> - bus_rescan_devices(&ieee1394_bus_type);
> - return count;
> + rc = bus_rescan_devices(&ieee1394_bus_type);
> + return rc < 0 ? rc : count;
> }
gcc 3.4.1-4mdk says:
drivers/ieee1394/nodemgr.c: In function `fw_set_rescan':
drivers/ieee1394/nodemgr.c:417: warning: 'rc' might be used
uninitialized in this function
The rest of the patch looks OK.
I get a lot more warn_unused_result warnings at other places in
ieee1394/nodemgr.c and ieee1394/hosts.c though. I could fix them all up
and fix this new warning in fw_set_rescan too if you don't mind...
--
Stefan Richter
-=====-=-==- =-=- -=-=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firewire: handle sysfs errors
2006-10-10 8:38 ` Stefan Richter
@ 2006-10-10 12:52 ` Jeff Garzik
2006-10-10 19:11 ` [PATCH 2.6.19-rc1 1/3] ieee1394: lock smaller region by host_num_alloc mutex Stefan Richter
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2006-10-10 12:52 UTC (permalink / raw)
To: Stefan Richter; +Cc: bcollins, Andrew Morton, LKML
Stefan Richter wrote:
> drivers/ieee1394/nodemgr.c: In function `fw_set_rescan':
> drivers/ieee1394/nodemgr.c:417: warning: 'rc' might be used
> uninitialized in this function
>
> The rest of the patch looks OK.
shoops, sorry
> I get a lot more warn_unused_result warnings at other places in
> ieee1394/nodemgr.c and ieee1394/hosts.c though. I could fix them all up
> and fix this new warning in fw_set_rescan too if you don't mind...
That would be fantastic...
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2.6.19-rc1 1/3] ieee1394: lock smaller region by host_num_alloc mutex
2006-10-10 12:52 ` Jeff Garzik
@ 2006-10-10 19:11 ` Stefan Richter
2006-10-10 19:12 ` [PATCH 2.6.19-rc1 2/3] ieee1394: coding style in hosts.c Stefan Richter
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Richter @ 2006-10-10 19:11 UTC (permalink / raw)
To: linux1394-devel; +Cc: Jeff Garzik, linux-kernel
We need the mutex only around the iteration over existing hosts.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
This prepares hosts.c for the following patch which adds checks of
driver core errors.
Index: linux-2.6.19-rc1/drivers/ieee1394/hosts.c
===================================================================
--- linux-2.6.19-rc1.orig/drivers/ieee1394/hosts.c 2006-10-10 19:06:06.000000000 +0200
+++ linux-2.6.19-rc1/drivers/ieee1394/hosts.c 2006-10-10 19:07:36.000000000 +0200
@@ -156,10 +156,9 @@ struct hpsb_host *hpsb_alloc_host(struct
h->speed_map = (u8 *)(h->csr.speed_map + 2);
mutex_lock(&host_num_alloc);
-
while (nodemgr_for_each_host(&hostnum, alloc_hostnum_cb))
hostnum++;
-
+ mutex_unlock(&host_num_alloc);
h->id = hostnum;
memcpy(&h->device, &nodemgr_dev_template_host, sizeof(h->device));
@@ -174,8 +173,6 @@ struct hpsb_host *hpsb_alloc_host(struct
class_device_register(&h->class_dev);
get_device(&h->device);
- mutex_unlock(&host_num_alloc);
-
return h;
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2.6.19-rc1 2/3] ieee1394: coding style in hosts.c
2006-10-10 19:11 ` [PATCH 2.6.19-rc1 1/3] ieee1394: lock smaller region by host_num_alloc mutex Stefan Richter
@ 2006-10-10 19:12 ` Stefan Richter
2006-10-10 19:19 ` [PATCH 2.6.19-rc1 3/3] ieee1394: handle sysfs errors Stefan Richter
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Richter @ 2006-10-10 19:12 UTC (permalink / raw)
To: linux1394-devel; +Cc: Jeff Garzik, linux-kernel
Some 80-columns pedantry, and touch up of a // comment.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux-2.6.19-rc1/drivers/ieee1394/hosts.c
===================================================================
--- linux-2.6.19-rc1.orig/drivers/ieee1394/hosts.c 2006-10-10 19:07:36.000000000 +0200
+++ linux-2.6.19-rc1/drivers/ieee1394/hosts.c 2006-10-10 19:31:37.000000000 +0200
@@ -43,9 +43,10 @@ static void delayed_reset_bus(void * __r
CSR_SET_BUS_INFO_GENERATION(host->csr.rom, generation);
if (csr1212_generate_csr_image(host->csr.rom) != CSR1212_SUCCESS) {
- /* CSR image creation failed, reset generation field and do not
- * issue a bus reset. */
- CSR_SET_BUS_INFO_GENERATION(host->csr.rom, host->csr.generation);
+ /* CSR image creation failed.
+ * Reset generation field and do not issue a bus reset. */
+ CSR_SET_BUS_INFO_GENERATION(host->csr.rom,
+ host->csr.generation);
return;
}
@@ -53,7 +54,8 @@ static void delayed_reset_bus(void * __r
host->update_config_rom = 0;
if (host->driver->set_hw_config_rom)
- host->driver->set_hw_config_rom(host, host->csr.rom->bus_info_data);
+ host->driver->set_hw_config_rom(host,
+ host->csr.rom->bus_info_data);
host->csr.gen_timestamp[host->csr.generation] = jiffies;
hpsb_reset_bus(host, SHORT_RESET);
@@ -69,7 +71,8 @@ static int dummy_devctl(struct hpsb_host
return -1;
}
-static int dummy_isoctl(struct hpsb_iso *iso, enum isoctl_cmd command, unsigned long arg)
+static int dummy_isoctl(struct hpsb_iso *iso, enum isoctl_cmd command,
+ unsigned long arg)
{
return -1;
}
@@ -150,7 +151,7 @@ struct hpsb_host *hpsb_alloc_host(struct
init_timer(&h->timeout);
h->timeout.data = (unsigned long) h;
h->timeout.function = abort_timedouts;
- h->timeout_interval = HZ / 20; // 50ms by default
+ h->timeout_interval = HZ / 20; /* 50ms, half of minimum SPLIT_TIMEOUT */
h->topology_map = h->csr.topology_map + 3;
h->speed_map = (u8 *)(h->csr.speed_map + 2);
@@ -225,7 +240,8 @@ int hpsb_update_config_rom_image(struct
if (time_before(jiffies, host->csr.gen_timestamp[next_gen] + 60 * HZ))
/* Wait 60 seconds from the last time this generation number was
* used. */
- reset_delay = (60 * HZ) + host->csr.gen_timestamp[next_gen] - jiffies;
+ reset_delay =
+ (60 * HZ) + host->csr.gen_timestamp[next_gen] - jiffies;
else
/* Wait 1 second in case some other code wants to change the
* Config ROM in the near future. */
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2.6.19-rc1 3/3] ieee1394: handle sysfs errors
2006-10-10 19:12 ` [PATCH 2.6.19-rc1 2/3] ieee1394: coding style in hosts.c Stefan Richter
@ 2006-10-10 19:19 ` Stefan Richter
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Richter @ 2006-10-10 19:19 UTC (permalink / raw)
To: linux1394-devel; +Cc: Jeff Garzik, linux-kernel
Handle driver core errors with as much care as appropriate.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Supersedes patch "firewire: handle sysfs errors" by Jeff Garzik,
posted on from 2006-10-10.
drivers/ieee1394/hosts.c | 18 ++--
drivers/ieee1394/nodemgr.c | 149 ++++++++++++++++++++++++++-----------
2 files changed, 118 insertions(+), 49 deletions(-)
Index: linux-2.6.19-rc1/drivers/ieee1394/hosts.c
===================================================================
--- linux-2.6.19-rc1.orig/drivers/ieee1394/hosts.c 2006-10-10 19:33:51.000000000 +0200
+++ linux-2.6.19-rc1/drivers/ieee1394/hosts.c 2006-10-10 21:16:11.000000000 +0200
@@ -130,10 +130,8 @@ struct hpsb_host *hpsb_alloc_host(struct
return NULL;
h->csr.rom = csr1212_create_csr(&csr_bus_ops, CSR_BUS_INFO_SIZE, h);
- if (!h->csr.rom) {
- kfree(h);
- return NULL;
- }
+ if (!h->csr.rom)
+ goto fail;
h->hostdata = h + 1;
h->driver = drv;
@@ -172,11 +170,19 @@ struct hpsb_host *hpsb_alloc_host(struct
h->class_dev.class = &hpsb_host_class;
snprintf(h->class_dev.class_id, BUS_ID_SIZE, "fw-host%d", h->id);
- device_register(&h->device);
- class_device_register(&h->class_dev);
+ if (device_register(&h->device))
+ goto fail;
+ if (class_device_register(&h->class_dev)) {
+ device_unregister(&h->device);
+ goto fail;
+ }
get_device(&h->device);
return h;
+
+fail:
+ kfree(h);
+ return NULL;
}
int hpsb_add_host(struct hpsb_host *host)
Index: linux-2.6.19-rc1/drivers/ieee1394/nodemgr.c
===================================================================
--- linux-2.6.19-rc1.orig/drivers/ieee1394/nodemgr.c 2006-10-10 19:05:51.000000000 +0200
+++ linux-2.6.19-rc1/drivers/ieee1394/nodemgr.c 2006-10-10 21:02:51.000000000 +0200
@@ -412,11 +412,14 @@ static ssize_t fw_get_destroy_node(struc
static BUS_ATTR(destroy_node, S_IWUSR | S_IRUGO, fw_get_destroy_node, fw_set_destroy_node);
-static ssize_t fw_set_rescan(struct bus_type *bus, const char *buf, size_t count)
+static ssize_t fw_set_rescan(struct bus_type *bus, const char *buf,
+ size_t count)
{
+ int error = 0;
+
if (simple_strtoul(buf, NULL, 10) == 1)
- bus_rescan_devices(&ieee1394_bus_type);
- return count;
+ error = bus_rescan_devices(&ieee1394_bus_type);
+ return error ? error : count;
}
static ssize_t fw_get_rescan(struct bus_type *bus, char *buf)
{
@@ -582,7 +585,11 @@ static void nodemgr_create_drv_files(str
int i;
for (i = 0; i < ARRAY_SIZE(fw_drv_attrs); i++)
- driver_create_file(drv, fw_drv_attrs[i]);
+ if (driver_create_file(drv, fw_drv_attrs[i]))
+ goto fail;
+ return;
+fail:
+ HPSB_ERR("Failed to add sysfs attribute for driver %s", driver->name);
}
@@ -602,7 +609,12 @@ static void nodemgr_create_ne_dev_files(
int i;
for (i = 0; i < ARRAY_SIZE(fw_ne_attrs); i++)
- device_create_file(dev, fw_ne_attrs[i]);
+ if (device_create_file(dev, fw_ne_attrs[i]))
+ goto fail;
+ return;
+fail:
+ HPSB_ERR("Failed to add sysfs attribute for node %016Lx",
+ (unsigned long long)ne->guid);
}
@@ -612,11 +624,16 @@ static void nodemgr_create_host_dev_file
int i;
for (i = 0; i < ARRAY_SIZE(fw_host_attrs); i++)
- device_create_file(dev, fw_host_attrs[i]);
+ if (device_create_file(dev, fw_host_attrs[i]))
+ goto fail;
+ return;
+fail:
+ HPSB_ERR("Failed to add sysfs attribute for host %d", host->id);
}
-static struct node_entry *find_entry_by_nodeid(struct hpsb_host *host, nodeid_t nodeid);
+static struct node_entry *find_entry_by_nodeid(struct hpsb_host *host,
+ nodeid_t nodeid);
static void nodemgr_update_host_dev_links(struct hpsb_host *host)
{
@@ -627,12 +644,18 @@ static void nodemgr_update_host_dev_link
sysfs_remove_link(&dev->kobj, "busmgr_id");
sysfs_remove_link(&dev->kobj, "host_id");
- if ((ne = find_entry_by_nodeid(host, host->irm_id)))
- sysfs_create_link(&dev->kobj, &ne->device.kobj, "irm_id");
- if ((ne = find_entry_by_nodeid(host, host->busmgr_id)))
- sysfs_create_link(&dev->kobj, &ne->device.kobj, "busmgr_id");
- if ((ne = find_entry_by_nodeid(host, host->node_id)))
- sysfs_create_link(&dev->kobj, &ne->device.kobj, "host_id");
+ if ((ne = find_entry_by_nodeid(host, host->irm_id)) &&
+ sysfs_create_link(&dev->kobj, &ne->device.kobj, "irm_id"))
+ goto fail;
+ if ((ne = find_entry_by_nodeid(host, host->busmgr_id)) &&
+ sysfs_create_link(&dev->kobj, &ne->device.kobj, "busmgr_id"))
+ goto fail;
+ if ((ne = find_entry_by_nodeid(host, host->node_id)) &&
+ sysfs_create_link(&dev->kobj, &ne->device.kobj, "host_id"))
+ goto fail;
+ return;
+fail:
+ HPSB_ERR("Failed to update sysfs attributes for host %d", host->id);
}
static void nodemgr_create_ud_dev_files(struct unit_directory *ud)
@@ -641,25 +664,32 @@ static void nodemgr_create_ud_dev_files(
int i;
for (i = 0; i < ARRAY_SIZE(fw_ud_attrs); i++)
- device_create_file(dev, fw_ud_attrs[i]);
-
+ if (device_create_file(dev, fw_ud_attrs[i]))
+ goto fail;
if (ud->flags & UNIT_DIRECTORY_SPECIFIER_ID)
- device_create_file(dev, &dev_attr_ud_specifier_id);
-
+ if (device_create_file(dev, &dev_attr_ud_specifier_id))
+ goto fail;
if (ud->flags & UNIT_DIRECTORY_VERSION)
- device_create_file(dev, &dev_attr_ud_version);
-
+ if (device_create_file(dev, &dev_attr_ud_version))
+ goto fail;
if (ud->flags & UNIT_DIRECTORY_VENDOR_ID) {
- device_create_file(dev, &dev_attr_ud_vendor_id);
- if (ud->vendor_name_kv)
- device_create_file(dev, &dev_attr_ud_vendor_name_kv);
+ if (device_create_file(dev, &dev_attr_ud_vendor_id))
+ goto fail;
+ if (ud->vendor_name_kv &&
+ device_create_file(dev, &dev_attr_ud_vendor_name_kv))
+ goto fail;
}
-
if (ud->flags & UNIT_DIRECTORY_MODEL_ID) {
- device_create_file(dev, &dev_attr_ud_model_id);
- if (ud->model_name_kv)
- device_create_file(dev, &dev_attr_ud_model_name_kv);
+ if (device_create_file(dev, &dev_attr_ud_model_id))
+ goto fail;
+ if (ud->model_name_kv &&
+ device_create_file(dev, &dev_attr_ud_model_name_kv))
+ goto fail;
}
+ return;
+fail:
+ HPSB_ERR("Failed to add sysfs attributes for unit %s",
+ ud->device.bus_id);
}
@@ -747,7 +777,7 @@ static int __nodemgr_remove_host_dev(str
static void nodemgr_remove_host_dev(struct device *dev)
{
- device_for_each_child(dev, NULL, __nodemgr_remove_host_dev);
+ WARN_ON(device_for_each_child(dev, NULL, __nodemgr_remove_host_dev));
sysfs_remove_link(&dev->kobj, "irm_id");
sysfs_remove_link(&dev->kobj, "busmgr_id");
sysfs_remove_link(&dev->kobj, "host_id");
@@ -791,7 +821,7 @@ static struct node_entry *nodemgr_create
ne = kzalloc(sizeof(*ne), GFP_KERNEL);
if (!ne)
- return NULL;
+ goto fail_alloc;
ne->host = host;
ne->nodeid = nodeid;
@@ -814,12 +844,15 @@ static struct node_entry *nodemgr_create
snprintf(ne->class_dev.class_id, BUS_ID_SIZE, "%016Lx",
(unsigned long long)(ne->guid));
- device_register(&ne->device);
- class_device_register(&ne->class_dev);
+ if (device_register(&ne->device))
+ goto fail_devreg;
+ if (class_device_register(&ne->class_dev))
+ goto fail_classdevreg;
get_device(&ne->device);
- if (ne->guid_vendor_oui)
- device_create_file(&ne->device, &dev_attr_ne_guid_vendor_oui);
+ if (ne->guid_vendor_oui &&
+ device_create_file(&ne->device, &dev_attr_ne_guid_vendor_oui))
+ goto fail_addoiu;
nodemgr_create_ne_dev_files(ne);
nodemgr_update_bus_options(ne);
@@ -829,6 +862,18 @@ static struct node_entry *nodemgr_create
NODE_BUS_ARGS(host, nodeid), (unsigned long long)guid);
return ne;
+
+fail_addoiu:
+ put_device(&ne->device);
+fail_classdevreg:
+ device_unregister(&ne->device);
+fail_devreg:
+ kfree(ne);
+fail_alloc:
+ HPSB_ERR("Failed to create node ID:BUS[" NODE_BUS_FMT "] GUID[%016Lx]",
+ NODE_BUS_ARGS(host, nodeid), (unsigned long long)guid);
+
+ return NULL;
}
@@ -890,13 +935,25 @@ static void nodemgr_register_device(stru
snprintf(ud->class_dev.class_id, BUS_ID_SIZE, "%s-%u",
ne->device.bus_id, ud->id);
- device_register(&ud->device);
- class_device_register(&ud->class_dev);
+ if (device_register(&ud->device))
+ goto fail_devreg;
+ if (class_device_register(&ud->class_dev))
+ goto fail_classdevreg;
get_device(&ud->device);
- if (ud->vendor_oui)
- device_create_file(&ud->device, &dev_attr_ud_vendor_oui);
+ if (ud->vendor_oui &&
+ device_create_file(&ud->device, &dev_attr_ud_vendor_oui))
+ goto fail_addoui;
nodemgr_create_ud_dev_files(ud);
+
+ return;
+
+fail_addoui:
+ put_device(&ud->device);
+fail_classdevreg:
+ device_unregister(&ud->device);
+fail_devreg:
+ HPSB_ERR("Failed to create unit %s", ud->device.bus_id);
}
@@ -1093,10 +1150,16 @@ static void nodemgr_process_root_directo
last_key_id = kv->key.id;
}
- if (ne->vendor_oui)
- device_create_file(&ne->device, &dev_attr_ne_vendor_oui);
- if (ne->vendor_name_kv)
- device_create_file(&ne->device, &dev_attr_ne_vendor_name_kv);
+ if (ne->vendor_oui &&
+ device_create_file(&ne->device, &dev_attr_ne_vendor_oui))
+ goto fail;
+ if (ne->vendor_name_kv &&
+ device_create_file(&ne->device, &dev_attr_ne_vendor_name_kv))
+ goto fail;
+ return;
+fail:
+ HPSB_ERR("Failed to add sysfs attribute for node %016Lx",
+ (unsigned long long)ne->guid);
}
#ifdef CONFIG_HOTPLUG
@@ -1169,7 +1232,7 @@ int hpsb_register_protocol(struct hpsb_p
if (!ret)
nodemgr_create_drv_files(driver);
- return ret;
+ return 0;
}
void hpsb_unregister_protocol(struct hpsb_protocol_driver *driver)
@@ -1326,7 +1389,7 @@ static void nodemgr_suspend_ne(struct no
NODE_BUS_ARGS(ne->host, ne->nodeid), (unsigned long long)ne->guid);
ne->in_limbo = 1;
- device_create_file(&ne->device, &dev_attr_ne_in_limbo);
+ WARN_ON(device_create_file(&ne->device, &dev_attr_ne_in_limbo));
down_write(&ne->device.bus->subsys.rwsem);
list_for_each_entry(cdev, &nodemgr_ud_class.children, node) {
@@ -1497,7 +1560,7 @@ static void nodemgr_node_probe(struct ho
* just removed. */
if (generation == get_hpsb_generation(host))
- bus_rescan_devices(&ieee1394_bus_type);
+ WARN_ON(bus_rescan_devices(&ieee1394_bus_type));
return;
}
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-10 19:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-10 6:48 [PATCH] firewire: handle sysfs errors Jeff Garzik
2006-10-10 8:38 ` Stefan Richter
2006-10-10 12:52 ` Jeff Garzik
2006-10-10 19:11 ` [PATCH 2.6.19-rc1 1/3] ieee1394: lock smaller region by host_num_alloc mutex Stefan Richter
2006-10-10 19:12 ` [PATCH 2.6.19-rc1 2/3] ieee1394: coding style in hosts.c Stefan Richter
2006-10-10 19:19 ` [PATCH 2.6.19-rc1 3/3] ieee1394: handle sysfs errors Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox