Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression

Andrew Morton
2006-10-05T21:52:36Z

On Thu, 05 Oct 2006 14:43:01 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Andrew Morton wrote:
> > So how's this look?
> >
>
> Looks fine to me. Other than the general question of why WARN_ON*
> returns a value at all, and if so, does the final unlikely() really do
> anything.

Herbert had a good-sounding reason for wanting this feature, but afaict he
hasn't proceeded to use it at this stage. And he's hiding from us ;)