Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression

Tim Chen
2006-10-04T00:37:06Z

On Tue, 2006-10-03 at 17:06 -0700, Jeremy Fitzhardinge wrote:

> How does the generated code change? Doesn't evaluating the condition
> multiple times have the potential to cause problems?
>

I think if the condition changes between two evaluations, we do have a
problem with my fix. I don't have a better idea to avoid using a local
variable to store the condition. I think we should at least reverse the
WARN_ON/WARN_ON_ONCE patch if a better way cannot be found.

Tim