From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Arjan van de Ven <arjan@infradead.org>,
Amol Lad <amol@verismonetworks.com>,
kernel Janitors <kernel-janitors@lists.osdl.org>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: most users of msleep_interruptible are broken
Date: Wed, 11 Oct 2006 16:20:08 +0200 [thread overview]
Message-ID: <452CFD98.6010808@drzeus.cx> (raw)
In-Reply-To: <20061011141651.GD27388@parisc-linux.org>
Matthew Wilcox wrote:
>
> They clearly don't care about exactness; they msleep_interruptible and
> throw away the return value, so they don't know how long they slept
> before they got a signal.
>
It's broken then. That delay function should delay at least the amount
given.
Rgds
Pierre
next prev parent reply other threads:[~2006-10-11 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 12:45 [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Amol Lad
2006-10-11 12:58 ` Arjan van de Ven
2006-10-11 14:16 ` most users of msleep_interruptible are broken Matthew Wilcox
2006-10-11 14:20 ` Pierre Ossman [this message]
2006-10-11 14:53 ` Arjan van de Ven
2006-10-11 15:07 ` Pierre Ossman
2006-10-11 20:30 ` Pavel Machek
2006-10-12 5:54 ` [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Nick Piggin
2006-10-16 6:49 ` Pierre Ossman
2006-10-22 20:23 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452CFD98.6010808@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=amol@verismonetworks.com \
--cc=arjan@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox