From: "H. Peter Anvin" <hpa@zytor.com>
To: Alexander van Heukelum <heukelum@mailshack.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Linus Torvalds <torvalds@osdl.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
John Coffman <johninsd@san.rr.com>
Subject: Re: [PATCH] Remove lilo-loads-only-five-sectors-of-zImage-fixup from setup.S
Date: Wed, 11 Oct 2006 12:43:03 -0700 [thread overview]
Message-ID: <452D4947.80003@zytor.com> (raw)
In-Reply-To: <20061011194301.GA2084@mailshack.com>
Alexander van Heukelum wrote:
>
> The patch should not alter behaviour for any bootloader that takes
> setupsects into account. It just removes 'support' for bootloaders that
> have the size of the setup code hardcoded to 4 sectors.
>
> The current version of setup.S already checks if the bootloader
> understands boot protocol 2.00+ in the case of a big kernel, but that
> code is also after the 2k-mark. The zero-page still has some unused
> space between offsets 0x230 and 0x28f. Shall I put/move some code there
> to check unconditionally if the type_of_loader has been set?
>
> I'll do that if no objections are put forward.
>
The test can be done long before the zeropage is needed. It should
pretty much be done right away.
What I'm saying is that instead of pushing the initialization code
downwards, the E820 & EDD space could overlay the code. It would have
been better, of course, if it was in a completely different chunk of the
address space, but that's probably a much bigger change.
-hpa
next prev parent reply other threads:[~2006-10-11 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 16:33 [PATCH] Remove lilo-loads-only-five-sectors-of-zImage-fixup from setup.S Alexander van Heukelum
2006-10-11 18:38 ` H. Peter Anvin
2006-10-11 19:43 ` Alexander van Heukelum
2006-10-11 19:43 ` H. Peter Anvin [this message]
2006-10-12 16:57 ` John Coffman
2006-10-12 17:04 ` H. Peter Anvin
2006-10-12 18:15 ` Alexander van Heukelum
2006-10-12 17:43 ` looking for explanation of spontaneous reset/reboot on Opteron Edward Goggin
2006-10-12 21:06 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452D4947.80003@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=heukelum@mailshack.com \
--cc=johninsd@san.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox