public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: v9fs-developer@lists.sourceforge.net, asmadeus@codewreck.org,
	rminnich@gmail.com, lucho@ionkov.net,
	Eric Van Hensbergen <evanhensbergen@icloud.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Eric Van Hensbergen <evanhensbergen@icloud.com>
Subject: Re: [PATCH 1/6] Adjust maximum MSIZE to account for p9 header
Date: Sun, 18 Dec 2022 15:49:18 +0100	[thread overview]
Message-ID: <4530979.Ltmge6kleC@silver> (raw)
In-Reply-To: <20221217185210.1431478-2-evanhensbergen@icloud.com>

On Saturday, December 17, 2022 7:52:05 PM CET Eric Van Hensbergen wrote:
> Add maximum p9 header size to MSIZE to make sure we can
> have page aligned data.
> 
> Signed-off-by: Eric Van Hensbergen <evanhensbergen@icloud.com>
> ---
>  net/9p/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/9p/client.c b/net/9p/client.c
> index fef6516a0639..416baf2f1edf 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -28,7 +28,7 @@
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/9p.h>
>  
> -#define DEFAULT_MSIZE (128 * 1024)
> +#define DEFAULT_MSIZE ((128 * 1024) + P9_HDRSZ)

Adding 7 would make what page aligned exactly, the payload? And how?

>  
>  /* Client Option Parsing (code inspired by NFS code)
>   *  - a little lazy - parse all client options
> 




  reply	other threads:[~2022-12-18 14:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 18:52 [PATCH] Improve 9p performance for read operations Eric Van Hensbergen
2022-12-17 18:52 ` [PATCH 1/6] Adjust maximum MSIZE to account for p9 header Eric Van Hensbergen
2022-12-18 14:49   ` Christian Schoenebeck [this message]
     [not found]     ` <CAFkjPTmoQvzaSsSOAgM9_0+knudWsdi8=TnMOTXZj05hT6tneQ@mail.gmail.com>
     [not found]       ` <51FD8D16-4070-4DCF-AEB5-11640A82762E@icloud.com>
     [not found]         ` <CAP6exY+BF+1fjjUKX20vvbTZXiZ2gxUN3zc8+ZaHTY-aX6fRFQ@mail.gmail.com>
2022-12-18 19:46           ` asmadeus
2022-12-18 19:52             ` evanhensbergen
2022-12-17 18:52 ` [PATCH 2/6] Don't assume UID 0 attach Eric Van Hensbergen
2022-12-18  0:07   ` asmadeus
2022-12-18  1:05     ` evanhensbergen
     [not found]       ` <864E1007-CBCF-40C7-B438-A76C3065AFC9@icloud.com>
2022-12-18 19:49         ` [V9fs-developer] " asmadeus
2022-12-18 19:59           ` evanhensbergen
2022-12-17 18:52 ` [PATCH 3/6] Expand setup of writeback cache to all levels Eric Van Hensbergen
2022-12-17 18:52 ` [PATCH 4/6] Consolidate file operations and add readahead and writeback Eric Van Hensbergen
2022-12-17 20:49   ` kernel test robot
2022-12-17 21:50   ` kernel test robot
2022-12-17 18:52 ` [PATCH 5/6] Remove unnecessary superblock flags Eric Van Hensbergen
2022-12-17 18:52 ` [PATCH 6/6] allow disable of xattr support on mount Eric Van Hensbergen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4530979.Ltmge6kleC@silver \
    --to=linux_oss@crudebyte.com \
    --cc=asmadeus@codewreck.org \
    --cc=evanhensbergen@icloud.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=rminnich@gmail.com \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox