From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: mchehab@infradead.org, linux-kernel@vger.kernel.org,
linux-dvb-maintainer@linuxtv.org,
Andrew de Quincey <adq_dvb@lidskialf.net>
Subject: Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach
Date: Sat, 14 Oct 2006 14:57:10 -0400 [thread overview]
Message-ID: <45313306.104@linuxtv.org> (raw)
In-Reply-To: <20061014183322.GS30596@stusta.de>
Adrian Bunk wrote:
>On Sat, Oct 14, 2006 at 02:10:33PM -0400, Michael Krufky wrote:
>
>
>>>This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m.
>>>
>>>
>>Regardless, the patch must be applied. The above should only break with DVB_FE_CUSTOMIZE=Y ...
>>
>>Turn off DVB_FE_CUSTOMIZE, and you will find that the above does NOT break. You can probably reproduce this 'broken' situation by setting any card driver = y, with the frontend = m ...
>>
>>As stated in the prior thread, "CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m" is not the problem -- rather, "CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m, DVB_FE_CUSTOMIZE=Y" causes the breakage.
>>
>>
>This patch fixes only a part of the problem.
>
>If this is the way how you want to handle CONFIG_DVB_FE_CUSTOMIZE=y,
>I don't understand why you don't use
> #if defined(CONFIG_DVB_TDA826X) || (defined(CONFIG_DVB_TDA826X_MODULE) && defined(MODULE))
>which is what I stated in exactly the thread you quote.
>
>
Adrian --
Two separate problems, please do not confuse them.
My tda10086 and tda826x patches are correct -- there is no question of it.
I did not get an email from you with a suggestion for a fix for
DVB_FE_CUSTOMIZE, but my cable / internet has been down for a day and a
half, maybe it will come in soon.
I am not the author of DVB_FE_CUSTOMIZE, adq (cc added) seems to be busy
at the moment. Please send in your patch suggestion to the
v4l-dvb-maintainer list, if you haven't already, and we can discuss that
issue separately.
-Mike Krufky
next prev parent reply other threads:[~2006-10-14 18:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 11:53 [PATCH 00/18] V4L/DVB fixes mchehab
2006-10-14 12:00 ` [PATCH 02/18] V4L/DVB (4725): Fix vivi compile on parisc mchehab
2006-10-14 12:00 ` [PATCH 09/18] V4L/DVB (4738): Bt8xx/dvb-bt8xx.c: check kmalloc() return value mchehab
2006-10-14 12:00 ` [PATCH 05/18] V4L/DVB (4731a): Kconfig: restore pvrusb2 menu items mchehab
2006-10-14 12:00 ` [PATCH 03/18] V4L/DVB (4727): Support status readout for saa713x based FM radio mchehab
2006-10-14 12:00 ` [PATCH 04/18] V4L/DVB (4729): Fix VIDIOC_G_FMT for NTSC in cx25840 mchehab
2006-10-14 12:00 ` [PATCH 06/18] V4L/DVB (4732): Fix spelling error in Kconfig help text for DVB_CORE_ATTACH mchehab
2006-10-14 12:00 ` [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach mchehab
2006-10-14 12:16 ` Adrian Bunk
2006-10-14 18:10 ` Michael Krufky
2006-10-14 18:33 ` Adrian Bunk
2006-10-14 18:57 ` Michael Krufky [this message]
2006-10-14 19:14 ` Adrian Bunk
2006-10-15 1:55 ` Mauro Carvalho Chehab
2006-10-15 12:38 ` Adrian Bunk
2006-10-16 0:01 ` [v4l-dvb-maintainer] " Trent Piepho
2006-10-14 12:00 ` [PATCH 01/18] V4L/DVB (4692): Add WinTV-HVR3000 DVB-T support mchehab
2006-10-14 12:00 ` [PATCH 07/18] V4L/DVB (4733): Tda10086: fix frontend selection for dvb_attach mchehab
2006-10-14 12:14 ` Adrian Bunk
2006-10-14 18:12 ` Michael Krufky
2006-10-14 18:33 ` Adrian Bunk
2006-10-14 12:00 ` [PATCH 16/18] V4L/DVB (4746): HM12 is YUV 4:2:0, not YUV 4:1:1 mchehab
2006-10-14 12:00 ` [PATCH 15/18] V4L/DVB (4744): The Samsung TCPN2121P30A does not have a tda9887 mchehab
2006-10-14 12:00 ` [PATCH 10/18] V4L/DVB (4739): SECAM support for saa7113 into saa7115 mchehab
2006-10-14 12:00 ` [PATCH 13/18] V4L/DVB (4742): Drivers/media/video: handle sysfs errors mchehab
2006-10-14 12:00 ` [PATCH 12/18] V4L/DVB (4741): {ov511,stv680}: " mchehab
2006-10-14 12:00 ` [PATCH 11/18] V4L/DVB (4740): Fixed an if-block to avoid floating with debug-messages mchehab
2006-10-14 12:00 ` [PATCH 14/18] V4L/DVB (4743): Fix oops in VIDIOC_G_PARM mchehab
2006-10-14 12:00 ` [PATCH 18/18] V4L/DVB (4750): AGC command1/2 is board specific mchehab
2006-10-14 12:00 ` [PATCH 17/18] V4L/DVB (4748): Fixed oops for Nova-T USB2 mchehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45313306.104@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=adq_dvb@lidskialf.net \
--cc=bunk@stusta.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox