* [PATCH 2.6.19-rc2-mm1] Fix fake return address
@ 2006-10-18 2:21 Jeremy Fitzhardinge
2006-10-18 11:15 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2006-10-18 2:21 UTC (permalink / raw)
To: Andi Kleen, Andrew Morton, Linux Kernel Mailing List
The fake return address was being set to __KERNEL_PDA, rather than 0.
Push it earlier while %eax still equals 0.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Andi Kleen <ak@muc.de>
Cc: Andrew Morton <akpm@osdl.org>
diff -r b8e58159855c arch/i386/kernel/head.S
--- a/arch/i386/kernel/head.S Tue Oct 17 19:04:59 2006 -0700
+++ b/arch/i386/kernel/head.S Tue Oct 17 19:05:46 2006 -0700
@@ -316,12 +316,12 @@ 1: movl $(__KERNEL_DS),%eax # reload all
xorl %eax,%eax # Clear FS and LDT
movl %eax,%fs
lldt %ax
+ pushl %eax # fake return address
movl $(__KERNEL_PDA),%eax
mov %eax,%gs
cld # gcc2 wants the direction flag cleared at all times
- pushl %eax # fake return address
#ifdef CONFIG_SMP
movb ready, %cl
movb $1, ready
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.19-rc2-mm1] Fix fake return address
2006-10-18 2:21 [PATCH 2.6.19-rc2-mm1] Fix fake return address Jeremy Fitzhardinge
@ 2006-10-18 11:15 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-10-18 11:15 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Andrew Morton, Linux Kernel Mailing List, jbeulich
On Tue, Oct 17, 2006 at 07:21:38PM -0700, Jeremy Fitzhardinge wrote:
> The fake return address was being set to __KERNEL_PDA, rather than 0.
> Push it earlier while %eax still equals 0.
Oops. That might explain some of the unwind problems. Thanks.
-Andi
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Cc: Andi Kleen <ak@muc.de>
> Cc: Andrew Morton <akpm@osdl.org>
>
> diff -r b8e58159855c arch/i386/kernel/head.S
> --- a/arch/i386/kernel/head.S Tue Oct 17 19:04:59 2006 -0700
> +++ b/arch/i386/kernel/head.S Tue Oct 17 19:05:46 2006 -0700
> @@ -316,12 +316,12 @@ 1: movl $(__KERNEL_DS),%eax # reload all
> xorl %eax,%eax # Clear FS and LDT
> movl %eax,%fs
> lldt %ax
> + pushl %eax # fake return address
>
> movl $(__KERNEL_PDA),%eax
> mov %eax,%gs
>
> cld # gcc2 wants the direction flag cleared at
> all times
> - pushl %eax # fake return address
> #ifdef CONFIG_SMP
> movb ready, %cl
> movb $1, ready
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-18 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-18 2:21 [PATCH 2.6.19-rc2-mm1] Fix fake return address Jeremy Fitzhardinge
2006-10-18 11:15 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox