public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Whitwell <keith@tungstengraphics.com>
To: Keith Packard <keithp@keithp.com>
Cc: Ryan Richter <ryan@tau.solarneutrino.net>,
	dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Intel 965G: i915_dispatch_cmdbuffer failed (2.6.19-rc2)
Date: Wed, 18 Oct 2006 07:54:41 +0100	[thread overview]
Message-ID: <4535CFB1.2010403@tungstengraphics.com> (raw)
In-Reply-To: <1161124062.25439.8.camel@neko.keithp.com>

This is all a little confusing as the driver doesn't really use that 
path in normal operation except for a single command - MI_FLUSH, which 
is shared between the architectures.  In normal operation the hardware 
does the validation for us for the bulk of the command stream.  If there 
  were missing functionality in that ioctl, it would be failing 
everywhere, not just in this one case.

I guess the questions I'd have are
	- did the driver work before the kernel upgrade?
	- what path in userspace is seeing you end up in this ioctl?
	- and like Keith, what commands are you seeing?

The final question is interesting not because we want to extend the 
ioctl to cover those, but because it will give a clue how you ended up 
there in the first place.

Keith

Keith Packard wrote:
> On Tue, 2006-10-17 at 13:40 -0400, Ryan Richter wrote:
> 
>> So do I want something like
>>
>>
>> static int do_validate_cmd(int cmd)
>> {
>> 	return 1;
>> }
>>
>> in i915_dma.c?
> 
> that will certainly avoid any checks. Another alternative is to printk
> the cmd which fails validation so we can see what needs adding here.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> 
> 
> ------------------------------------------------------------------------
> 
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel


  parent reply	other threads:[~2006-10-18  6:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 19:45 Intel 965G: i915_dispatch_cmdbuffer failed (2.6.19-rc2) Ryan Richter
2006-10-14  8:55 ` Keith Whitwell
2006-10-14  9:49   ` Arjan van de Ven
2006-10-14  9:58     ` Keith Whitwell
2006-10-14 10:55 ` Avi Kivity
2006-10-14 18:15 ` Keith Packard
2006-10-17 17:40   ` Ryan Richter
2006-10-17 22:27     ` Keith Packard
2006-10-17 23:56       ` Ryan Richter
2006-10-18  6:54       ` Keith Whitwell [this message]
2006-10-18  7:01         ` Dave Airlie
2006-10-19 17:31         ` Ryan Richter
2006-10-20 11:43           ` Keith Whitwell
2006-10-20 16:40             ` Ryan Richter
2006-10-20 17:51               ` Keith Whitwell
2006-10-20 18:03                 ` Ryan Richter
2006-10-20 18:09                   ` Keith Whitwell
2006-10-24 12:21               ` Avi Kivity
2006-10-24 14:07                 ` Ryan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4535CFB1.2010403@tungstengraphics.com \
    --to=keith@tungstengraphics.com \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryan@tau.solarneutrino.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox