From: Srinivasa Ds <srinivasa@in.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org,
Srivatsa Vaddagiri <vatsa@in.ibm.com>
Subject: Re: [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32
Date: Wed, 18 Oct 2006 17:34:49 +0530 [thread overview]
Message-ID: <45361861.3060706@in.ibm.com> (raw)
In-Reply-To: <17715.3265.870339.317367@cargo.ozlabs.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Paul Mackerras wrote:
> Srinivasa Ds writes:
>
>
>> arch/powerpc/platforms/built-in.o: In function `flush_disable_caches':
>> (.text+0x96d4): undefined reference to `low_cpu_die'
>> ======================================================
>> low_cpu_die() is defined under CONFIG_PM || CONFIG_CPU_FREQ_PMAC
>> options ,but while calling this function ,no care has been to taken to
>> check these options. So please apply this fix,which solves the problem.
>>
>
> Nack. The correct fix is to adjust the ifdefs in sleep.S to make
> low_cpu_die available. Otherwise it won't be possible to off-line
> CPUs properly.
>
So resending the patch, by adjusting ifdefs in sleep.S
Signed-off-by: Srinivasa DS <srinivasa@in.ibm.com>
> Paul.
>
[-- Attachment #2: low_cpu_die.fix --]
[-- Type: text/plain, Size: 718 bytes --]
---
arch/powerpc/platforms/powermac/sleep.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.19-rc2/arch/powerpc/platforms/powermac/sleep.S
===================================================================
--- linux-2.6.19-rc2.orig/arch/powerpc/platforms/powermac/sleep.S
+++ linux-2.6.19-rc2/arch/powerpc/platforms/powermac/sleep.S
@@ -45,7 +45,7 @@
.section .text
.align 5
-#if defined(CONFIG_PM) || defined(CONFIG_CPU_FREQ_PMAC)
+#if defined(CONFIG_PM) || defined(CONFIG_CPU_FREQ_PMAC) || (defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_PPC32))
/* This gets called by via-pmu.c late during the sleep process.
* The PMU was already send the sleep command and will shut us down
prev parent reply other threads:[~2006-10-18 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 10:19 [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32 Srinivasa Ds
2006-10-16 4:38 ` Paul Mackerras
2006-10-18 12:04 ` Srinivasa Ds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45361861.3060706@in.ibm.com \
--to=srinivasa@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox