From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Miguel Ojeda Sandonis <maxextreme@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support
Date: Wed, 18 Oct 2006 16:55:05 +0200 [thread overview]
Message-ID: <45364049.3030404@innova-card.com> (raw)
In-Reply-To: <20061013023218.31362830.maxextreme@gmail.com>
Hi
Miguel Ojeda Sandonis wrote:
> Andrew, here it is the complete patch again as you requested.
>
sorry for coming lately, I just noticed your patch in -mm tree.
Did you took a look at drivers/video/arcfb.c driver ?
It seems to be a fb driver for ks108 lcd controller. A lot of code
is related to the platform though and the controller is driven
through GPIO but have you tried to split the code for sharing
controller specific code. Note, I don't say it's a good idea, it's
just a question that comes in mind.
Also you create driver/auxdisplay directory whereas drivers such
the one I mentioned previously is located in drivers/video. Why
not putting your driver in driver/video ?
Franck
next prev parent reply other threads:[~2006-10-18 14:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 2:32 [PATCH 2.6.19-rc1 full] drivers: add LCD support Miguel Ojeda Sandonis
2006-10-13 12:43 ` Paulo Marques
2006-10-18 14:55 ` Franck Bui-Huu [this message]
2006-10-23 8:41 ` Franck Bui-Huu
2006-10-23 12:56 ` Miguel Ojeda
2006-10-23 15:35 ` Franck Bui-Huu
2006-10-23 16:21 ` Miguel Ojeda
2006-10-23 16:51 ` Franck Bui-Huu
2006-10-26 14:45 ` Miguel Ojeda
2006-10-27 20:08 ` Franck Bui-Huu
2006-10-27 20:38 ` Miguel Ojeda
2006-10-30 8:43 ` Franck Bui-Huu
2006-10-30 13:35 ` Miguel Ojeda
2006-10-23 16:05 ` Franck Bui-Huu
2006-10-23 16:08 ` Miguel Ojeda
2006-10-23 17:15 ` Franck Bui-Huu
2006-10-26 14:55 ` Miguel Ojeda
2006-10-27 20:03 ` Franck Bui-Huu
2006-10-27 20:25 ` Miguel Ojeda
2006-10-30 9:26 ` Franck Bui-Huu
2006-10-30 13:22 ` Paulo Marques
2006-10-30 14:11 ` Miguel Ojeda
2006-10-30 15:21 ` Paulo Marques
2006-10-30 17:32 ` Miguel Ojeda
2006-10-30 20:45 ` Paulo Marques
2006-10-31 8:10 ` Franck Bui-Huu
2006-10-31 14:12 ` Miguel Ojeda
2006-10-31 14:54 ` Paulo Marques
2006-10-30 13:47 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45364049.3030404@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxextreme@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox