From: Corey Minyard <minyard@acm.org>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [IPMI] Fix return codes in failure case.
Date: Wed, 18 Oct 2006 10:08:10 -0500 [thread overview]
Message-ID: <4536435A.8010002@acm.org> (raw)
In-Reply-To: <20061018042817.GA7475@redhat.com>
Thanks, looks good.
-Corey
Dave Jones wrote:
> These returns should be negative, like the others in this function.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 24825bd..e5cfb1f 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru
>
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> if (!info)
> - return ENOMEM;
> + return -ENOMEM;
>
> info->addr_source = "PCI";
>
> @@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(stru
> kfree(info);
> printk(KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n",
> pci_name(pdev), class_type);
> - return ENOMEM;
> + return -ENOMEM;
> }
>
> rv = pci_enable_device(pdev);
>
>
prev parent reply other threads:[~2006-10-18 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 4:28 [IPMI] Fix return codes in failure case Dave Jones
2006-10-18 15:08 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4536435A.8010002@acm.org \
--to=minyard@acm.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox