From: Santiago Leon <santil@us.ibm.com>
To: David Gibson <dwg@au1.ibm.com>, Santiago Leon <santil@us.ibm.com>,
Jeff Garzik <jeff@garzik.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: veth crash (commit 751ae21c6cd1493e3d0a4935b08fb298b9d89773)
Date: Wed, 18 Oct 2006 11:22:15 -0500 [thread overview]
Message-ID: <453654B7.2040607@us.ibm.com> (raw)
In-Reply-To: <20061013042059.GA6500@localhost.localdomain>
David Gibson wrote:
> Jeff, Santiago, please apply the patch below to correct this:
>
> ibmveth: Fix index increment calculation
>
> The recent commit 751ae21c6cd1493e3d0a4935b08fb298b9d89773 introduced
> a bug in the producer/consumer index calculation in the ibmveth driver
> - incautious use of the post-increment ++ operator resulted in an
> increment being immediately reverted. This patch corrects the logic.
>
> Without this patch, the driver oopses almost immediately after
> activation on at least some machines.
>
> Signed-off-by: David Gibson <dwg@au1.ibm.com>
David, I'm not sure how it got past the testing that I did, but thanks
for catching this.
Jeff, can you apply? Thank you.
Signed-off-by: Santiago Leon <santil@us.ibm.com
--
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
prev parent reply other threads:[~2006-10-18 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 8:22 veth crash (commit 751ae21c6cd1493e3d0a4935b08fb298b9d89773) David Gibson
2006-10-13 4:20 ` David Gibson
2006-10-18 16:22 ` Santiago Leon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453654B7.2040607@us.ibm.com \
--to=santil@us.ibm.com \
--cc=akpm@osdl.org \
--cc=dwg@au1.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox