public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Williams <pwil3058@bigpond.net.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] sched_tick with interrupts enabled
Date: Thu, 19 Oct 2006 04:09:52 +1000	[thread overview]
Message-ID: <45366DF0.6040702@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0610181059570.28750@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
>>After that, it might be acceptable to call rebalance_tick from a tasklet,
>>although it would be uneeded overhead on small systems. It might be better
> 
> 
> Here is a patch that only runs rebalance tick from a tasklet in the 
> scheduler. For UP there will be no tasklet.
> 
> [RFC] sched_rebalance_tick with interrupts enabled
> 
> scheduler_tick() has the potential of running for some time if f.e.
> sched_domains for a system with 1024 processors have to be balanced.
> We currently do all of that with interrupts disabled. So we may be unable
> to service interrupts for some time. Most of that time is potentially
> spend in rebalance_tick.
> 
> This patch splits off rebalance_tick from scheduler_tick and schedules
> it via a tasklet.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>

wake_priority_sleeper should not be called from rebalance_tick. That
code was OK where it was before, I think.

And you need to now turn off interrupts when doing the locking in
load_balance.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

  reply	other threads:[~2006-10-18 18:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-18 17:04 [RFC] sched_tick with interrupts enabled Christoph Lameter
2006-10-18 17:21 ` Nick Piggin
2006-10-18 18:01   ` Christoph Lameter
2006-10-18 18:09     ` Nick Piggin [this message]
2006-10-18 18:48       ` Christoph Lameter
2006-10-18 19:14         ` Nick Piggin
2006-10-18 21:59           ` Christoph Lameter
2006-10-19  2:19             ` Siddha, Suresh B
2006-10-19 10:16               ` KAMEZAWA Hiroyuki
2006-10-19 15:50               ` Christoph Lameter
2006-10-19 20:40                 ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45366DF0.6040702@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pwil3058@bigpond.net.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox