Re: [RFC] [PATCH] Improve the remove sysctl warnings.

Cal Peake
2006-10-19T19:55:52Z

On Thu, 19 Oct 2006, Alexey Dobriyan wrote:

> On Thu, Oct 19, 2006 at 12:25:20PM -0400, Cal Peake wrote:
> > On Wed, 18 Oct 2006, Eric W. Biederman wrote:
> >
> > > if (msg_count < 5) {
> > > msg_count++;
> > > printk(KERN_INFO
> > > "warning: process `%s' used the removed sysctl "
> > > - "system call\n", current->comm);
> > > + "system call with ", current->comm);
> > > + for (i = 0; i < tmp.nlen; i++)
> > > + printk("%d.", name[i]);
> > > + printk("\n");
> > > }
> >
> > We should prolly kill the counter now.
>
> sysctl(2) callable by everyone including local lusers willing to fill logs.

Users don't even need to write a program to do this, see logger(1). If we
keep the counter then after 5 calls we lose potential debugging info.

- C.

--
"There is nothing wrong with your television set. Do not attempt
to adjust the picture. We are controlling transmission."
-- The Outer Limits