Re: [PATCH 3/6] video: use bitrev8

[Michael Tokarev <mjt@tls.msk.ru>]

Akinobu Mita wrote:
> Use bitrev8 for nvidiafb, rivafb, and tgafb drivers
> 
> Cc: Antonino Daplas <adaplas@pol.net>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> 
>  drivers/video/Kconfig           |    3 ++
>  drivers/video/nvidia/nv_accel.c |   35 -------------------------
>  drivers/video/nvidia/nv_local.h |   11 +++++--
>  drivers/video/nvidia/nv_proto.h |    1 
>  drivers/video/riva/fbdev.c      |   44 +++----------------------------
>  drivers/video/tgafb.c           |   56 +++++++---------------------------------
>  6 files changed, 26 insertions(+), 124 deletions(-)
> 
> Index: work-fault-inject/drivers/video/riva/fbdev.c
> ===================================================================
> --- work-fault-inject.orig/drivers/video/riva/fbdev.c
> +++ work-fault-inject/drivers/video/riva/fbdev.c
[]
>  static inline void reverse_order(u32 *l)
>  {
>  	u8 *a = (u8 *)l;
> -	*a = byte_rev[*a], a++;
> -	*a = byte_rev[*a], a++;
> -	*a = byte_rev[*a], a++;
> -	*a = byte_rev[*a];
> +	a[0] = bitrev8(a[0]);
> +	a[1] = bitrev8(a[1]);
> +	a[2] = bitrev8(a[2]);
> +	a[3] = bitrev8(a[3]);
>  }

This looks like a good candidate for a common helper function, too.

/mjt