From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161390AbWJSKys (ORCPT ); Thu, 19 Oct 2006 06:54:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161396AbWJSKyr (ORCPT ); Thu, 19 Oct 2006 06:54:47 -0400 Received: from smtp101.mail.mud.yahoo.com ([209.191.85.211]:57208 "HELO smtp101.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S1161389AbWJSKyq (ORCPT ); Thu, 19 Oct 2006 06:54:46 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=fu3nXt0RiO7OqP8148mK1NesGjtY/VeSEjLTGKIfSi6zABLCvaIH7mPvKGOqMZliXak1fspdbiYcSQhqxricl7Ee+tK/O1mAYgU/ApG33UuXqMOkhzviUwzZq02xfUKGOOi9XIiOxfR7s9wZ3WwhQs9GtviE16q3w2Jz3urf/k0= ; Message-ID: <45375971.8080707@yahoo.com.au> Date: Thu, 19 Oct 2006 20:54:41 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 X-Accept-Language: en MIME-Version: 1.0 To: Peter Zijlstra CC: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nick Piggin , Andrew Morton Subject: Re: [RFC][PATCH 1/4] mm: arch do_page_fault() vs in_atomic() References: <20061019101722.805147000@chello.nl> <20061019102309.179968000@chello.nl> In-Reply-To: <20061019102309.179968000@chello.nl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, This patchset looks pretty nice to me. Acked-by: Nick Piggin One minor nit: Peter Zijlstra wrote: > In light of the recent pagefault and filemap_copy_from_user work I've > gone through all the arch pagefault handlers to make sure the > inc_preempt_count() 'feature' works as expected. > > Several sections of code (including the new filemap_copy_from_user) rely > on the fact that faults do not take locks under increased preempt count. > > arch/x86_64 - good > arch/powerpc - good > arch/cris - fixed > arch/i386 - good > arch/parisc - fixed > arch/sh - good > arch/sparc - good > arch/s390 - good > arch/m68k - fixed > arch/ppc - good > arch/alpha - fixed > arch/mips - good > arch/sparc64 - good > arch/ia64 - good > arch/arm - fixed > arch/um - NA um does have a fault handler (in kernel/trap.c), but it gets the in_atomic check correct. Thanks for doing this. Nick -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com