From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Carsten Otte <cotte@freenet.de>
Cc: Andrew Morton <akpm@osdl.org>, Cedric Le Goater <clg@fr.ibm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Gabriel C <nix.or.die@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.19-rc2-mm1
Date: Fri, 20 Oct 2006 04:10:18 +1000 [thread overview]
Message-ID: <4537BF8A.9040004@yahoo.com.au> (raw)
In-Reply-To: <4537A263.4090601@freenet.de>
Carsten Otte wrote:
> Andrew Morton wrote:
>
>> The page we're writing into isn't locked, so there's no deadlock afaict.
>>
>> But then, I forget how xip works. Carsten, is it actually being used for
>> anything?
>>
>
> The comment may be superfluous. I did not quite understand the deadlock
> condition refered to by the comment in filemap, therefore I cut&pasted
> it over. I will send a patch that removes it.
Yes, it wasn't a good comment. Basically we can't hold the page lock and
then enter the page fault handler. mm-fix-pagecache-write-deadlocks.patch
has quite a lot of comments to explain it.
I don't believe filemap_xip holds the page lock, so you don't need to do
the atomic copy, and you don't need to do the fault_in_pages_readable.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-10-19 18:10 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 6:06 2.6.19-rc2-mm1 Andrew Morton
[not found] ` <a44ae5cd0610170003r77595cc0p8ed66badde952859@mail.gmail.com>
2006-10-17 7:36 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-17 8:41 ` 2.6.19-rc2-mm1 Brice Goglin
2006-10-17 12:54 ` [PATCH] backlight users need to select BACKLIGHT_CLASS_DEVICE Andy Whitcroft
2006-10-17 13:17 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-17 14:23 ` 2.6.19-rc2-mm1 Andy Whitcroft
2006-10-17 16:07 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-17 18:22 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:44 ` 2.6.19-rc2-mm1 Dylan Taft
2006-10-17 15:45 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-17 18:29 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-20 13:40 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-17 19:37 ` 2.6.19-rc2-mm1 Jeremy Fitzhardinge
2006-10-17 20:22 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 10:05 ` 2.6.19-rc2-mm1 Michael Ellerman
2006-10-18 19:05 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-17 19:53 ` [2.6.19-rc2-mm1] error: too few arguments to function ‘crypto_alloc_hash’ Andrew James Wade
2006-10-17 21:19 ` Edward Shishkin
2006-10-18 16:53 ` Andrew James Wade
2006-10-18 15:33 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 15:48 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:15 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 17:26 ` 2.6.19-rc2-mm1 Chris Mason
2006-10-18 17:32 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:41 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 17:56 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:58 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 18:14 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 18:22 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 18:31 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 23:59 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 22:44 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 23:01 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 23:25 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 0:07 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-19 0:21 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 15:28 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-19 12:32 ` 2.6.19-rc2-mm1 Andi Kleen
2006-10-19 16:18 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 16:57 ` 2.6.19-rc2-mm1 Andi Kleen
2006-10-18 18:27 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 19:18 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-18 19:33 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-18 19:42 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 20:20 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-18 20:26 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-18 22:23 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 16:05 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-19 18:10 ` Nick Piggin [this message]
2006-10-20 7:37 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-18 20:22 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 18:42 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 21:44 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 22:29 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:41 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 22:46 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:57 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 23:04 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 23:12 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 14:45 ` 2.6.19-rc2-mm1 // errors in verify_redzone_free() Mariusz Kozlowski
2006-10-19 17:03 ` Andrew Morton
2006-10-19 17:17 ` Jean Tourrilhes
2006-10-19 17:25 ` Andrew Morton
2006-10-19 17:47 ` Jean Tourrilhes
2006-10-19 18:31 ` Mariusz Kozlowski
2006-10-19 18:33 ` Jean Tourrilhes
2006-10-19 17:33 ` Mariusz Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4537BF8A.9040004@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=clg@fr.ibm.com \
--cc=cotte@freenet.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox