public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Alan Cox <alan@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc2-mm2] fix tty_ioctl powerpc build
Date: Fri, 20 Oct 2006 20:52:03 +0100	[thread overview]
Message-ID: <453928E3.5090708@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0610201626500.12392@blonde.wat.veritas.com>

Hugh Dickins wrote:
> Fix tty_ioctl.c compilation errors and warnings on PowerPC, coming from
> the tty-switch-to-ktermios patches; and make its ktermios the same as
> its termios (as the comment says).
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> 
>  drivers/char/tty_ioctl.c       |    4 ++--
>  include/asm-generic/termios.h  |    4 ++--
>  include/asm-powerpc/termbits.h |    2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> --- 2.6.19-rc2-mm2/drivers/char/tty_ioctl.c	2006-10-20 12:31:43.000000000 +0100
> +++ linux/drivers/char/tty_ioctl.c	2006-10-20 13:34:29.000000000 +0100
> @@ -495,8 +495,8 @@ static int get_sgttyb(struct tty_struct 
>  	struct sgttyb tmp;
>  
>  	mutex_lock(&tty->termios_mutex);
> -	tmp.sg_ispeed = tty->c_ispeed;
> -	tmp.sg_ospeed = tty->c_ospeed;
> +	tmp.sg_ispeed = tty->termios->c_ispeed;
> +	tmp.sg_ospeed = tty->termios->c_ospeed;
>  	tmp.sg_erase = tty->termios->c_cc[VERASE];
>  	tmp.sg_kill = tty->termios->c_cc[VKILL];
>  	tmp.sg_flags = get_sgflags(tty);
> --- 2.6.19-rc2-mm2/include/asm-generic/termios.h	2005-03-02 07:39:27.000000000 +0000
> +++ linux/include/asm-generic/termios.h	2006-10-20 13:53:58.000000000 +0100
> @@ -11,7 +11,7 @@
>  /*
>   * Translate a "termio" structure into a "termios". Ugh.
>   */
> -static inline int user_termio_to_kernel_termios(struct termios *termios,
> +static inline int user_termio_to_kernel_termios(struct ktermios *termios,
>  						struct termio __user *termio)
>  {
>  	unsigned short tmp;
> @@ -48,7 +48,7 @@ static inline int user_termio_to_kernel_
>   * Translate a "termios" structure into a "termio". Ugh.
>   */
>  static inline int kernel_termios_to_user_termio(struct termio __user *termio,
> -						struct termios *termios)
> +						struct ktermios *termios)
>  {
>  	if (put_user(termios->c_iflag, &termio->c_iflag) < 0 ||
>  	    put_user(termios->c_oflag, &termio->c_oflag) < 0 ||
> --- 2.6.19-rc2-mm2/include/asm-powerpc/termbits.h	2006-10-20 12:31:49.000000000 +0100
> +++ linux/include/asm-powerpc/termbits.h	2006-10-20 13:44:42.000000000 +0100
> @@ -37,8 +37,8 @@ struct ktermios {
>  	tcflag_t c_oflag;		/* output mode flags */
>  	tcflag_t c_cflag;		/* control mode flags */
>  	tcflag_t c_lflag;		/* local mode flags */
> -	cc_t c_line;			/* line discipline */
>  	cc_t c_cc[NCCS];		/* control characters */
> +	cc_t c_line;			/* line discipline (== c_cc[19]) */
>  	speed_t c_ispeed;		/* input speed */
>  	speed_t c_ospeed;		/* output speed */
>  };
> -

Sorts booting for my ppc's.

Acked-by: Andy Whitcroft <apw@shadowen.org>

-apw

  parent reply	other threads:[~2006-10-20 19:52 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20  8:56 2.6.19-rc2-mm2 Andrew Morton
2006-10-20  9:34 ` 2.6.19-rc2-mm2 Cornelia Huck
2006-10-20 13:19   ` 2.6.19-rc2-mm2 Alan Cox
2006-10-20 11:39 ` 2.6.19-rc2-mm2 Mariusz Kozlowski
2006-10-20 13:32   ` 2.6.19-rc2-mm2 Anton Vorontsov
2006-10-20 14:57     ` 2.6.19-rc2-mm2 Mariusz Kozlowski
2006-10-20 16:19   ` 2.6.19-rc2-mm2 Andrew Morton
2006-10-20 16:54     ` 2.6.19-rc2-mm2 Mariusz Kozlowski
2006-10-20 17:25       ` 2.6.19-rc2-mm2 Andrew Morton
2006-10-20 22:37         ` 2.6.19-rc2-mm2 Matthew Frost
2006-10-21  0:16           ` 2.6.19-rc2-mm2 Andi Kleen
2006-10-21  0:50             ` 2.6.19-rc2-mm2 Greg KH
2006-10-21  2:13               ` 2.6.19-rc2-mm2 Andi Kleen
2006-10-21  3:55                 ` 2.6.19-rc2-mm2 Greg KH
2006-10-22  0:34             ` 2.6.19-rc2-mm2 Matthew Frost
2006-10-21  0:48         ` 2.6.19-rc2-mm2 Greg KH
2006-10-23  7:58         ` 2.6.19-rc2-mm2 Cornelia Huck
2006-10-24  7:40           ` 2.6.19-rc2-mm2 Greg KH
2006-10-20 11:59 ` 2.6.19-rc2-mm2 Gabriel C
2006-10-20 12:04   ` 2.6.19-rc2-mm2 Jiri Kosina
2006-10-20 12:33     ` 2.6.19-rc2-mm2 Gabriel C
2006-10-20 22:43     ` 2.6.19-rc2-mm2 Andrew Morton
2006-10-23  3:29       ` 2.6.19-rc2-mm2 Mauro Carvalho Chehab
2006-10-20 15:34 ` [PATCH 2.6.19-rc2-mm2] fix tty_ioctl powerpc build Hugh Dickins
2006-10-20 17:59   ` Alan Cox
2006-10-20 19:52   ` Andy Whitcroft [this message]
2006-10-20 15:54 ` 2.6.19-rc2-mm2 Martin J. Bligh
2006-10-20 16:30   ` 2.6.19-rc2-mm2 Badari Pulavarty
2006-10-20 17:31     ` 2.6.19-rc2-mm2 Andy Whitcroft
2006-10-22  2:16   ` 2.6.19-rc2-mm2 Martin J. Bligh
2006-10-22  3:15     ` 2.6.19-rc2-mm2 Dave Jones
2006-10-22  3:24     ` 2.6.19-rc2-mm2 Randy Dunlap
2006-10-22 22:18     ` 2.6.19-rc2-mm2 Andy Whitcroft
2006-10-21  0:24 ` 2.6.19-rc2-mm2 J.A. Magallón
2006-10-21  0:37   ` 2.6.19-rc2-mm2 Jiri Kosina
2006-10-21  0:41   ` 2.6.19-rc2-mm2 Randy Dunlap
2006-10-21 17:30 ` 2.6.19-rc2-mm2: reproducible hang on shutdown on i386 Rafael J. Wysocki
2006-10-23 14:43   ` Rafael J. Wysocki
2006-10-23 17:34     ` Andrew Morton
2006-10-23 21:00       ` Rafael J. Wysocki
2006-10-22 13:32 ` [Nasty crash on boot] was Re: 2.6.19-rc2-mm2 Reuben Farrelly
2006-10-22 18:13   ` Andrew Morton
2006-10-22 22:37     ` Andi Kleen
2006-10-23 20:54 ` 2.6.19-rc2-mm2 Magnus Määttä
2006-10-23 21:04   ` 2.6.19-rc2-mm2 Andrew Morton
2006-10-23 21:22     ` 2.6.19-rc2-mm2 Magnus Määttä
2006-10-24  8:04 ` WARNING: Do not use with EFI-based (e.g. IA64) systems. Bootloader may get eaten Mel Gorman
2006-10-26  6:11 ` 2.6.19-rc2-mm2 Joseph Fannin
2006-10-28  3:18 ` 2.6.19-rc2-mm2 - process_session-helper breaks /sbin/killall5 Valdis.Kletnieks
2006-10-28  4:47   ` Andrew Morton
2006-10-28 17:53     ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453928E3.5090708@shadowen.org \
    --to=apw@shadowen.org \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox